EnumProcesses() not working properly

Question

1.00/5 (1 vote)

See more:

C++

void MyBeautifulFunction()
{
		    DWORD processes[1024], cbNeeded;
			EnumProcesses(processes, sizeof(processes), &cbNeeded);
			DWORD HowManyProcIds = cbNeeded / sizeof(DWORD);

			for (size_t i = 0; i < HowManyProcIds; i++)
			{
				wchar_t szProcessName[MAX_PATH] = L"<unknown>";
				HANDLE hProcess = OpenProcess(PROCESS_QUERY_INFORMATION | PROCESS_VM_READ, FALSE, processes[i]);
				HMODULE ProcMod;
				DWORD cb;

				if (hProcess != NULL)
				{
					if (EnumProcessModules(hProcess, &ProcMod, sizeof(ProcMod), &cb))
						GetModuleBaseName(hProcess, ProcMod, szProcessName, sizeof(szProcessName) / sizeof(wchar_t));

                    //wstring used to store the results
					ProcessesBuffer += szProcessName;
					ProcessesBuffer += L"\n\r";

					CloseHandle(hProcess);
				}
			}
			SetWindowText(EditForEnumeratedProcesses, ProcessesBuffer.c_str());
}

The program gets administration rights on runtime (thanks to this guide I found here : Elevating during runtime)
But the final results equals the one i'd get if the program had no administration rights, it enums half of the real running processes and on a good third of the enumerated ones it fails at naming them leaving the proc name to "unknown"

Thanks in advance

Posted 7-Dec-14 7:14am

Member 11287295

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

barneyman · Accepted Answer · 2014-12-07T11:25:00

this works fine when elevated on my system, don't bother with that codeproject sample, either manually runas admin or change its manifest to require elevation
BTW you can't elevate an app to admin priv if YOU don't have admin rights on the machine

all 153 processes discovered, some unnamed - compiled in 32bit
all 153 processes discovered, all named - compiled in 64bit

oh - and this is a repeat of EnumProcess() not returning all the expected processes[^] - don't repeat questions

void MyBeautifulFunction()
{
	DWORD processes[1024], cbNeeded;
	EnumProcesses(processes, sizeof(processes), &cbNeeded);
	DWORD HowManyProcIds = cbNeeded / sizeof(DWORD);
 
	std::vector<CString> AllProcessesBuffer;

	for (size_t i = 0; i < HowManyProcIds; i++)
	{
		CString processBuffer(_T("unknown"));

		HANDLE hProcess = OpenProcess(PROCESS_QUERY_INFORMATION | PROCESS_VM_READ, FALSE, processes[i]);
		HMODULE ProcMod;
		DWORD cb;
 
		if (hProcess != NULL)
		{

			if (EnumProcessModules(hProcess, &ProcMod, sizeof(ProcMod), &cb))
			{
				wchar_t szProcessName[MAX_PATH];
				GetModuleBaseName(hProcess, ProcMod, szProcessName, sizeof(szProcessName) / sizeof(wchar_t));
				//wstring used to store the results
				processBuffer = szProcessName;
			}
			else
			{
				processBuffer.Format(_T("failed EnumProcessModules %d"), GetLastError());
			}
 
 
			CloseHandle(hProcess);
		}
		else
		{
			processBuffer.Format(_T("Failed OpenProcess %d"),GetLastError());
		}
		AllProcessesBuffer.push_back(processBuffer);
	}

}