|
Han,
I had to change the "for (var i=0; i<nRow; i++)" in sortTable as well.
I was wondering if it would have been better to change "nRow = table.rows.length;" to
"nRow = table.rows.length - 1;" in initTable.
I am new to the world of JavaScript and haven't taken the time to learn how to write it yet, so bear with me when I ask questions.
One thing I see with both table models is the use of <TH> for true heading behavior. SO, when examining the table object, can rows with the <TH> be identified or is that lost once the table is generated?
The issue of the <THEAD> and <TFOOT> could be helpful, especially if you want to trigger the sort from either, but because of the simple model, the <TH> is not restricted to those areas. As I see it, the <TD> is really meant for the cell data.
You may just want to establish a few more rules for the use of this script.
Fred
|
|
|
|
|
Yup. Changing the table length will also do that job.
Yeah ... you have many good suggestions. I think it's time to make the script a bit smarter  I'll see what I can do ... hopefully I can have something soon.
Thanks for your feedback!
- han
|
|
|
|
|
Hi there, this piece of code is really cool,
but I need some advice --> I got tables with
Dates in the following format : 12 Nov 2001
12 Jan 2001
12 Dec 2002
Your code doesn't work that cool on these !
Please I need your help !
ZDragon
|
|
|
|
|
Hi,
The sorting routine uses the literal string ... so the date data won't work ... In order to make it work, you will need to make some changes to the code. Here is one of the ways.
Look at the function "compare". As you may notice, the function is used to compare 2 inputs (i.e. a, b) and returns which one should is "bigger" (in sorting sense). I tried to take care of simple number inputs and strings (see the if statements with isNaN etc). You can write a few lines of code to handle date types. Javascript has Date objects which you can use to compare (<, >, = operators), so all you need to do is to:
1. First find out whether the inputs (a, b) are date types
2. If they are date types, create Date objects
3. Then, do the compare and return the results
There may be many ways to do this, but I'd probably modify the lines:
if (aToBeCompared < bToBeCompared) ...
to be something like:
if (isDate(a) && isDate(b)) // note you need to define isDate
{
// I HAVE NOT TESTED THIS CODE !!!
// convert a, b to date objects
Date aDate(a);
Date bDate(b);
// compare using date objects comparison operators
if (aDate < bDate)
if (!descending)
return -1;
else
return 1;
else if (aDate > bDate)
if (!descending)
return 1;
else
return -1;
return 0;
}
else
{
if (aToBeCompared < bToBeCompared) ...
no changes here ...
...
...
}
Hope this helps ... the most difficult is probably writing isDate as you need to account for all sorts of date format inputs. It may be sufficient to use Date constructor to see if it's in date format that Javascript recognizes. isDate is a function that determines whether a string input is in date format or not. It returns true if it's a date format, false otherwise. There may already be such function in Javascript
- Han
|
|
|
|
|
Hi
Thanx for the help,
I will let you know if there is
any other problems !
Thanx !
ZDragon
|
|
|
|
|
The latest should handle this ...
- Han
|
|
|
|
|
If you reverse the dates it sorts well. 2002-09-04 (y-m-d) you can also include year only and year circa eg 2001 c.
eg http://home.vicnet.net.au/~cerberus/crew.html#index
John Rogers
www.cerberus.vze.com
|
|
|
|
|
I was able to run the script on IE5, but not on IE6. The table captions do not turn to links onmouseover in IE6.
|
|
|
|
|
Hello ...
I just downloaded the sources and tried it using IE 6.0.2600.0000
on Windows 2000 and it worked for me. I'm not sure why it's not
working for you at the moment ...
I've posted a few different implementations at my homepage ...
so perhaps you can give it another try with the ones posted there.
http://www.geocities.com/sc_hanyu/javascript/sorttable.html
Let me know how it goes.
- Han
|
|
|
|
|
I found this code very cool, useful, and easy to use. Congratulations!
|
|
|
|
|
Thanks for your geneour comments ... Since I wrote this script, I learned so much about how difficult it is to cater to all sorts of different random inputs (different table formats, browser versions etc). I'm still improving the script but I don't think it will end anytime soon ...
- Han
|
|
|
|
|
Thank you very much for the script! It's really the best one on the net...
Also probably the only good one who's also Netscape-compatible.
The new update is really good, it's only a pity that it's a little bit slower, but it remains still very good.
Thank you!;)
WN
|
|
|
|
|
No problem ... I'm also disappointed with the performance when
used with medium to large size tables. I plan to take a closer look at the implementation once I get a chance.
Anyways, thanks for your generous comments!
BTW, you can also find the latest script at my homepage at
http://www.geocities.com/sc_hanyu/javascript/sorttable.html
I pretty much introduce a few features here and there.
- Han
http://www.geocities.com/sc_hanyu/
|
|
|
|
|
Han,
Thanks for posting such a nice piece of work! I wrote a multicolumn list (grid view like) "scriptlet" which augments an HTML table with such things as row selection, methods for getting selected row data, etc. I ran into a problem trying to integrate your sorting code and would like to ask your help.
Problem: I am also storing custom attributes off of the elements of my table. When I am manipulating the DOM for my DHTML work I set attributes (e.g., currentRow.setAttribute("selected", true) ) on the elements. I noticed that the sort does not "move" these attributes. Thus, my hidden data stays in the original ordinal position of the table rows before the sort.
Any ideas on how I could modify the sortTable.js code to also swap any attributes what have been associated with the elements?
Thanks,
Joe Scheer
Russell/Mellon Analytical Services
|
|
|
|
|
Hello Joe
In addition to using insert/deleteCell for all the cells including the title cells, I've added a few more lines of code to retain certain cell properties (i.e. align). The latest script also simulates by centring and bold-facing the title cell contents.
Hope things are working okay for you. If not, let me know.
You can also get 2 other old implementations at my homepage:
http://www.geocities.com/sc_hanyu/
Thanks.
- Han
|
|
|
|
|
I like your implementation here but how can I implement it without incluing your script. I want to have all scripts embedded into my html file. Any ideas how to do that?
|
|
|
|
|
Hi, Darren
If you plan to use DHTML, you will have to use this sort of thing. Of course, if you embed all of the scripts inside your HTML table, you will have much more control over your script (i.e. customize) so that you don't have to worry about having the tables in particular formats. In any case, the latest sources should be fairly flexible so that you won't lose properties of objects except for some for cells/rows as they get deleted and re-inserted.
Anyhow ... try out the latest sources and see how it works. You can simply copy/paste the entire source in your HTML file.
Good luck.
- Han
|
|
|
|
|
Hi,
Nice work! It is really simple to use!!! (i just expect a Netscape compatibility)
But I have found a bug.
If you add a link in one item of the table, the sort is unable to put it at the right place 
Eric.
|
|
|
|
|
Hi, Eric
The code will work with Netscape 6.0 or greater if you use quotes(") around the table ID inside initTable call ... try that and see ... 
Yes, the script is not as smart as I want it to be ... it does require certain conditions in terms of table formats that it can handle. In any case, I'll look into the problem you described.
Thanks for your positive feedback ...
The latest sources at codeproject.com should support Netscape 6.0 or greater.
- Han
|
|
|
|
|
Hi,
I too have the same problem.If i want to sort a table which has first column as link then the link is not placed at proper position
|
|
|
|
|
Hi,
great stuff, very useful for some of my projects and
HTML-based reports!
Unfortunately, the sample doesn't work for me when
using Netscape Navigator 4.x, Mozilla, Opera or IE4.
The only browser where the code actually did
something (other than causing a JavaScript
error message  was IE5. Is this intentional/expected
or am I missing something?
Thanks,
Claus
|
|
|
|
|
Hi, Claus
It wasn't intentional, but the code has only been tested with IE versions 5.0 and greater. I knew that it would not work with Netscape Navigator. Porting something like this to Navigator may require using layers, though I'm not 100% sure.
Anyway, apologies for not being clear about the browser compatibility issues ...
- Han
|
|
|
|
|
I have been looking for something like this for a while, great job.
Thanks.
|
|
|
|
|
Why don't you explain your js code in more detail? Read the great article by Nongjian Zhou to learn some good writing skills!
As a non-web programmer, there is not much I can do except giving up when I double clicked the sample.html file and got the first error message box. Too bad.
|
|
|
|
|
I must confess that the documentation for this javascript is rather skimpy or as the commentor would probably agree NON-existent ... Sorry about that ... Joining many others with lame execuses as far as documentation goes, I also didn't have enough time to write a full-blown article with examples, and implementation details ...
As for the error messages, it's probably due to your browser. This piece of code will not work with Netscape Navigator and it seems that you need to have IE 5.0 or greater to get this working.
I suppose, the least I can do is to display some meaningful error regarding browser compatibility issues ...
- Han
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
