C / C++ / MFC

Rajesh R Subramanian28-Aug-08 19:24

Rajesh R Subramanian

28-Aug-08 19:24

Have you tried passing the file name as "COM3" (no extension, no root directory or absolute path required). That must give you direct access to the port.

Besides that, what is attached at COM3 port? Are you aware that some devices might require you to follow a specific text pattern (usually a series of ASCII keywords) if you want to send it a command? For instance, a printer usually follows the EPSON escape code sequences. I think you need to try specifying the file name as "COM3", as I already said and if it doesn't give you the desired results, you will need to provide more details.

Many are stubborn in pursuit of the path they have chosen, few in pursuit of the goal - Friedrich Nietzsche

.·´¯`·->Rajesh<-·´¯`·.
[Microsoft MVP - Visual C++]

Apr^Ngp28-Aug-08 19:29

Apr^Ngp

28-Aug-08 19:29

i m configuring the COM3 port as follows ...

DCB dcb;
   HANDLE hCom;
   BOOL fSuccess;
   TCHAR *pcCommPort = TEXT("COM3");
   DWORD dwBytesWritten = 0;
   hCom = CreateFile( pcCommPort,
                    GENERIC_READ | GENERIC_WRITE,
                    0,    // must be opened with exclusive-access
                    NULL, // default security attributes
                    OPEN_EXISTING, // must use OPEN_EXISTING
                    0,    // not overlapped I/O
                    NULL  // hTemplate must be NULL for comm devices
                    );

   if (hCom == INVALID_HANDLE_VALUE) 
   {
       // Handle the error.
       printf ("CreateFile failed with error %d.\n", GetLastError());
       return (1);
   }

   // Build on the current configuration, and skip setting the size
   // of the input and output buffers with SetupComm.

  // SecureZeroMemory(&dcb, sizeof(DCB));
   dcb.DCBlength = sizeof(DCB);
   fSuccess = GetCommState(hCom, &dcb);

   if (!fSuccess) 
   {
      // Handle the error.
      printf ("GetCommState failed with error %d.\n", GetLastError());
      return (2);
   }

   // Fill in DCB: 57,600 bps, 8 data bits, no parity, and 1 stop bit.

	dcb.BaudRate = CBR_57600;     // set the baud rate
	dcb.ByteSize = 8;             // data size, xmit, and rcv
	dcb.Parity = NOPARITY;        // no parity bit
    dcb.StopBits = ONESTOPBIT;    // one stop bit

   fSuccess = SetCommState(hCom, &dcb);

   if (!fSuccess) 
   {
      // Handle the error.
      printf ("SetCommState failed with error %d.\n", GetLastError());
      return (3);
   }

   _tprintf (TEXT("Serial port %s successfully reconfigured.\n"),pcCommPort);

Apurv

Apr^Ngp28-Aug-08 19:35

Apr^Ngp

28-Aug-08 19:35

i m configuring the COM3 port as follows ...
and it is getting configured correctly ....

DCB dcb;
   HANDLE hCom;
   BOOL fSuccess;
   TCHAR *pcCommPort = TEXT("COM3");
   DWORD dwBytesWritten = 0;
   hCom = CreateFile( pcCommPort,
                    GENERIC_READ | GENERIC_WRITE,
                    0,    // must be opened with exclusive-access
                    NULL, // default security attributes
                    OPEN_EXISTING, // must use OPEN_EXISTING
                    0,    // not overlapped I/O
                    NULL  // hTemplate must be NULL for comm devices
                    );

   if (hCom == INVALID_HANDLE_VALUE) 
   {
       // Handle the error.
       printf ("CreateFile failed with error %d.\n", GetLastError());
       return (1);
   }

   // Build on the current configuration, and skip setting the size
   // of the input and output buffers with SetupComm.

  // SecureZeroMemory(&dcb, sizeof(DCB));
   dcb.DCBlength = sizeof(DCB);
   fSuccess = GetCommState(hCom, &dcb);

   if (!fSuccess) 
   {
      // Handle the error.
      printf ("GetCommState failed with error %d.\n", GetLastError());
      return (2);
   }

   // Fill in DCB: 57,600 bps, 8 data bits, no parity, and 1 stop bit.

	dcb.BaudRate = CBR_57600;     // set the baud rate
	dcb.ByteSize = 8;             // data size, xmit, and rcv
	dcb.Parity = NOPARITY;        // no parity bit
    dcb.StopBits = ONESTOPBIT;    // one stop bit

   fSuccess = SetCommState(hCom, &dcb);

   if (!fSuccess) 
   {
      // Handle the error.
      printf ("SetCommState failed with error %d.\n", GetLastError());
      return (3);
   }

   _tprintf (TEXT("Serial port %s successfully reconfigured.\n"),pcCommPort);

Apurv

CreateThread Function question

Rajesh R Subramanian28-Aug-08 19:48

Rajesh R Subramanian

28-Aug-08 19:48

Good. Now, you can treat it as a file and write your commands as if you were writing it into a file. You may use WriteFile[^] for instance. Or you have a trouble somewhere else? Smile | :)

Many are stubborn in pursuit of the path they have chosen, few in pursuit of the goal - Friedrich Nietzsche

.·´¯`·->Rajesh<-·´¯`·.
[Microsoft MVP - Visual C++]

monsieur_jj28-Aug-08 16:16

28-Aug-08 16:16

Hi all,

I have this project which is downloading product updates over the internet. What I do first is that before I can go to the second download the first download must be finished. Now I have decided to create a thread so I can download updates simultaneously.

Let me show a bit of the code:

while (m_bIsRunning)
	{
		Sleep(5000);			
			if (isUpdateTime())
			{
			CSiteCode m_CSiteCode;
				RMproduct* MPoint = new RMproduct(L"ManagePoint",ManagepointService, ManagepointVersion);
				if (isPrdInstalled(MPoint))
				{
					GetVersion(MPoint);
					MPoint->m_SiteCode = m_CSiteCode.GetMPSiteCode(MPoint->m_SerialNo.c_str());
					dloadAvailable = DoCheckForProductUpdates(MPoint);
					if(dloadAvailable)
					{
					GetUpdate(MPoint);
					}
				}
				delete MPoint;

				RMproduct* ReRite = new RMproduct(L"ReRite",ReriteService, ReriteVersion);
				if (isPrdInstalled(ReRite))
				{
					GetVersion(ReRite);
					ReRite->m_SiteCode = m_CSiteCode.GetReRiteSiteCode(ReRite->m_SerialNo.c_str());
					dloadAvailable = DoCheckForProductUpdates(ReRite);
					if(dloadAvailable)
					{
					GetUpdate(ReRite);
					}
				}
				delete ReRite;

				RMproduct* ReRiteAsian = new RMproduct(L"ReRite",ReriteAsianService, ReriteAsianVersion);
				if (isPrdInstalled(ReRiteAsian))
				{
					GetVersion(ReRiteAsian);
					ReRiteAsian->m_SiteCode = m_CSiteCode.GetReRiteAsianSiteCode(ReRiteAsian->m_SerialNo.c_str());
					dloadAvailable= DoCheckForProductUpdates(ReRiteAsian);
				if(dloadAvailable)
					{
					GetUpdate(MPoint);
					}
				}
				delete ReRiteAsian;

			}
		
	}

This is service btw. Now the function GetUpdate call a function called downloadfile:

bool CUpdateServiceModule::DownloadFile(RMUpdates* prd)
{
	bool result = false;
	//to do create a thread for each download

	int Data_Of_Thread_1 = 1;            // Data of Thread 1
	HANDLE Handle_Of_Thread_1 = 0;       // variable to hold handle of Thread 1
	HANDLE Array_Of_Thread_Handles[3];   // Aray to store thread handles

	Handle_Of_Thread_1 = CreateThread( NULL, 0, Thread_no_1, ((void*)prd), 0, NULL);  
				if ( Handle_Of_Thread_1 == NULL)  ExitProcess(Data_Of_Thread_1);

	// Store Thread handles in Array of Thread Handles as per the requirement of WaitForMultipleObjects() 
	Array_Of_Thread_Handles[0] = Handle_Of_Thread_1;

	// Wait until all threads have terminated.
	WaitForMultipleObjects( 3, Array_Of_Thread_Handles, TRUE, INFINITE);
	//printf("Since All threads executed lets close their handles \n");
	// Close all thread handles upon completion.
    CloseHandle(Handle_Of_Thread_1);

	//DownloadThread((void*)prd);
	Sleep( 100 );
	return result;
}

This download file is creating a thread that calls the downloadthread global function which downloads the update. The behavior of this downloadthread function is that even the service stops once it is restored it will start the download where it ended:

DWORD  WINAPI Thread_no_1( PVOID PrdPtr ) 
		{
			DownloadThread((void*)PrdPtr);
			return 0; 
		}

void DownloadThread(PVOID PrdPtr)
{
	RMUpdates *ParamPtr;
	ParamPtr = (RMUpdates *) PrdPtr;

	FILE * pFile = NULL;
	
	DWORD dwPacketSize =5;

	PBYTE  pBuffer  = new BYTE[dwPacketSize * 1024];

	double dOffsetToSeek =0;
	
	std::wstring strTmpFileName = ParamPtr->savePath.c_str();
	strTmpFileName.append(L".tmp");

	std::wstring strFileNameAtLocalMachine= ParamPtr->savePath.c_str();

	int res = DeleteFile(strFileNameAtLocalMachine.c_str());
	
	double dCurrentFileSize;

	if(IfLocalFileExist(strTmpFileName.c_str(), &dCurrentFileSize)) 
	{
		dOffsetToSeek = dCurrentFileSize;
	}
	
	CString strRangeQuest;

	if(dCurrentFileSize>0){   
		strRangeQuest.Format( _T("%sRange: bytes=%d-\r\n"), szHeaders,static_cast<ULONGLONG>(dCurrentFileSize));
	}
	else        
		strRangeQuest = szHeaders;

	if (!(pFile = _wfopen (strTmpFileName.c_str(), L"a+b" ) ) )
	{		
		return;
	}
	//CUpdateServiceModule UpdateService;
	try
	{ 	
	CInternetSession Session(_T("UpdateService"));

	CHttpConnection Connection1(Session,ParamPtr->link.c_str());

	BYTE Buffer[4096];

	CHttpFile dFile(Session,ParamPtr->link.c_str());
	CInternetFile::CInfo Info(dFile); //test
	dFile.SendRequest(strRangeQuest);
	DWORD dwRead;	

	for (dwRead = 1 ; dwRead; )	
	{
		dFile.Read(Buffer,sizeof(Buffer),dwRead);
		if (dwRead>0)
			fwrite(Buffer, sizeof (char), dwRead , pFile);		
	}
	fclose (pFile);
	BOOL moved = MoveFile(strTmpFileName.c_str(), strFileNameAtLocalMachine.c_str());	
	
	if(moved)
	{
		EmailUser(strFileNameAtLocalMachine.c_str());
		//UpdateService.WriteLogFile(TRUE, UPDATEMGR, _T(" has downloaded "), ParamPtr->prdName.c_str(), _T(""), _T(""), _T("WillNotBeInErrRptEmail"));
	}
	DeleteFile(strTmpFileName.c_str());
	


	//set status to 1	
	HKEY hkey;
	TCHAR szKey[256];	
	int nValue = 0;


		szKey[0] = _T('\0');							

		_tcscpy(szKey, ServiceRegEntry);
		_tcscat(szKey, UPDATEMGR);
		_tcscat(szKey, ServiceParam);
		_tcscat(szKey, _T("\\"));
		_tcscat(szKey,ParamPtr->prdName.c_str());
		_tcscat(szKey, _T("\\"));
		_tcscat(szKey,ParamPtr->nameVer.c_str());						

		if (RMRegOpenKeyEx(HKEY_LOCAL_MACHINE,szKey,0,KEY_QUERY_VALUE | KEY_SET_VALUE,&hkey) == ERROR_SUCCESS)			
		{	
			nValue = 1; //finished downloading
			RMRegSetValueEx(hkey,UPDATESTAT,0,REG_DWORD,(BYTE*)&nValue,sizeof(nValue));					
			RMRegCloseKey(hkey);
		}
	}
	catch(CInternetException& err)
	{
		err.GetErrorMessage();
		//UpdateService.WriteLogFile(TRUE, UPDATEMGR, _T(" : "), err.GetErrorMessage(), _T(""), _T(""), _T("WillNotBeInErrRptEmail"));
	}
}

Now what I would like to know is that while the first thread is downloading the first update will it go to the next update and download it? Or still my code will just wait for the first thread to download the first update? I am having a hard time debugging this as I dont know how the process splits.

Thanks,
Jayjay

Jijo.Raj28-Aug-08 18:15

Jijo.Raj

28-Aug-08 18:15

monsieur_jj wrote:
HANDLE Array_Of_Thread_Handles[3]; // Aray to store thread handles

Handle_Of_Thread_1 = CreateThread( NULL, 0, Thread_no_1, ((void*)prd), 0, NULL);
if ( Handle_Of_Thread_1 == NULL) ExitProcess(Data_Of_Thread_1);

// Store Thread handles in Array of Thread Handles as per the requirement of WaitForMultipleObjects()
Array_Of_Thread_Handles[0] = Handle_Of_Thread_1;

Here you're creating a uninitialized handle array, and then setting only the first member. The rest handles will contain junk values.

monsieur_jj wrote:
// Wait until all threads have terminated.
WaitForMultipleObjects( 3, Array_Of_Thread_Handles, TRUE, INFINITE);

And here you are waiting for all handles include junk handle values which will finally result in error.

monsieur_jj wrote:
Now what I would like to know is that while the first thread is downloading the first update will it go to the next update and download it?

You've just created a single thread.

Regards,
Jijo.

_____________________________________________________

http://weseetips.com[^] Visual C++ tips and tricks. Updated daily.

monsieur_jj28-Aug-08 20:07

28-Aug-08 20:07

Hi Jijo,

Thanks for the reply
so I have changed it to:

HANDLE Array_Of_Thread_Handles[3]; // Aray to store thread handles
Handle_Of_Thread_1 = CreateThread( NULL, 0, Thread_no_1, ((void*)prd), 0, NULL);
if ( Handle_Of_Thread_1 == NULL) ExitProcess(Data_Of_Thread_1);

// Store Thread handles in Array of Thread Handles as per the requirement of WaitForMultipleObjects()
Array_Of_Thread_Handles[0] = Handle_Of_Thread_1;

// Wait until all threads have terminated.
WaitForMultipleObjects( 1, Array_Of_Thread_Handles, TRUE, INFINITE);

Are you saying it will just finish downloading of that update even if its on a thread and will not go downloading the other updates?

thanks,
Jayjay

Mark Salsbery29-Aug-08 8:59

Mark Salsbery

29-Aug-08 8:59

What other updates? You've only called CreateThread() once.

Mark Salsbery
Microsoft MVP - Visual C++
Java | [Coffee]

monsieur_jj31-Aug-08 16:23

31-Aug-08 16:23

Hi Mark,

Here is the deal

if (isUpdateTime())
{
RMproduct* MPoint = new RMproduct(L"ManagePoint",ManagepointService, ManagepointVersion);
				if (isPrdInstalled(MPoint))
				{
					GetVersion(MPoint);
					MPoint->m_SiteCode = m_CSiteCode.GetMPSiteCode(MPoint->m_SerialNo.c_str());
					dloadAvailable = DoCheckForProductUpdates(MPoint);
					if(dloadAvailable)
					{
					GetUpdate(MPoint);
					}
				}
				delete MPoint;
RMproduct* MPoint2 = new RMproduct(L"ManagePoint",ManagepointService, ManagepointVersion);
				if (isPrdInstalled(MPoint2))
				{
					GetVersion(MPoint2);
					MPoint2->m_SiteCode = m_CSiteCode.GetMPSiteCode(MPoint2->m_SerialNo.c_str());
					dloadAvailable = DoCheckForProductUpdates(MPoint2);
					if(dloadAvailable)
					{
					GetUpdate(MPoint)2;
					}
				}
				delete MPoint;
RMproduct* MPoint3 = new RMproduct(L"ManagePoint",ManagepointService, ManagepointVersion);
				if (isPrdInstalled(MPoint))
				{
					GetVersion(MPoint3);
					MPoint3->m_SiteCode = m_CSiteCode.GetMPSiteCode(MPoint3->m_SerialNo.c_str());
					dloadAvailable = DoCheckForProductUpdates(MPoint3);
					if(dloadAvailable)
					{
					GetUpdate(MPoint3);
					}
				}
				delete MPoint3;
}
<pre>

The GetUpdate function calls the function DownloadFile(): 
<pre>
bool CUpdateServiceModule::DownloadFile(RMUpdates* prd)
{
	bool result = false;


	int Data_Of_Thread_1 = 1;            // Data of Thread 1
	HANDLE Handle_Of_Thread_1 = 0;       // variable to hold handle of Thread 1
	HANDLE Array_Of_Thread_Handles[1];   // Aray to store thread handles

	Handle_Of_Thread_1 = CreateThread( NULL, 0, Thread_no_1, ((void*)prd), 0, NULL);  
				if ( Handle_Of_Thread_1 == NULL)  ExitProcess(Data_Of_Thread_1);


	Array_Of_Thread_Handles[0] = Handle_Of_Thread_1;

	// Wait until all threads have terminated.
	WaitForMultipleObjects( 1, Array_Of_Thread_Handles, TRUE, INFINITE);

    CloseHandle(Handle_Of_Thread_1);

	//DownloadThread((void*)prd);
	Sleep( 100 );
	return result;
}

Thing is MPoint2 and MPoint3 are not sure to exist if they dont the code will only download one update if they exist it may download 2 or 3 updates. But for sure one exists. How must I create a thread in this type of event?

Thanks,
Jayjay

Mark Salsbery1-Sep-08 7:35

Mark Salsbery

1-Sep-08 7:35

Your code as show does nothing multi threaded.
The DownloadFile() method creates a thread, but since it
waits for the thread to complete, it is effectively a complicated
way to do work on ONE thread.

I'm not entirely sure what you are trying to do.

Do you want a separate thread for each download and then
a way to wait for all the threads to complete before the
app proceeds?

Mark Salsbery
Microsoft MVP - Visual C++
Java | [Coffee]

monsieur_jj1-Sep-08 14:17