Click here to Skip to main content
14,768,634 members

Welcome to the Lounge

   

For discussing anything related to a software developer's life but is not for programming questions. Got a programming question?

The Lounge is rated Safe For Work. If you're about to post something inappropriate for a shared office environment, then don't post it. No ads, no abuse, and no programming questions. Trolling, (political, climate, religious or whatever) will result in your account being removed.
 
GeneralRe: Programming Question Pin
_Maxxx_16-Jan-13 17:51
professional_Maxxx_16-Jan-13 17:51 
GeneralRe: Programming Question Pin
AspDotNetDev16-Jan-13 18:03
protectorAspDotNetDev16-Jan-13 18:03 
GeneralRe: Programming Question Pin
_Maxxx_16-Jan-13 18:09
professional_Maxxx_16-Jan-13 18:09 
GeneralRe: Programming Question Pin
Mark_Wallace16-Jan-13 22:00
MemberMark_Wallace16-Jan-13 22:00 
GeneralRe: Programming Question Pin
Nagy Vilmos16-Jan-13 23:15
professionalNagy Vilmos16-Jan-13 23:15 
GeneralRe: Programming Question Pin
M Towler17-Jan-13 23:18
MemberM Towler17-Jan-13 23:18 
GeneralRe: Programming Question Pin
greldak17-Jan-13 23:32
Membergreldak17-Jan-13 23:32 
GeneralRe: Programming Question Pin
M Towler18-Jan-13 1:27
MemberM Towler18-Jan-13 1:27 
I feel that level of commenting or descriptive naming would be breaking encapsulation, by exposing the implementation of GetTaxRate. I will go further and say that it would be repeating some of the documentation of GetTaxRate, so fails DRY. This piece of code is simply doing a calculation, so it calls a function to get the rate. It does not really need to have knowledge of where the rate came from to do its task, so it is best not to give it this knowledge. Having minimal information in this function means it will not become out of date when the implementation of GetTaxRate changes, such as to add a local cache of the value obtained from the service, using a database of rates or some other alteration.

In summary, what I am really saying is that comments of this type raise the cost of maintenance, as each later change will have to find and change multiple comments in addition to the code itself, or else risk misleading future maintainers.
GeneralRe: Programming Question Pin
liordino18-Jan-13 2:29
Memberliordino18-Jan-13 2:29 
GeneralRe: Programming Question Pin
patbob18-Jan-13 6:53
Memberpatbob18-Jan-13 6:53 
GeneralRe: Programming Question Pin
JackDingler18-Jan-13 7:52
MemberJackDingler18-Jan-13 7:52 
GeneralRe: Programming Question Pin
CHill6018-Jan-13 2:28
mveCHill6018-Jan-13 2:28 
GeneralRe: Programming Question Pin
John Atten18-Jan-13 3:32
MemberJohn Atten18-Jan-13 3:32 
GeneralRe: Programming Question Pin
jrscherer18-Jan-13 5:08
Memberjrscherer18-Jan-13 5:08 
GeneralRe: Programming Question Pin
jharano18-Jan-13 5:46
Memberjharano18-Jan-13 5:46 
GeneralRe: Programming Question Pin
Florin Jurcovici18-Jan-13 20:06
MemberFlorin Jurcovici18-Jan-13 20:06 
GeneralRe: Programming Question Pin
Klaus-Werner Konrad24-Jan-13 2:56
MemberKlaus-Werner Konrad24-Jan-13 2:56 
GeneralRe: Programming Question Pin
_Maxxx_24-Jan-13 3:10
professional_Maxxx_24-Jan-13 3:10 
GeneralRe: Programming Question Pin
PIEBALDconsult16-Jan-13 18:09
professionalPIEBALDconsult16-Jan-13 18:09 
GeneralRe: Programming Question Pin
_Maxxx_16-Jan-13 18:20
professional_Maxxx_16-Jan-13 18:20 
GeneralRe: Programming Question Pin
PIEBALDconsult16-Jan-13 18:23
professionalPIEBALDconsult16-Jan-13 18:23 
GeneralRe: Programming Question Pin
TheGreatAndPowerfulOz17-Jan-13 6:12
MemberTheGreatAndPowerfulOz17-Jan-13 6:12 
JokeRe: Programming Question Pin
Harry Neethling17-Jan-13 20:52
professionalHarry Neethling17-Jan-13 20:52 
GeneralRe: Programming Question Pin
Chris Maunder16-Jan-13 18:44
cofounderChris Maunder16-Jan-13 18:44 
GeneralRe: Programming Question Pin
Brisingr Aerowing17-Jan-13 2:28
professionalBrisingr Aerowing17-Jan-13 2:28 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.