Welcome to the Lounge

boarderstu wrote:

if(functionName) //that's a reference, not a call!

charlieg wrote:

"if (bVariable = someothervar)

charlieg wrote:

despise assignments in conditionals and that was a simple example.

den2k88 wrote:

scoped variables ... apart from making the code more difficult to read and to maintain.

den2k88 wrote:

always initialize your variables

den2k88 wrote:

absolutely, positively sure

TheGreatAndPowerfulOz wrote:

I actually find using scoped variables makes code easier to read and maintain. YMMV. And it has fixed and avoided many a bug for me.

TheGreatAndPowerfulOz wrote:

That works until it doesn't. See first rule: initialize!

//code
if (condition){
  int xyz;
  int abc;
  // code
}
// other code

Stryder_1 wrote:

when I am scanning through my code, its easily recognized as a variable I created

LPSTR lpszName  //  lp = long pointer s = string z = zero (null).
// It's a long pointer to a null terminated string, of course.

char* dest, src;

while (objSourceSubFolders.moveNext()) 
{
    // do something with the files in the folder.

    if (objSourceSubFolders.atEnd())
        goto Ended;
}
Ended:

Chris Maunder wrote:

goto Ended;
}
Ended:

raddevus wrote:

while (!sourceSubFolders.atEnd()){
sourceSubFolders.moveNext();
// do something with files in the folder
}

static StringBuilder vsb = new StringBuilder();
internal static string IsValidUrl(string value)
{
    if (value == null)
    {
        return "\"\"";
    }

    vsb.Length= 0;
    vsb.Append("@\"");

    for (int i=0; i<value.Length; i++) 
    {
        if (value[i] == '\"')
            vsb.Append("\"\"");
        else
            vsb.Append(value[i]);
    }

    vsb.Append("\"");
    return vsb.ToString();
}

Baraaaaaa wrote:

I like the first one better.

Baraaaaaa wrote:

Classic! The proposed rewrite skips the first item.