Click here to Skip to main content
14,608,130 members

Welcome to the Lounge

   

For discussing anything related to a software developer's life but is not for programming questions. Got a programming question?

The Lounge is rated Safe For Work. If you're about to post something inappropriate for a shared office environment, then don't post it. No ads, no abuse, and no programming questions. Trolling, (political, climate, religious or whatever) will result in your account being removed.
 
AnswerRe: Multiple returns from methods or clean code flow Pin
OriginalGriff15-Feb-19 6:10
mveOriginalGriff15-Feb-19 6:10 
GeneralRe: Multiple returns from methods or clean code flow Pin
Jörgen Andersson15-Feb-19 6:15
professionalJörgen Andersson15-Feb-19 6:15 
GeneralRe: Multiple returns from methods or clean code flow Pin
megaadam17-Feb-19 22:15
professionalmegaadam17-Feb-19 22:15 
GeneralRe: Multiple returns from methods or clean code flow Pin
OriginalGriff17-Feb-19 22:49
mveOriginalGriff17-Feb-19 22:49 
GeneralRe: Multiple returns from methods or clean code flow Pin
megaadam18-Feb-19 2:29
professionalmegaadam18-Feb-19 2:29 
GeneralRe: Multiple returns from methods or clean code flow Pin
André Pereira18-Feb-19 4:42
MemberAndré Pereira18-Feb-19 4:42 
GeneralRe: Multiple returns from methods or clean code flow Pin
milo-xml18-Feb-19 1:47
professionalmilo-xml18-Feb-19 1:47 
AnswerRe: Multiple returns from methods or clean code flow Pin
lopatir15-Feb-19 6:18
Memberlopatir15-Feb-19 6:18 
sort of depends on what I call the "story"

if the story says "if X is null or is [example] an empty list then stop processing" = in my mind early return.

if the story says "do thus-ad-that to the contents of X" - to save on errors naturally check X for null/empty makes sense - then of course it's if (X != null) ...

Forogar wrote:
ntroduces an execution statement (return) on the same line as the "if" which is bad coding practice

?????????????? bad coding practice ????????????????? huh?
Nothing is wrong, nor bad, nor unsafe with that code, it is perfectly good code.

you confuse practice with style: style is subjective, "bad practice" increases the chance for error or failure.

personally I dislike code that runs too many pages, so I often put short single statements and opening braces on the same line as the if (), while () etc. (Coming from K&R style C background.) and I like ....

AND SO, before you say it, I'll say it for you:
--- you think my style is ugly.
Well guess what:
---- I think your style is ugly.
AND WHO CARES!!

1. it's the code that matters, NOT THE STYLE,
2. different style IS NOT BAD PRACTICE weather you like it or not.

(please don't bring up "readability" bullshit, I find more compact more readable, please don't bring up "industry standard" - my K&R background, and I'm not the only one doing it that way.)

3. you can have the editor re-format [to your preferred] style on one keystroke, so even more WHO CARES.

nuff said.
Message Signature
(Click to edit ->)

GeneralRe: Multiple returns from methods or clean code flow Pin
André Pereira18-Feb-19 4:46
MemberAndré Pereira18-Feb-19 4:46 
GeneralRe: Multiple returns from methods or clean code flow Pin
lopatir19-Feb-19 1:39
Memberlopatir19-Feb-19 1:39 
AnswerRe: Multiple returns from methods or clean code flow Pin
CodeWraith15-Feb-19 7:05
MemberCodeWraith15-Feb-19 7:05 
AnswerRe: Multiple returns from methods or clean code flow Pin
Gerry Schmitz15-Feb-19 7:33
mveGerry Schmitz15-Feb-19 7:33 
AnswerRe: Multiple returns from methods or clean code flow Pin
ZurdoDev15-Feb-19 7:50
mveZurdoDev15-Feb-19 7:50 
GeneralRe: Multiple returns from methods or clean code flow Pin
Gerry Schmitz15-Feb-19 8:08
mveGerry Schmitz15-Feb-19 8:08 
GeneralRe: Multiple returns from methods or clean code flow Pin
ZurdoDev15-Feb-19 8:12
mveZurdoDev15-Feb-19 8:12 
GeneralRe: Multiple returns from methods or clean code flow Pin
CodeWraith15-Feb-19 8:16
MemberCodeWraith15-Feb-19 8:16 
GeneralRe: Multiple returns from methods or clean code flow Pin
ZurdoDev15-Feb-19 8:18
mveZurdoDev15-Feb-19 8:18 
GeneralRe: Multiple returns from methods or clean code flow Pin
CodeWraith15-Feb-19 8:51
MemberCodeWraith15-Feb-19 8:51 
GeneralRe: Multiple returns from methods or clean code flow Pin
ZurdoDev15-Feb-19 9:03
mveZurdoDev15-Feb-19 9:03 
GeneralRe: Multiple returns from methods or clean code flow Pin
CodeWraith15-Feb-19 9:47
MemberCodeWraith15-Feb-19 9:47 
GeneralRe: Multiple returns from methods or clean code flow Pin
Member 798912217-Feb-19 22:02
MemberMember 798912217-Feb-19 22:02 
GeneralRe: Multiple returns from methods or clean code flow Pin
Mark_Wallace15-Feb-19 10:33
MemberMark_Wallace15-Feb-19 10:33 
GeneralRe: Multiple returns from methods or clean code flow Pin
CodeWraith17-Feb-19 22:48
MemberCodeWraith17-Feb-19 22:48 
GeneralRe: Multiple returns from methods or clean code flow Pin
Mark_Wallace18-Feb-19 6:52
MemberMark_Wallace18-Feb-19 6:52 
AnswerRe: Multiple returns from methods or clean code flow Pin
MarkTJohnson15-Feb-19 8:16
professionalMarkTJohnson15-Feb-19 8:16 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.