Click here to Skip to main content
15,065,328 members

Welcome to the Lounge

   

For discussing anything related to a software developer's life but is not for programming questions. Got a programming question?

The Lounge is rated Safe For Work. If you're about to post something inappropriate for a shared office environment, then don't post it. No ads, no abuse, and no programming questions. Trolling, (political, climate, religious or whatever) will result in your account being removed.

 
GeneralRe: I don't like code reviews Pin
Super Lloyd6-Sep-21 21:49
MemberSuper Lloyd6-Sep-21 21:49 
GeneralRe: I don't like code reviews Pin
OriginalGriff6-Sep-21 21:53
mveOriginalGriff6-Sep-21 21:53 
GeneralRe: I don't like code reviews Pin
Eric Lapouge8-Sep-21 2:37
MemberEric Lapouge8-Sep-21 2:37 
GeneralRe: I don't like code reviews Pin
Slacker0076-Sep-21 21:39
professionalSlacker0076-Sep-21 21:39 
GeneralRe: I don't like code reviews Pin
Super Lloyd6-Sep-21 21:52
MemberSuper Lloyd6-Sep-21 21:52 
GeneralRe: I don't like code reviews Pin
Slacker0076-Sep-21 21:49
professionalSlacker0076-Sep-21 21:49 
GeneralRe: I don't like code reviews Pin
Super Lloyd6-Sep-21 22:48
MemberSuper Lloyd6-Sep-21 22:48 
GeneralRe: I don't like code reviews Pin
Sander Rossel6-Sep-21 22:32
professionalSander Rossel6-Sep-21 22:32 
I'm sure your pull request wasn't rejected because your variable name was too short, it was rejected because the name is not descriptive.
Your new name, aNumber, is equally undescriptive so should be rejected again.

Let's say Value returns a wrong value and I had to fix it, I'd see a generic Calculation, an x and some flag.
This tells me absolutely nothing about what the code does or is supposed to do.
Heck, I don't even know what Value is, but perhaps that's clear from the class context (unless you named that C, which wouldn't surprise me now).
All in all, very hard to debug, I can't make assumptions about the code, I'd have to go all the way up or down the stack to know where Value or flag came from or is used, I'd have to read the entire Calculation function to find out what is being calculated... In short, I'd have to read the entire code base just to get a gist of what this little piece of code does and remember it all!

I'm with everyone else on this thread and on your team, apparently, your code is bad and you should feel bad.

GeneralRe: I don't like code reviews Pin
Jörgen Andersson6-Sep-21 22:56
professionalJörgen Andersson6-Sep-21 22:56 
GeneralRe: I don't like code reviews Pin
yacCarsten6-Sep-21 23:20
MemberyacCarsten6-Sep-21 23:20 
GeneralRe: I don't like code reviews Pin
Super Lloyd6-Sep-21 23:32
MemberSuper Lloyd6-Sep-21 23:32 
GeneralRe: I don't like code reviews Pin
BillWoodruff6-Sep-21 23:45
mveBillWoodruff6-Sep-21 23:45 
GeneralRe: I don't like code reviews Pin
Super Lloyd7-Sep-21 1:14
MemberSuper Lloyd7-Sep-21 1:14 
GeneralRe: I don't like code reviews Pin
BillWoodruff7-Sep-21 3:30
mveBillWoodruff7-Sep-21 3:30 
GeneralRe: I don't like code reviews Pin
jsc427-Sep-21 0:31
professionaljsc427-Sep-21 0:31 
GeneralRe: I don't like code reviews Pin
dandy727-Sep-21 2:53
Memberdandy727-Sep-21 2:53 
GeneralRe: I don't like code reviews Pin
obermd7-Sep-21 3:24
Memberobermd7-Sep-21 3:24 
GeneralRe: I don't like code reviews Pin
Slacker0077-Sep-21 3:30
professionalSlacker0077-Sep-21 3:30 
GeneralRe: I don't like code reviews Pin
BillWoodruff7-Sep-21 3:50
mveBillWoodruff7-Sep-21 3:50 
GeneralRe: I don't like code reviews Pin
Slacker0077-Sep-21 4:20
professionalSlacker0077-Sep-21 4:20 
GeneralRe: I don't like code reviews Pin
obermd7-Sep-21 4:37
Memberobermd7-Sep-21 4:37 
GeneralRe: I don't like code reviews Pin
obermd7-Sep-21 4:36
Memberobermd7-Sep-21 4:36 
PraiseRe: I don't like code reviews PinPopular
PIEBALDconsult7-Sep-21 4:06
professionalPIEBALDconsult7-Sep-21 4:06 
GeneralRe: I don't like code reviews Pin
obermd7-Sep-21 4:38
Memberobermd7-Sep-21 4:38 
GeneralRe: I don't like code reviews Pin
kmoorevs7-Sep-21 4:26
Memberkmoorevs7-Sep-21 4:26 

General General    News News    Suggestion Suggestion    Question Question    Bug Bug    Answer Answer    Joke Joke    Praise Praise    Rant Rant    Admin Admin   

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.