C / C++ / MFC

9-May-05 4:23

Hi,

I am having real trouble getting this to work, basically I want to create an array of file names and folder names given a starting point, for example:

Start point:
C:\

Folder list:
Windows
Windows\Config
Windows\System32
Windows\System

File list:
Windows\appversions.dll
Windows\twain_32.dll
Windows\Config\foo.txt
Windows\System32\bootvrfy.exe

What would be the best way to go about this (Without using MFC), I have tried making a recursive method using FindFirstFile and FindNextFile but don't seem to be having any luck.

Thanks in advance!

David Crow9-May-05 4:57

David Crow

9-May-05 4:57

__makaveli__ wrote:
I have tried making a recursive method using FindFirstFile and FindNextFile but don't seem to be having any luck.

Show us the code that is not working.

"Ideas are a dime a dozen. People who put them into action are priceless." - Unknown

__makaveli__9-May-05 5:02

9-May-05 5:02

void SearchFolders(LPCTSTR wStart)
{
WIN32_FIND_DATA hDat;
HANDLE hFindFile;

hFindFile = FindFirstFile(wStart, &hDat);

if( hFindFile != INVALID_HANDLE_VALUE ) {
while( FindNextFile(hFindFile, &hDat) )
{
if( hDat.dwFileAttributes && FILE_ATTRIBUTE_DIRECTORY ) {
// File is a folder
SearchFolders(hDat.cFileName);
} else {
// File is a file
MessageBox(0, hDat.cFileName, "File", MB_OK);
}
}
}
}

I have deleted the code that crashes but this was my last attempt, I tried to make it as simple as possible so I could expand on it once I got it showing a messagebox for each file but I do not get one messagebox.

jmkhael9-May-05 5:49

9-May-05 5:49

Try changing
if( hDat.dwFileAttributes && FILE_ATTRIBUTE_DIRECTORY ) {

to

if( hDat.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY ) {

Papa

while (TRUE)
Papa.WillLove ( Bebe ) ;

__makaveli__9-May-05 5:56

9-May-05 5:56

Thanks for the suggestion but still no messageboxes

jmkhael9-May-05 6:04

9-May-05 6:04

Dont forget the wildcards:

SearchFolders("D:\\test\\*.*");

Papa

while (TRUE)
Papa.WillLove ( Bebe ) ;

__makaveli__9-May-05 6:17

9-May-05 6:17

I have just tried that, I am getting somewhere now, at first I got a stack of messageboxes all saying ".\*", I have now added a check for dots but it's still not recursive.

I'm now using:
void SearchFolders(LPCTSTR wStart)
{
WIN32_FIND_DATA hDat;
HANDLE hFindFile;
char DirSpec[MAX_PATH];

ZeroMemory(DirSpec, MAX_PATH);
strncpy (DirSpec, wStart, strlen(wStart+1));
strncat (DirSpec, "\\*", 3);

hFindFile = FindFirstFile(DirSpec, &hDat);

if( hFindFile != INVALID_HANDLE_VALUE ) {
while( FindNextFile(hFindFile, &hDat) )
{
if( hDat.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY ) {
// File is a folder
if( (strncmp(hDat.cFileName, ".", 1) != 0) || (strncmp(hDat.cFileName, "..", 2) != 0 ) ) {
char subDir[MAX_PATH];
strcat(subDir, hDat.cFileName);
strcat(subDir, "\\*");
SearchFolders(subDir);
}
} else {
// File is a file
MessageBox(0, hDat.cFileName, "File", MB_OK);
}
}
}
}

David Crow9-May-05 6:25

David Crow

9-May-05 6:25

__makaveli__ wrote:
strncat(DirSpec, "\\*", 3);

strncat(DirSpec, "\\*.*", 4);

__makaveli__ wrote:
if( (strncmp(hDat.cFileName, ".", 1) != 0) || (strncmp(hDat.cFileName, "..", 2) != 0 ) ) {
char subDir[MAX_PATH];
strcat(subDir, hDat.cFileName);
strcat(subDir, "\\*");
SearchFolders(subDir);

The second condition is redundant (at least I've not ever seen a folder whose name began with a '.' but whose second character was not a '.'). Also, appending '*' here and at the start of the function is wrong.

if (hDat.cFileName[0] != '.')
{
    char subDir[MAX_PATH];
    strcpy(subDir, wStart);
    strcat(subDir, "\\");
    strcat(subDir, hDat.cFileName);
    SearchFolders(subDir);
}

See here and here for others' interpretation of this exercise. Here is an MFC snippet.

"Ideas are a dime a dozen. People who put them into action are priceless." - Unknown

Bob Stanneveld10-May-05 0:19

Bob Stanneveld

10-May-05 0:19

DavidCrow wrote:
The second condition is redundant (at least I've not ever seen a folder whose name began with a '.' but whose second character was not a '.').

I have. The last time I used the CFile class from MFC, these names came up when I search through some folders...
Also when you use the dir command in dos, you see those names for the current and previous directory!

I also got the blogging virus..[^]

David Crow10-May-05 1:57

David Crow

10-May-05 1:57

Bob Stanneveld wrote:
Also when you use the dir command in dos, you see those names for the current and previous directory!

That's exactly what I said. Unless a folder was named something like ".abc" I do not see the need to check the second character if the first one was a dot. It certainly does not hurt anything to check, but I was just trying to shorten the OP's code down a bit.

"Ideas are a dime a dozen. People who put them into action are priceless." - Unknown

Graham Bradshaw9-May-05 6:23

Graham Bradshaw

9-May-05 6:23

__makaveli__ wrote:
SearchFolders(hDat.cFileName);

You'll need to append the previous directories to this path, and then call SearchFolders, or change your working directory before and after the call. The problem is that FindFirstFile is *always* searching the current directory.

Re: problem in capturing packet

Kelly Herald9-May-05 17:32

Kelly Herald

9-May-05 17:32

Along with what everyone else is stating two more changes to your code.

First, the API FindFirstFile populates hDat you should use a do{}while(); loop instead of a while{} loop.

do
{
...
}while(FindNextFile(hFindFile, &hDat));
FindClose(hFindFile);  // Don't forget to close the find handle

The reason you should process hDat before you call FindNextFile is because if you have a wildcard search like ABC*.* you will lose the first (and possibly the only) match.

Second, as noted in my code snippet, don't forget to close each findfile handle.

Kelly Herald
Software Developer
MPC

jmkhael9-May-05 6:12

Re: problem in capturing packet

9-May-05 6:12

Can you show the main loop

Papa

while (TRUE)
Papa.WillLove ( Bebe ) ;

jmkhael9-May-05 22:15

c++ question. Please help

9-May-05 22:15

Try giving a bigger timeout

and why dont you try pcap_live_dump
Check in the developper pack the sample kdump and pktdump_ex

Papa

while (TRUE)
Papa.WillLove ( Bebe ) ;

WaitForSingleObject

Alex_Y9-May-05 3:41

Alex_Y

9-May-05 3:41

Does it make sence to use WaitForSingleObject for UI thread. What I found if I call
WaitForSingleObject(m_hUIThread, INFINITE) where m_hUIThread is handle to thread object type CWinThread my call will stuck for ever. I check thread status is always waiting for user request. Which means in most of cases GetMessage() in CWinThread resulting this status. I just want to know is this true?

Thanks,

Alex.

Re: WaitForSingleObject

Blake Miller9-May-05 5:02

Blake Miller

9-May-05 5:02

You need to use MsgWaitForSingleObject and if you get a windows message, you need to pump it through the UI thread's message handler. Use the result of MsgWaitForSingleObject call to determine if the action returning is failed, timeout, message, or event was triggered. Some synchronization objects also return abandoned.

Re: WaitForSingleObject

Alex_Y9-May-05 6:59

Alex_Y

9-May-05 6:59

Thanks

Hoornet939-May-05 2:37

Hoornet93

9-May-05 2:37

am remodeling the code in my project.

I had one class (lets say CClass1 ) who was inhereted from let's say CBaseClass.
Now I have to remodel this class into 2 classes CClass3 & CClass2. Both are inherited from CBaseClass (which is a base class for many other classes too)
The problem is in MEMBERS which are now half in CClass3 and half in CClass2. And I need a way for them to comunicate.

So I tried to solve this using STATIC members in new class CBaseClass2 which I derived from CBaseClass and then I derived CClass2 & CClass3 from this class( CBaseClass2 ).

But i have errors:
error LNK2001: unresolved external symbol "public: static int CBaseClass2::sta_member1" (?sta_member1@CClass2@@2HA)

Any ideas to this question. I think this must be known to a lot of people.

Thanks in advance

BlackDice9-May-05 2:52

BlackDice

9-May-05 2:52

If it won't break any already existing code, why not put all the shared variables in CBaseClass? If you're trying to declare them as static in a middle class, did you actually initialize them in the header file below the class definition? If not, that's probably why you got the errors.

My articles

www.stillwaterexpress.com

BlackDice

Hoornet939-May-05 5:15

Hoornet93

9-May-05 5:15

can you please give me an example. 'couse I most defenitly didn't do this.

Love is the law, love under will.

BlackDice9-May-05 5:24

BlackDice

9-May-05 5:24

class MyClass : public CBaseClass
{
//constructors, destructors, etc.
static int m_nCounter;
};

m_nCounter = 0;

My articles

www.stillwaterexpress.com

BlackDice