Re: image processing - C / C++ / MFC Discussion Boards

Steve Messer12-Jun-05 8:41

12-Jun-05 8:41

I have a function that recursively counts the number of files of a given type from the specified path.

It works as desired when used as a regualar function but I am trying to use this function in a worker thread that would return the number of files counted.

I have tried everything that I can think of but the results is always zero.

Here is the struct that I pass as a param to the threadproc

struct THREADSTRUCT
{
    CString filename;
    int count;
} ;

Here is my calling function.

int CPlayer::CountFiles( string path )
{
    _paramCount->filename = path.c_str();
    _paramCount->count = 0;
    AfxBeginThread( Count, _paramCount );
   
    return _paramCount->count; // this is one of many attempts
}

Here is my threadproc

UINT Count( LPVOID pParam ) 
{
	THREADSTRUCT*    ts = (THREADSTRUCT*)pParam;
	assert( !ts->filename.IsEmpty() );
	int count = 0;
 		
	vector< string > files;
	vector< string > dirs;

	string path = ts->filename.GetBuffer();

	string types[] = 
	{
	  ".mp3",".mp2",".mp1",".ogg",".flac",".flc",".mpc",".ape",".ofr",".mpa",".wma"
	};

	int size = dim(types);

	if( *(path.end() - 1) != '\\' && *(path.end() - 1) != '/' )
		path += '\\';
	
	string spec( path + "*.*" );

	_finddata_t fd;
	int handle = (int)_findfirst( spec.c_str(), &fd );
	if( handle == -1 )
	    return 0;
	do
	{
		if( fd.attrib & _A_SUBDIR )
		{
		    if( fd.name != string(".") && fd.name != string("..") )
			dirs.push_back( path + fd.name );
		}
		else
		{
		    if( find_if( types, types+size, is_ext( fd.name ) ) != types+size )
		    {
			files.push_back( path + fd.name );
			count++;
			ts->count++;
			ct++;
			pCPlayer->_paramCount->count++;
			//TRACE( "TS COUNT : %d", ts->count); TRACE("\n");
		    }
		}
	}while( !_findnext( handle, &fd ) );
	_findclose(handle );

	for( size_t i=0; i<dirs.size(); ++i )
	{
	    pCPlayer->_paramCount->filename = dirs[i].c_str(); 
            count += (int)Count( pCPlayer->_paramCount ); 		
	}

	return count;  
}

I have tried global variables and nothing seems to work. What am I missing?

Re: Returning a value from a Worker Thread

DavidR_r12-Jun-05 9:38

DavidR_r

12-Jun-05 9:38

Your problem is that the main thread ends its work before the working thread gets a chance to do anything. it even does not has time for the context switch. You should use events. Check the WaitForSingleObject(), CreateEvent() and SetEvent() functions in MSDN. Generally you should wait for the event in the main thread and send it from the working thread when it's finished.
Good luck

DavidR

Re: Returning a value from a Worker Thread

Steve Messer12-Jun-05 10:29

Steve Messer

12-Jun-05 10:29

What do you mean my main thread is ending before the worker thread does anything?

I am starting the worker thread in OninitDialog() so the main thread is not ending.

Thanks for the direction, I will give those functions a whirl.

Re: Returning a value from a Worker Thread

Tom Archer12-Jun-05 13:44

Tom Archer

12-Jun-05 13:44

The start of the thread is asynchronous. IOW, you specify to start the thread and pass a fcn pointer and the call returns immediately. In the background the thread is started. Therefore, you have to decide how you want your thread to communicate back to the caller. David was referring to using events as the thread synchronization mechanism. You can find many samples and articles on doing that. Here's one I quickly grabbed from google: http://www.codersource.net/win32_waitforsingleobject.html[^] I'm sure there are several on this site as well.

If you're starting the thread from the dialog's init function, you obviously don't want to hold up that function from completing. There are several ways around this. One very easy way would be to start a timer in the dialog's OnInitDialog function where the timer function could then start the thread as per David's (and the article's) instruction.

Re: Returning a value from a Worker Thread

Steve Messer12-Jun-05 16:38

Steve Messer

12-Jun-05 16:38

Okay so answer a dumb question. Obviously I don't understand so bare with me.

How will setting things up like you say effect wheither or not my function returns a value.

Thanks.

Re: Returning a value from a Worker Thread

Tom Archer12-Jun-05 18:20

Tom Archer

12-Jun-05 18:20

There are a couple of ways to do this:

For example...

* You could have a class (CMyWorkerThread)
* CMyWorkerThread could also have a static member function that acts as the thread function (CMyWorkerThread::DoWork)
* Your client code constructs a CMyWorkerThread object and creates a thread passing the CMyWorkerThread member function pointer
* Your client code then blocks on an event that signifies that the thread has finished (e.g., by calling WaitForSingleObject)
* CMyWorkerThread::DoWork processes the work and when done it sets a member variable that represents the return value.
* CMyWorkerThread::DoWork then clears the event
* Once the CMyWorkerThread::DoWork sets the event, the client's call to WaitForSingleObject completes and the client can then access the CMyWorkerThread object's return value member variable

Another way...

* You could have a class (CMyWorkerThread)
* CMyWorkerThread has a constructor that takes a callback function that is stored as a member variable
* CMyWorkerThread has a static member function that acts as the thread function (CMyWorkerThread::DoWork)
* Your client code constructs a CMyWorkerThread object (passing the callback) and creates a thread passing the CMyWorkerThread member function pointer
* CMyWorkerThread::DoWork processes the work and when done it calls the callback function to notify the client that the work is completed and the return code

image processing

prabhathgk12-Jun-05 7:51

prabhathgk

12-Jun-05 7:51

how can split an image into 8x8 blocks and calculate the mean,varients.. dct,fft etc.

prabhathgk

Re: image processing

DavidR_r12-Jun-05 9:41

DavidR_r

12-Jun-05 9:41

There is Intel mathematical library IPP which implements various functions of Image pprocessing. Check it out on the Intel web site

DavidR

Delta time in mSec

Ravi Bhavnani12-Jun-05 6:48

Ravi Bhavnani

12-Jun-05 6:48

I need to calculate the (approx) elapsed time between 2 function calls in mSec. MS recommends getting the times in SYSTEMTIMEs, converting them to FILETIMEs, copying them to ULARGE_INTEGERs and computing their difference. All this seems to work fine. But the MS docs don't indicate the resolution of the difference between the two ULARGE_INTEGERs. Frown | :(

In an experiment, the time taken to execute AfxSocketInit() (i.e. the difference of the low part DWORDs) was 10000. As one would expect, introducing artificial delays caused the delta to increase. But what units am I measuring?

Thanks for any insight.

/ravi

My new year's resolution: 2048 x 1536
Home | Articles | Freeware | Music
ravib@ravib.com

Solved!

Ravi Bhavnani12-Jun-05 7:34

Ravi Bhavnani

12-Jun-05 7:34

struct _timeb tmStart, tmEnd;
_ftime (&tmStart);
foo();
_ftime (&tmEnd);
int nDeltaMSec = (tmEnd.time - tmStart.time)*1000 +
                 (tmEnd.millitm - tmStart.millitm);

/ravi

My new year's resolution: 2048 x 1536
Home | Articles | Freeware | Music
ravib@ravib.com

Are function calls that costly? Need help optimizing

Budric B.12-Jun-05 6:32

Budric B.

12-Jun-05 6:32

Hi,
I'm writing some simple image processing functions such as gaussian blur etc. I have an image class to represent the data. I then used the following to benchmark how fast it runs:

<br />
	start = clock();<br />
	<br />
	for (int k = 0; k < 100; k++)<br />
	{<br />
//code<br />
	}<br />
<br />
<br />
	finish = clock();<br />
	double duration = (double)(finish - start) / CLOCKS_PER_SEC / 100;<br />

I find that my GetPixel() function is the cause of very slow performance. For example here's the code that I can benchmark:

<br />
	for (int i = 0; i < test.m_nHeight; i++)<br />
		{<br />
			for (int j = 0; j < test.m_nWidth; j++)<br />
			{<br />
				int value = test.m_pData[i*test.m_nHeight + j];  <br />
				//int value = test.GetPixel(i, j);<br />
			}<br />
		}<br />

If I access the value directly from the pointer I get duration = 0.0013 s. The other commented line of code gives me 0.012. That's 10 times slower!

I was hoping to wrap everything up nicely in a class, but it looks like that's not going to happen. Is it something I"m doing wrong, or just the way things are for function calls.

Also are there any suggestions you have on code optimization? Any articles? I would not like to start writing messy C code all wrapped up in one function for speed.

Thanks

Re: Are function calls that costly? Need help optimizing

liquid_12-Jun-05 7:35

liquid_

12-Jun-05 7:35

Try to use inline function.
Also, check the compiler options, eg. stack checking, optimizations...
Do you build the release or debug version?
The other way is to set on assembly listing in compiler options and compare different solutions of coding.
Indeed, calling a function brings some overhead into your code. You can verify this examining mixed source and assembly listing, if compiler allows this (VC6 does allow). Generally, optimization can be a big problem and there is no perfect and only solution.

Re: Are function calls that costly? Need help optimizing

Budric B.12-Jun-05 7:52

Budric B.

12-Jun-05 7:52

Yes, I tried to use inline, that didn't help. The test was done in release mode.

Re: Are function calls that costly? Need help optimizing

squidev12-Jun-05 7:44

squidev

12-Jun-05 7:44

If you can step through your code, you could pin-point the costy call with the use of the @clk pseudo-register.

In your watch window, add

<br />
@clk<br />
@clk=0<br />

When you step, the value for @clk will give you how long it took.

Hope this helps Smile | :)

Re: Are function calls that costly? Need help optimizing

Tom Archer12-Jun-05 13:50

Tom Archer

12-Jun-05 13:50

Budric B. wrote:
Any articles?

CodeProject article on pseudoregisters (including @clk)[^]

Re: Are function calls that costly? Need help optimizing

PJ Arends12-Jun-05 17:35

PJ Arends

12-Jun-05 17:35

You say your GetPixel() function. What are you doing in that function? The windows GetPixel() function is very slow to begin with, so if you are calling that one then it is no wonder your function is slow. That is why DIBSections were invented, so that one could access the pixels directly as you have done instead of relying on GetPixel(). Check out the Bitmaps section here on CP for some excellent DIBSection articles.

Re: Are function calls that costly? Need help optimizing

Budric B.13-Jun-05 4:09

Budric B.

13-Jun-05 4:09

My GetPixel() function is the same as the code I posted. It just dereferences the pointer. On top of that it checks if the indices are within limits and if not it returns a 0.

I rewrote my gaussian blur algorithm to use the memory directly, without GetPixel() and now my results are 10 times faster.

BTW. Thanks for the @clk tip.

Capturing Sound

Identity Undisclosed12-Jun-05 6:18

Identity Undisclosed

12-Jun-05 6:18

I want to capture sound what is coming on my speaker ... not through microphone .... just the way i capture screen shot and save to disk .... is there a way to record the sound which are being played in window ... like for instance, i am listening a sound and another application is recording ... to be exact and specific that application records every sound that is played which that application is running ...
Any idea or suggestion
Any sort of help is highly appreciated

Regards,
Ibraheem Khan

How to remove the close button correctly in a rebar control?

Dani10000112-Jun-05 5:08

Dani100001

12-Jun-05 5:08

Hi,this has been bugging me along time now and I haven´t been able to solve it yet.

I want to be able to remove a close button from an application so i can move another band to the space that was previously taken up by the close button.

I have done this successfully with a commandbar using this code:

HWND hwndCB;  // Handle to the commandbar window<br />
TBBUTTON tbbutton;<br />
<br />
for(int i=0;i<10;i++){<br />
	    SendMessage(hwndCB, TB_GETBUTTON, (WPARAM)i, (LPARAM)&tbbutton);<br />
	    if(tbbutton.idCommand==WM_CLOSE)<br />
			break;<br />
}<br />
<br />
SendMessage(hwndCB,TB_DELETEBUTTON, (WPARAM)i, (LPARAM)0 );

But unfortunately this didn´t work with the rebar control, it only removed the close button, and did not freed any space that the close button took up.

You add a close button to a rebar control using addadornments:

CommandBands_AddAdornments (hwndCB, hInst, 0, NULL);

But how in the heck do you do if you wan´t to remove it then?

There are no RemoveAdornments function and no info on this issue....

If i had the code I would have to recreate the rebar and not add any addornments to get rid of the close button.

But as i said before I don´t have the code.....

Does anyone have any idea how to solve this?

Please help, I´m going crazy...

Thanks for helping me out, Dani

Win32: IsDialog(HWND)?

peterchen11-Jun-05 23:33

peterchen

11-Jun-05 23:33

Dialogs and Windows seem to be handled very different in Win32. Is there a way to check if a HWND is a Dialog (using DWL_DLGPROC), or a Window (using GWL_WNDPROC) ?

Pandoras Gift #44: Hope. The one that keeps you on suffering.
aber.. "Wie gesagt, der Scheiss is' Therapie"
boost your code || Fold With Us! || sighist | doxygen

Re: Win32: IsDialog(HWND)?

Jack Puppy12-Jun-05 0:16

Jack Puppy

12-Jun-05 0:16

I found this in one of my old libraries. Can't say that it's foolproof though as I don't remember using it much. (I made a function for each system class, but primarily only used AfxIsEdit, AfxIsComboBox)

BOOL AfxIsDialogBox(HWND hWnd)
{
	return (AfxIsSystemClass(hWnd, _T("#32770")));
}

BOOL AfxIsSystemClass(HWND hWnd, LPCTSTR lpszSystemClassName)
{
	// Bad window?
	ASSERT(::IsWindow(hWnd));
	if (!::IsWindow(hWnd))
		return FALSE;

	// Bad class name?
	ASSERT(AfxIsValidString(lpszSystemClassName));
	if (!AfxIsValidString(lpszSystemClassName))
		return FALSE;

	// Get the classname for the window and compare to the system class name
	TCHAR szClassName[100];
	return (::GetClassName(hWnd, szClassName, 100) && _tcsicmp(szClassName, lpszSystemClassName) == 0);
}

Pssst. You see that little light on your monitor? That's actually a government installed spy camera. Smile and wave to big brother!

Re: Win32: IsDialog(HWND)?

Jörgen Sigvardsson12-Jun-05 2:57

Jörgen Sigvardsson

12-Jun-05 2:57

Jack Squirrel wrote:
return (AfxIsSystemClass(hWnd, _T("#32770")));

That may not always work, as you can superclass dialogs. Frown | :(

--
An eye for an eye will only make the world blind.

Re: Win32: IsDialog(HWND)?

peterchen12-Jun-05 3:49

peterchen

12-Jun-05 3:49

How?
(Couldn't find anything in thew Dialog Box API)

Pandoras Gift #44: Hope. The one that keeps you on suffering.
aber.. "Wie gesagt, der Scheiss is' Therapie"
boost your code || Fold With Us! || sighist | doxygen

Re: Win32: IsDialog(HWND)?

Jörgen Sigvardsson12-Jun-05 5:21

Jörgen Sigvardsson

12-Jun-05 5:21

How to subclass, or how to detect subclassed dialogs? The answer to the first one is in the ATL library. I stumbled upon it one day as I was making my own dialog windows. The answer for the second question is: I don't know. Dialogs are tricky, that's for sure.

--
An eye for an eye will only make the world blind.

Re: Win32: IsDialog(HWND)?

Jack Puppy12-Jun-05 4:22

Jack Puppy

12-Jun-05 4:22

Jörgen Sigvardsson wrote:
That may not always work, as you can superclass dialogs.

I got an idea about using one of the dlg based functions on a non-dlg window and eventually found this system error:

ERROR_WINDOW_NOT_DIALOG - The window is not a valid dialog window

The problem is, the only dialog function I can find that returns the value is EndDialog.

if (!EndDialog(hWnd, 0))
{
if (GetLastError() == ERROR_WINDOW_NOT_DIALOG)
// it's not a dialog!
}
else
// it's a dialog! Hey, where'd it go?

Pssst. You see that little light on your monitor? That's actually a government installed spy camera. Smile and wave to big brother!

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.