C / C++ / MFC

15-Jun-06 22:18

Can i use the insert query in d foll way with a variable..where
char* url="asdf";
How else do i insert value into MS Access DB which is contained in a variable?

_Commandptr m_pCommand;
m_pCommand.CreateInstance(__uuidof(Command));
m_pCommand->CommandText = "INSERT INTO wcs(URL,Object_size,No_of_accesses,Transfer_cost,Group_no,Hvalue,Location)
VALUES(url,7,6,8,'hi')";

m_pCommand->CommandType=adCmdText;
m_pCommand->ActiveConnection = m_pConnection;
_variant_t vRecords;
m_pCommand->Execute(&vRecords,NULL,adCmdText);

Cedric Moonen15-Jun-06 22:31

15-Jun-06 22:31

Basically, that's just string manipulation routine. I don't know the type of _Commandptr::CommandText but take a look at sprintf (for a char string). If it is a std::string, then you can simply use a concatenation (+ symbole) to concatenate several strings.

Cédric Moonen
Software developer

Charting control

shuchigo_jane15-Jun-06 22:40

15-Jun-06 22:40

Cedric Moonen wrote:
If it is a std::string, then you can simply use a concatenation (+ symbole) to concatenate several strings.

concatenate?????i want to insert d value from url into access DB..so wher does concatenate come in2 d picture??
url is a user variable!

Cedric Moonen15-Jun-06 22:49

15-Jun-06 22:49

Yes, concatenate. You have to make a difference between the DB instruction (or whatever you call it) and how it is represented. In your case, what you are doing is executing a SQL (I think) commands that is contained in a string. But the way you 'construct' the string can be done in whatever way you want.

Let's take a simple example: suppose you want to select something from a database (very simple example). The 'thing' you want to select is contained in a variable:

std::string ThingToSelect = "Name";

So, in fact, you want to execute a command that looks like: "SELECT Name from table" and your "Name" is in fact contained in a variable.

So, just construct your string this way:

std::string Command = "SELECT" + ThingToSelect + "from table";

And you get exactly the same.

See, it is simply string manipulation and has nothing to do with your database.

Cédric Moonen
Software developer

Charting control

shuchigo_jane15-Jun-06 22:56

15-Jun-06 22:56

U mean lik this...rt?
But dis dint work either...some prob here?or any related glitch?

CString newurl=url;
CString string="INSERT INTO wcs(URL,Object_size,No_of_accesses,Transfer_cost,Group_no,Hvalue,Location)
VALUES("+newurl+",7,6,8,'hi')";
m_pCommand->CommandText = (_bstr_t)string;

Cedric Moonen15-Jun-06 22:59

15-Jun-06 22:59

shuchigo_jane wrote:
But dis dint work either

Be more specific. What do you mean by 'don't work' ?

Also, use your debugger to see if the string is correctly written.

shuchigo_jane wrote:
m_pCommand->CommandText = (_bstr_t)string;

Also for that, I don't think the cast to a (_bstr_t)string will work. What is the type of CommandText ?

Cédric Moonen
Software developer

Charting control

shuchigo_jane15-Jun-06 23:10

15-Jun-06 23:10

dint work=throws an exception...

Cedric Moonen wrote:
What is the type of CommandText ?

From msdn!!!...Sets or returns a String value containing a provider command, such as an SQL statement, a table name, or a stored procedure call. Default is "" (zero-length string).

Also if not cast,it gives a casting error.

Cedric Moonen15-Jun-06 23:14

15-Jun-06 23:14

And, did you check with your debugger to see if the string is properly 'spelled' before calling execute ? If you made spelled incorrectly, I cannot help you. One thing you have to try: just for a test, execute the same string but hard-code it (so, write it completely yourself with the url and everything). If you get an exception, then it means that the string is not properly spelled.

Cédric Moonen
Software developer

Charting control

shuchigo_jane15-Jun-06 23:17

15-Jun-06 23:17

worked jus fine with a hard coded string...
prob arose only wen we wanted to insert a value from a variable..

Cedric Moonen15-Jun-06 23:19

15-Jun-06 23:19

Geez, third time I ask you to use your debugger ! Check the format of your string if it matches exactly the same format that your hard-coded string.

Cédric Moonen
Software developer

Charting control

David Crow16-Jun-06 3:03

David Crow

16-Jun-06 3:03

Try:

string.Format("INSERT INTO(URL,Object_size,No_of_accesses,Transfer_cost,Group_no,Hvalue,Location) VALUES(\"%s\",7,6,8,\"hi\")", url);
// check the value of <code>string</code> at this point
m_pCommand->CommandText = string;

"The largest fire starts but with the smallest spark." - David Crow

"Judge not by the eye but by the heart." - Native American Proverb

Viorel.15-Jun-06 22:58

Viorel.

15-Jun-06 22:58

I think you have to investigate the CreateParameter and Parameters members of Command object.

I suppose you have to use "@url" in the command text, and then use something like this:

_ParameterPtr param = m_pCommand->CreateParameter("url", adVarChar, adParamInput, url.length(), url.c_str());
m_pCommand-> Parameters->Append(param);

This is just my guess.

Milton Karimbekallil15-Jun-06 23:56

Milton Karimbekallil

15-Jun-06 23:56

Below given is the fixed code. Copy this and try.

<br />
CString url="asdf";<br />
_Commandptr m_pCommand;<br />
m_pCommand.CreateInstance(__uuidof(Command));<br />
<br />
CString strSql = _T("INSERT INTO wcs(URL,Object_size,No_of_accesses,Transfer_cost,Group_no,Hvalue,Location) VALUES('") + url + _T("',7,6,8,'hi')");<br />
<br />
m_pCommand->CommandText = _bastr_t(strSql);<br />
<br />
m_pCommand->CommandType=adCmdText;<br />
m_pCommand->ActiveConnection = m_pConnection;<br />
_variant_t vRecords;<br />
m_pCommand->Execute(&vRecords,NULL,adCmdText);

cheers...milton kb

shuchigo_jane16-Jun-06 0:02

16-Jun-06 0:02

cheeeeeeeeeerrrrrrrrrssss.....thanx a bunch...it worked... Smile | :)