ASP.NET

25-Jul-07 17:41

Is any able to reduce this code to a minimal try~~!!!

<br />
Protected Sub Page_Load(ByVal sender As Object, ByVal e As System.EventArgs) Handles Me.Load<br />
If Not IsPostBack Then<br />
Dim conn1 As New Data.SqlClient.SqlConnection("datasource=.\SQLEXPRESS;initial catalog=C:\DOCUMENTS AND SETTINGS\PROJ\APP_DATA\DATABASE.MDF;integrated security = true")<br />
<br />
            Dim sql1 As New Data.SqlClient.SqlCommand("select status from carpark where Lot_id=101", conn1)<br />
            Dim sql2 As New Data.SqlClient.SqlCommand("select status from carpark where  Lot_id=102", conn1)<br />
            Dim sql3 As New Data.SqlClient.SqlCommand("select status from carpark where Lot_id=103", conn1)<br />
            Dim sql4 As New Data.SqlClient.SqlCommand("select status from carpark where  Lot_id=104", conn1)<br />
            Dim sql5 As New Data.SqlClient.SqlCommand("select status from carpark where Lot_id=201", conn1)<br />
            Dim sql6 As New Data.SqlClient.SqlCommand("select status from carpark where  Lot_id=202", conn1)<br />
            Dim sql7 As New Data.SqlClient.SqlCommand("select status from carpark where Lot_id=203", conn1)<br />
            Dim sql8 As New Data.SqlClient.SqlCommand("select status from carpark where  Lot_id=204", conn1)<br />
            Dim sql9 As New Data.SqlClient.SqlCommand("select status from carpark where Lot_id=301", conn1)<br />
            Dim sql10 As New Data.SqlClient.SqlCommand("select status from carpark where  Lot_id=302", conn1)<br />
            Dim sql11 As New Data.SqlClient.SqlCommand("select status from carpark where Lot_id=303", conn1)<br />
            Dim sql12 As New Data.SqlClient.SqlCommand("select status from carpark where  Lot_id=304", conn1)<br />
            <br />
            Dim haha1 As String<br />
            Dim haha2 As String<br />
            Dim haha3 As String<br />
            Dim haha4 As String<br />
            Dim haha5 As String<br />
            Dim haha6 As String<br />
            Dim haha7 As String<br />
            Dim haha8 As String<br />
            Dim haha9 As String<br />
            Dim haha10 As String<br />
            Dim haha11 As String<br />
            Dim haha12 As String<br />
<br />
            conn1.Open()<br />
<br />
            haha1 = CStr(sql1.ExecuteScalar)<br />
            haha2 = CStr(sql2.ExecuteScalar)<br />
            haha3 = CStr(sql3.ExecuteScalar)<br />
            haha4 = CStr(sql4.ExecuteScalar)<br />
            haha5 = CStr(sql5.ExecuteScalar)<br />
            haha6 = CStr(sql6.ExecuteScalar)<br />
            haha7 = CStr(sql7.ExecuteScalar)<br />
            haha8 = CStr(sql8.ExecuteScalar)<br />
            haha9 = CStr(sql9.ExecuteScalar)<br />
            haha10 = CStr(sql10.ExecuteScalar)<br />
            haha11 = CStr(sql11.ExecuteScalar)<br />
            haha12 = CStr(sql12.ExecuteScalar)<br />
            If haha1 = "occupied" Then<br />
                Label2.BackColor = Drawing.Color.Green<br />
                Label1.Text = "101 is available"<br />
            Else<br />
                Label2.BackColor = Drawing.Color.Red<br />
                Label1.Text = "101 is not available"<br />
            End If<br />
<br />
            If haha2 = "occupied" Then<br />
                Label4.BackColor = Drawing.Color.Green<br />
                Label3.Text = "102 is available"<br />
            Else<br />
                Label4.BackColor = Drawing.Color.Red<br />
                Label3.Text = "102 is not available"<br />
            End If<br />
            <br />
            If haha3 = "occupied" Then<br />
                Label6.BackColor = Drawing.Color.Green<br />
                Label5.Text = "103 is available"<br />
            Else<br />
                Label6.BackColor = Drawing.Color.Red<br />
                Label5.Text = "103 is not available"<br />
            End If<br />
            <br />
            If haha4 = "occupied" Then<br />
                Label8.BackColor = Drawing.Color.Green<br />
                Label7.Text = "104 is available"<br />
            Else<br />
                Label8.BackColor = Drawing.Color.Red<br />
                Label7.Text = "104 is not available"<br />
            End If<br />
            <br />
            If haha5 = "occupied" Then<br />
                Label10.BackColor = Drawing.Color.Green<br />
                Label9.Text = "201` is available"<br />
            Else<br />
                Label10.BackColor = Drawing.Color.Red<br />
                Label9.Text = "201 is not available"<br />
            End If<br />
            <br />
            If haha6 = "occupied" Then<br />
                Label12.BackColor = Drawing.Color.Green<br />
                Label11.Text = "202 is available"<br />
            Else<br />
                Label12.BackColor = Drawing.Color.Red<br />
                Label11.Text = "202 is not available"<br />
            End If<br />
            <br />
            If haha7 = "occupied" Then<br />
                Label14.BackColor = Drawing.Color.Green<br />
                Label13.Text = "203 is available"<br />
            Else<br />
                Label14.BackColor = Drawing.Color.Red<br />
                Label13.Text = "203 is not available"<br />
            End If<br />
            <br />
            If haha8 = "occupied" Then<br />
                Label16.BackColor = Drawing.Color.Green<br />
                Label15.Text = "204 is available"<br />
            Else<br />
                Label16.BackColor = Drawing.Color.Red<br />
                Label15.Text = "204 is not available"<br />
            End If<br />
            <br />
            If haha9 = "occupied" Then<br />
                Label18.BackColor = Drawing.Color.Green<br />
                Label17.Text = "301 is available"<br />
            Else<br />
                Label18.BackColor = Drawing.Color.Red<br />
                Label17.Text = "301 is not available"<br />
            End If<br />
            <br />
            If haha10 = "occupied" Then<br />
                Label20.BackColor = Drawing.Color.Green<br />
                Label19.Text = "302 is available"<br />
            Else<br />
                Label20.BackColor = Drawing.Color.Red<br />
                Label19.Text = "302 is not available"<br />
            End If<br />
            <br />
            If haha11 = "occupied" Then<br />
                Label22.BackColor = Drawing.Color.Green<br />
                Label21.Text = "303 is available"<br />
            Else<br />
                Label22.BackColor = Drawing.Color.Red<br />
                Label21.Text = "303 is not available"<br />
            End If<br />
            <br />
            If haha12 = "occupied" Then<br />
                Label24.BackColor = Drawing.Color.Green<br />
                Label23.Text = "304 is available"<br />
            Else<br />
                Label24.BackColor = Drawing.Color.Red<br />
                Label23.Text = "304 is not available"<br />
            End If<br />
            conn1.Close()<br />
        End If<br />
    End Sub<br />

Imran Khan Pathan25-Jul-07 18:39

Imran Khan Pathan

25-Jul-07 18:39

Is your Lot_id fixed?

Best regard

Pathan

GOD HELP THOSE WHO HELP THEMSELVES

duo!@#26-Jul-07 15:18

26-Jul-07 15:18

Wht do u mean by fixed??

The Lot_id is taken from the database
From 101 to 304

101 to 104
then
201 to 204
then
301 to 304

the first digit is the Level followed by the lot id
but in the database its placed as 101
thus each level has 4 lots.

Christian Graus25-Jul-07 18:50

Christian Graus

25-Jul-07 18:50

This code is obviously a nightmare. First of all, try giving your variables real names, not label1, label2, etc.

Then, it seems that you could use the tag property on the label controls to associate labels with a specific Lot_id, then much of this could be done using a loop.

You could actually make one SQL call which returns all statuses, along with the lot ids, and then iterate through the datatable from there.

Christian Graus - Microsoft MVP - C++

"I am working on a project that will convert a FORTRAN code to corresponding C++ code.I am not aware of FORTRAN syntax" ( spotted in the C++/CLI forum )

Brady Kelly25-Jul-07 23:23

25-Jul-07 23:23

Christian Graus wrote:
If haha2 = "occupied" Then
Label4.BackColor = Drawing.Color.Green
Label3.Text = "102 is availabl

It also seems wrong. If the variable IS occupied, the associated room is set to available.

 If haha2 = "occupied" Then
Label4.BackColor = Drawing.Color.Green
Label3.Text = "102 is availabl

duo!@#26-Jul-07 15:22

26-Jul-07 15:22

Oh ya i just noticed it actually its surpose to be

if haha2="occupied" then

label4.backColor=Drawing.Color.Red
label3.Text="102 is not available"
else
label4.backColor=Drawing.Color.Green
label3.Text="102 id available"
end if

do u know how i can reduce this big mess of if else loops

Brady Kelly26-Jul-07 20:23

26-Jul-07 20:23

Using labels here is your biggest problem. Is this your code, i.e. can you change the design to not use labels?

duo!@#26-Jul-07 20:45

26-Jul-07 20:45

well the labels are to change colors so that the user will know which lots are occupied and not occupied

if there is another way to display this i'm open for suggestion

duo!@#26-Jul-07 15:25

26-Jul-07 15:25

i think u have somthing there that can help me but i dun get it perhaps

u could type out a sample code

thanks.

Sonia Gupta25-Jul-07 18:50

Sonia Gupta

25-Jul-07 18:50

use the ; to seperate the sql queries in sqlcommand class.
Thus u don't need to specify each and every query in seperate variable.

Sonia Gupta
Soniagupta1@yahoo.co.in
Yahoo messengerId-soniagupta1
Love is Friendship and Friendship is Love....

Brady Kelly27-Jul-07 3:56

27-Jul-07 3:56

1. Rename your label controls to reflect the lot they represent.¹ So, instead of Label1, Label2, you have Label101Text, Label101Colour.
2. Group all selects into one query.

Dim sqlLotStatus As New Data.SqlClient.SqlCommand("select Lot_id, status from carpark where Lot_id between 101 and 304", conn1)

3. Loop through the result set and set properties on the appropriate labels:

Dim sqlDataReader As Data.SqlClient.SqlDataReader = sqlLotStatus.EndExecuteReader()

Dim lotStatus As String
Dim textLabelName As String
Dim colourLabelName As String
Dim textLabelCtrl As Label
Dim colourLabelCtrl As Label

While sqlDataReader.Read()
    ' Derive label names.
    textLabelName = "Label" & sqlDataReader("Lot_id").ToString() & "Text"
    colourLabelName = "Label" & sqlDataReader("Lot_id").ToString() & "Colour"

    ' Get Label controls with derived names.
    textLabelCtrl = CType(Me.FindControl(textLabelName), Label)
    colourLabelCtrl = CType(Me.FindControl(colourLabelName), Label)

    ' Set control properties for lot.
    lotStatus = sqlDataReader("status").ToString()
    If lotStatus = "occupied" Then
        textLabelCtrl.Text = sqlDataReader("Lot_id").ToString() & " is not available"
        colourLabelCtrl.BackColor = Drawing.Color.Red
    Else
        textLabelCtrl.Text = sqlDataReader("Lot_id").ToString() & " is available"
        colourLabelCtrl.BackColor = Drawing.Color.Green
    End If
End While

1. The ASP.NET Label control lacks the convenient Tag property of the WinForms control.

duo!@#29-Jul-07 16:04

29-Jul-07 16:04

You have to be a code guru. When i saw your code OMG i was amazed i'm still a beginner in using visual basic but its a great language.Thanks alot !!;)

Brady Kelly29-Jul-07 21:43