C / C++ / MFC

31-Aug-07 4:07

#include <iostream>
using namespace std;
int oo(int m);
int sum=0;
void main()
{
int m;
cin>>m;

oo(m);
abc:
cout<

Maximilien31-Aug-07 4:10

Maximilien

31-Aug-07 4:10

oo or OO ?

Maximilien Lincourt
Your Head A Splode - Strong Bad

Russell^'31-Aug-07 4:11

31-Aug-07 4:11

Russell

youbo31-Aug-07 4:20

31-Aug-07 4:20

they are the same maybe...

Russell^'31-Aug-07 4:23

31-Aug-07 4:23

Little tips for coding:
1) use longer names for varaibles and functions (this helps to understand what the code do)
2) do not use goto OMG | :OMG:

... find other ways when possible: in your case you can return -1; or something similar

Big Grin | :-D

Russell

Roger Broomfield31-Aug-07 5:45

Roger Broomfield

31-Aug-07 5:45

having been brought up from coding raw hex on an 8080 SDK through Assembler and on into C and C++ I have no qualms about using goto. goto is after all just a JMP return -1 is also a JMP. break is also a JMP.

why are you threatened by goto?

David Crow31-Aug-07 5:54

31-Aug-07 5:54

Because you don't goto the middle of another function.

"A good athlete is the result of a good and worthy opponent." - David Crow

"To have a respect for ourselves guides our morals; to have deference for others governs our manners." - Laurence Sterne

Roger Broomfield31-Aug-07 6:02

Roger Broomfield

31-Aug-07 6:02

obviously you have never disassembled BIOS. JMPing into the middle of functions is common practice in every BIOS I have ever disassembled.

Russell^'31-Aug-07 6:14

31-Aug-07 6:14

are that BIOSs work?
Laugh | :laugh:

Russell

David Crow31-Aug-07 6:55

31-Aug-07 6:55

Last time I checked, Roger, we were discussing a C program.

"A good athlete is the result of a good and worthy opponent." - David Crow

"To have a respect for ourselves guides our morals; to have deference for others governs our manners." - Laurence Sterne

Russell^'31-Aug-07 5:57

31-Aug-07 5:57

I wrote "....when possible..." Wink | ;)

It is a bad pratique (for me). It is demonstrated that we can do everything without the use that keyword.
Of course I use it (sometimes)....but I'm not a newbie like him Big Grin | :-D

First you have to learn how make addictions by hand....and after that you can use the calculator Smile | :)

Russell

Rajesh R Subramanian31-Aug-07 8:04

Rajesh R Subramanian

31-Aug-07 8:04

http://xkcd.com/292/[^] Poke tongue | ;-P

Nobody can give you wiser advice than yourself. - Cicero
.·´¯`·->ßRÅhmmÃ<-·´¯`·.

Russell^'31-Aug-07 8:21

31-Aug-07 8:21

He wins a Nobel: he create a time machine!
From today, I'll use gotos more often. Big Grin | :-D

Russell

Hamid_RT31-Aug-07 4:20

Hamid_RT

31-Aug-07 4:20

Did you compile this code?

youbo31-Aug-07 4:23

31-Aug-07 4:23

yes, but it have two errors,and i couldn't find them

Maximilien31-Aug-07 4:26

Maximilien

31-Aug-07 4:26

What were the errors ? and on what line ?

Maximilien Lincourt
Your Head A Splode - Strong Bad

youbo31-Aug-07 4:31

31-Aug-07 4:31

it is the new code changed by me follow,but it also have one error.
#include <iostream>
using namespace std;
int oo(int m);
int sum=0;
void main()
{
int m;
cin>>m;

oo(m);

cout<

Russell^'31-Aug-07 4:34

31-Aug-07 4:34

youbo wrote:
unexpected end of file found

then complete this line
#include "???????"

as #include "stdafx.h"

and check the parentesis {}

Russell

David Crow31-Aug-07 5:22

31-Aug-07 5:22

youbo wrote:
the error is :fatal error C1004: unexpected end of file found

See here.

Had you used <pre> tags, and proper indentation, you could have quickly seen the error:

using namespace std;
 
int oo(int m);
 
int sum=0;
 
void main()
{
    int m;
    cin>>m;
 
    oo(m);
 
    cout<<sum;
};
 
int OO( int m)
{
    for(int j=2;j<=m;j++)
    { 
        if (m%j==0)
        { 
            sum=sum+j;
        };
        
        if (m==1)
        {
            return -1 ;
        };
 
    return OO(m/j);
};

Once you address the C1004 error, you'll still be presented with a LNK2001 error, however. And to top it all off, a stack overflow is imminent.

"A good athlete is the result of a good and worthy opponent." - David Crow

"To have a respect for ourselves guides our morals; to have deference for others governs our manners." - Laurence Sterne

Russell^'31-Aug-07 4:28

31-Aug-07 4:28

Do what Maximilien suggested.

replace every oo with OO! Big Grin | :-D

Russell

David Crow31-Aug-07 5:21