C / C++ / MFC

void CBlast_vib_procDlg::Next() 
{
	FILE *f_ptr1;
	FILE *f_ptr2;
	const int MAX=15;

	CBlast_vib_procDlg rr;
//
			float north[2000];
			float east[2000];
			float elv[2000];
			CString fname[2000];
//
			char buffer[MAX];

	// TODO: Add your control notification handler code here

	UpdateData();

	if(m_outputFileName == "" ) 
	{

	MessageBox("All file names have to be typed in !");
	rr.m_outputFileName = m_outputFileName;
	rr.DoModal();
	UpdateData(false);

	}

	// TODO: Add extra validation here
	#define BUFSIZE MAX_PATH
	WIN32_FIND_DATA FindFileData;
	LPTSTR DirSpec;
//
		HANDLE hFind = INVALID_HANDLE_VALUE;
		CString fileName[2000];
		int i=0;
		DirSpec = (LPTSTR) malloc (BUFSIZE);
		DirSpec=TEXT("*.txt");
//
		hFind = FindFirstFile(DirSpec, &FindFileData);
	        fileName[0]=FindFileData.cFileName;
//
      while (FindNextFile(hFind, &FindFileData) != 0) 
      {
		 i+=1;
         fileName[i]=FindFileData.cFileName;
      }
	  int nfile=i;
      FindClose(hFind);
///*
//
	     for (int ii=0;ii<nfile;ii++)
		{
//
		if((f_ptr2 = fopen(fileName[ii],"r")) == NULL) {

		MessageBox("output file open problems !");
														}
//
		fscanf( f_ptr2,"%s	%s	%s\n",buffer,buffer,fname[ii].GetBuffer(MAX_PATH));	//read fileName
		fname[ii].ReleaseBuffer();
		fscanf( f_ptr2,"%s	%s	%s	%s	%s\n",buffer,buffer,buffer,buffer,buffer);  //full name
		fscanf( f_ptr2,"%s	%s	%s\n",buffer,buffer,buffer);	//date
		fscanf( f_ptr2,"%s	%s	%s\n",buffer,buffer,buffer);	//time
		fscanf( f_ptr2,"%s	%s	%s	%s\n",buffer,buffer,buffer,buffer);	//lati
		fscanf( f_ptr2,"%s	%s	%s	%s\n",buffer,buffer,buffer,buffer);	//lonti
		fscanf( f_ptr2,"%s	%s	%f\n",buffer,buffer,&elv[ii]);	//range
		fscanf( f_ptr2,"%s	%s	%s	%s\n",buffer,buffer,buffer,buffer);	//file sixe
		fscanf( f_ptr2,"%s	%s	%s	%s\n",buffer,buffer,buffer,buffer);	//zone value
		fscanf( f_ptr2,"%s	%s	%s	%s\n",buffer,buffer,buffer,buffer);	//focus value
		fscanf( f_ptr2,"%s	%s	%s	%s	%s\n",buffer,buffer,buffer,buffer,buffer);	//mm per pixel
		fscanf( f_ptr2,"%s	%s	%s\n",buffer,buffer,buffer);	//temperature
//
		fscanf( f_ptr2,"%s	%s	%f\n",buffer,buffer, &east[ii]);		//easting
		fscanf( f_ptr2,"%s	%s	%f\n",buffer,buffer,&north[ii]);		//northing
		fclose(f_ptr2);
//
		 }
//
//	write output data file
//
//	open output data file

		if((f_ptr1 = fopen(m_outputFileName,"w")) == NULL) {

	MessageBox("output file open problems !");
	rr.m_outputFileName = m_outputFileName;
	rr.DoModal();
	UpdateData(false);
	}
//
		 fprintf (f_ptr1, "%i\n", nfile);
//
		 char * tittle = "number of monitors";
		 fprintf (f_ptr1, "%i\n", nfile);
		 char * tittle_item = "fineName		Easting(m)	Northing(m)		elv(m)";
//
		 fprintf (f_ptr1, "%s\n", tittle_item);
//
	     for (ii=0;ii<nfile;ii++)
		{
//		 
			 fprintf (f_ptr1, "%s	%f	%f	%f\n", fname[ii],east[ii],north[ii],elv[ii]);
//		 
		 }		
//
		fclose( f_ptr1);
/*

	     for (int ii=0;ii<nfile;ii++)
		{
//		 
			 fprintf (f_ptr1, "%s\n", fileName[ii]);
//		 
		 }		
//
		fclose( f_ptr1);
*/

	CDialog::OnOK();

	}
//
//</code>

Luc Pattyn wrote:

there is a problem in fileName[i]=FindFileData.cFileName;

this line does NOT copy the filename, it copies the pointer to the cFileName field
in your unique FindFileData struct, hence in all iterations it will point to the
buffer containing the last data written into it.

If you want to hold all the different filenames, you must copy them, which you could
do with strcpy() or strncpy().

mrby123 wrote:

DirSpec = (LPTSTR) malloc (BUFSIZE);
DirSpec=TEXT("*.txt");

CStringArray fileNames;        
CFileFind fileFind;
 
BOOL bFound = fileFind.FindFile("*.txt");
while (bFound)
{
    bFound = fileFind.FindNextFile();
    fileNames.Add(fileFind.GetFilePath());
}
 
fileFind.Close();
 
for (int ii = 0; ii < fileNames.GetSize(); ii++)
{
    CString fileName = fileNames.GetAt(ii);
 
    CStdioFile fileIn;        
    if (fileIn.Open(fileName, CFile::modeRead))
    {
        CString line;
        fileIn.ReadString(line);
 
        // parse line here
         
        fileIn.Close();
    }
}
 
CStdioFile fileOut;
if (fileOut.Open(m_outputFileName, CFile::modeWrite))
{
    CString str;
 
    str.Format("%d\n", fileNames.GetSize());
    fileOut.WriteString(str);
    fileOut.WriteString(str);
 	 
    fileOut.WriteString("fineName  Easting(m)  Northing(m)  elv(m)\n");
 
    for (int ii = 0; ii < fileNames.GetSize(); ii++)
    {
        CString fileName = fileNames.GetAt(ii);
 
        str.Format("%s  %f  %f  %f\n", fileName, east[ii], north[ii], elv[ii]);
        fileOut.WriteString(str);
    }
 
    fileOut.Close();
}

DavidCrow wrote:

If so, buffer will not hold them all.

DavidCrow wrote:

You could have possibly found the problem sooner by using the debugger

Mark Salsbery
Microsoft MVP - Visual C++

Sunil Shindekar wrote:

I think this statement might have the problem.

fscanf( f_ptr2,"%s %s %s\n",buffer,buffer,fname[ii].GetBuffer(MAX_PATH));

Sunil Shindekar wrote:

Taking the value in character array and then assigning it to CString might be better option.

Sunil Shindekar wrote:

If the data is too large to store in the currently allocated memory for the pointer by the CString, then there will be memory overrun. It can cause overwriting the values of other memory locations which may or may not include file pointer also or FILE structure also.

static wchar_t* p[1] = {(wchar_t*)L"GOO_" (wchar_t*)L"FOO"};

static wchar_t* p[1] = {(wchar_t*)L"GOO_" L"FOO"};