|
Pete O'Hanlon wrote: if the number is 3 or 4 do something.
I believe the terminology used was "do stuff". 
Regards,
--Perspx
"The Blue Screen of Death, also known as The Blue Screen of Doom, the "Blue Screen of Fun", "Phatul Exception: The WRECKening" and "Windows Vista", is a multi award-winning game first developed in 1995 by Microsoft" - Uncyclopedia
Introduction to Object-Oriented JavaScript
|
|
|
|
|
Perspx wrote: I believe the terminology used was "do stuff".
I'm sorry. I forget the technical stuff.
|
|
|
|
|
"all of the variables used were num1, num2, num3 etc. down the line. This is in several pages of code and it goes up to num26,"
They probably started off calling them a, b, c, ..., z, until learning that "you shouldn't use 1-letter variable names."
|
|
|
|
|
haha, It just occured to me that there are 26 variables and 26 letters in the alphabet. That's too ironic to ignor. 
"The shortest distance between two points is under construction"
-Noelie ALtito
|
|
|
|
|
I am forced to solve a bug in our VB application, the original programmer has left the building a long time ago. Due to the long and complex function they have given the variable a simple name.
Dim nFoo() As Integer
Dim sfoo() As String
Dim sFoo1() As String So i went on looking what could be placed inside a nFoo,
and i stumbled on this gem.
j = 0
For i = 1 To lvwCardGrp.ListItems.Count
ReDim Preserve nFoo(j)
nFoo(j) = Mid$(lvwCardGrp.ListItems(i).Key, 3)
j = j + 1
Next And of course why change a winning strategy the same for the sfoo's.
Learn from the mistakes of others, you may not live long enough to make them all yourself.
|
|
|
|
|
Nice gem
"The clue train passed his station without stopping." - John Simmons / outlaw programmer
"Real programmers just throw a bunch of 1s and 0s at the computer to see what sticks" - Pete O'Hanlon
"Not only do you continue to babble nonsense, you can't even correctly remember the nonsense you babbled just minutes ago." - Rob Graham
|
|
|
|
|
In the original coders defense, if there (previously) was a condition around the ReDim / nFoo = / j = lines, the logic makes perfect sense.
|
|
|
|
|
Graham Bradshaw wrote: In the original coders defense, if there (previously) was a condition around the ReDim / nFoo = / j = lines, the logic makes perfect sense.
Actually in one of the three cases this was true, but then one could do it like this (which is what i chose)
j = 0
ReDim nFoo(lvwCardGrp.ListItems.Count - 1)
For i = 1 To lvwCardGrp.ListItems.Count
if some_condition then
nFoo(j) = Mid$(lvwCardGrp.ListItems(i).Key, 3)
j = j + 1
endif
Next
ReDim nFoo(j - 1)
In this case only one allocation happens. And in the end free up the unnecessary space, without the preserve statement which needs to copy the data to a new location.
Learn from the mistakes of others, you may not live long enough to make them all yourself.
|
|
|
|
|
Shouldn't ReDim nFoo(j - 1) be ReDim Preserve nFoo(j - 1)? As the code is, you reinitialise nFoo.
|
|
|
|
|
Graham Bradshaw wrote: Shouldn't ReDim nFoo(j - 1) be ReDim Preserve nFoo(j - 1)? As the code is, you reinitialise nFoo.
Yes, you are correct.
Thanks for pointing it out, must have slipped through my fingers while typing it over from the real code. 
Note to myself: Learn to use Copy-Past 
Learn from the mistakes of others, you may not live long enough to make them all yourself.
|
|
|
|
|
I don't see how. Unless I read it wrong, j is unnecessary, the array should be redimed before the loop, we already know how many items it needs to hold.
|
|
|
|
|
PIEBALDconsult wrote: we already know how many items it needs to hold.
Not if you only add items to the array in some condition, which was the point I was trying to make. See the other reply to my post for an example.
|
|
|
|
|
Ah, I see, I did read it wrong.
|
|
|
|
|
That's just too bad. Way too bad.
|
|
|
|
|
Seen in a VBA app in lieu of commenting out/deleting 138 lines of junk code.
Yes, the VBA editor is a steaming pile of excrement, but any decent text editor will let you insert the ' via a global insert/replace. 
Today's lesson is brought to you by the word "niggardly". Remember kids, don't attribute to racism what can be explained by Scandinavian language roots.
-- Robert Royall
|
|
|
|
|
dan neely wrote: any decent text editor
Like Notepad?
|
|
|
|
|
maybe, I'd've used a regex to match on the start of a line. I know notepad doesn't do that, can it match on the newline char itself?
Today's lesson is brought to you by the word "niggardly". Remember kids, don't attribute to racism what can be explained by Scandinavian language roots.
-- Robert Royall
|
|
|
|
|
dan neely wrote: can it match on the newline char itself
Not that I've found, I usually resort to opening the file in Word to do that. 
|
|
|
|
|
I'd recommend Notepad++ a free replacement for Notepad, with all those regex goodies you've been missing
|
|
|
|
|
 It even forgets CTRL+Z after two usage instances. I would say, WordPad should be safe and reliable though it nags us against saving in plain text formats.
Vasudevan Deepak Kumar
Personal Homepage
Tech Gossips
All the world's a stage,
And all the men and women merely players.
They have their exits and their entrances;
And one man in his time plays many parts... --William Shakespeare
|
|
|
|
|
Maybe the programmer thought they would enable that section of code later?
Even then, it is better, IMO, to comment out the section of code until it is needed.
Bill W
|
|
|
|
|
actually it was originally needed, but subsequently "commented out" code.
Today's lesson is brought to you by the word "niggardly". Remember kids, don't attribute to racism what can be explained by Scandinavian language roots.
-- Robert Royall
|
|
|
|
|
even better than if (2 == 2)
|
|
|
|
|
The first 2 letters in the language should tell you why that code exists.
|
|
|
|
|
Exactly, any real programmer would write "if (!true)"
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
