C / C++ / MFC

how to move button when the dialog is resized?

4-Oct-11 16:15

There is nothing special about ? nor any printable character in a text box.

If, as you imply, that you are setting IDC_EDIT1 during the OnChangeEdit1() callback, that is a loop. Code changing the window content or user entering data both trigger the OnChange type events. Happens with all the major controls, pulldown menus, tree controls, etc. In those, changing the selection is the same as the user clicking on them.

because it's looping, it never gets around to drawing the contents on the screen.

antonio3434-Oct-11 7:29

4-Oct-11 7:29

Hi, I have a modeless dialog with a edit control, and two button.

I show the dialog maximized, I got maximized the edit control with

void CEjemplo::OnSize(UINT nType, int cx, int cy)
{
	CDialogEx::OnSize(nType, cx, cy);
		 
		if (GetDlgItem(IDC_EDIT1))
		{
			  GetDlgItem(IDC_EDIT1)->MoveWindow(5,5,cx-1,cy-1); 
		}

}

But I dont know how to move the button at the botton of the dialog.
Now, when I maximized the dialog the button dont move itself and it is at back of edit control

I tried to do

if (GetDlgItem(IDC_EDIT1))
        {
              GetDlgItem(IDC_EDIT1)->MoveWindow(5,5,cx-1,cy-1);
              GetDlgItem(IDC_button1)-&gt;MoveWindow(5,5,cx-1,cy-1);

        }

But not run.

Maximilien4-Oct-11 8:02

Maximilien

4-Oct-11 8:02

antonio343 wrote:
But not run

Crash or not moving the controls in the good position ?

When doing something like that, moving controls around, I play dumb and use the dialog client area rectangle (GetClientRect).

Play around with the values to move to the bottom of the rect returned by GetClientRect;

Note: be careful with the coordinate being in either relative to the client or window .

Watched code never compiles.

antonio3434-Oct-11 8:17

4-Oct-11 8:17

Not moving the controls in the good position.

I dont know how to use this function.

Maybe on this way:

void CEjemplo::OnSize(UINT nType, int cx, int cy)
{
    CDialogEx::OnSize(nType, cx, cy);
         CRect myRect;
   GetClientRect(&myRect);

        if (GetDlgItem(IDC_EDIT1))
        {
             m_Edit.MoveWindow(5,5,cx-55,cy-55); //puedes jugar con estos valores
              m_Button1.MoveWindow(myRect.right, myRect.bottom,
      myRect.Width(), myRect.Height());

        }

}

But I dont want to change the size, only the position. I'd like to move at the right botton corner.

Maximilien4-Oct-11 8:22

Maximilien

4-Oct-11 8:22

use SetWindowPos (with the SWP_NOSIZE option, check the documentation ) function instead of MoveWindow.

M.

Watched code never compiles.

antonio3434-Oct-11 8:45

4-Oct-11 8:45

I've tried with this:

void CEjemplo::OnSize(UINT nType, int cx, int cy)
{
    CDialogEx::OnSize(nType, cx, cy);
    CRect myRect;
    const CWnd &p=wndBottom;
    GetClientRect(&myRect);

        if (GetDlgItem(IDC_EDIT1))
        {
            GetDlgItem(IDC_EDIT1)->MoveWindow(5,5,cx-50,cy-80);  //puedes jugar con estos valores
            m_Button1.SetWindowPos(&p,5,5,cx-50,cy-75,SWP_NOSIZE);
        }
}

But when I run the application it crash Dead | X|

David Crow4-Oct-11 8:54

David Crow

4-Oct-11 8:54

antonio343 wrote:
But when I run the application it crash

Exception thrown? Assertion fired? Have you stepped into the code to see what is actually going on?

"One man's wage rise is another man's price increase." - Harold Wilson

"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons

"Show me a community that obeys the Ten Commandments and I'll show you a less crowded prison system." - Anonymous

antonio3434-Oct-11 9:04

4-Oct-11 9:04

I'm sorry , the error wasn't due to the setwindowspos. I solved the error.

It run well, but I need know the coordinates of the right bottom corner.

David Crow4-Oct-11 9:21

David Crow

4-Oct-11 9:21

antonio343 wrote:
It run well, but I need know the coordinates of the right bottom corner.

Relative to what?

TheGreatAndPowerfulOz4-Oct-11 9:01

TheGreatAndPowerfulOz

4-Oct-11 9:01

antonio343 wrote:

m_Button1.SetWindowPos(&p,5,5,cx-50,cy-75,SWP_NOSIZE)

change this to read:

m_Button1.SetWindowPos(&wndTop, cx - m_Button1.Width - 5, cy - m_Button1.Height - 5, 0, 0, SWP_NOSIZE);

If your actions inspire others to dream more, learn more, do more and become more, you are a leader." - John Quincy Adams
You must accept one of two basic premises: Either we are alone in the universe, or we are not alone in the universe. And either way, the implications are staggering” - Wernher von Braun

antonio3434-Oct-11 11:21

4-Oct-11 11:21

I cant change this, becouse CButton don't have some member "width" and "Height"

Chuck O'Toole4-Oct-11 12:22

4-Oct-11 12:22

A CButton is a Window, WIndows have Rect (GetWindowRect() function). Rect gives you height and width. So it's not a straightforward as posted but easily obtainable.

TheGreatAndPowerfulOz4-Oct-11 12:28

TheGreatAndPowerfulOz

4-Oct-11 12:28

Sorry, the other poster is right. Use

CRect rect;
m_Button1.GetWindowRect(&rect)
rect.Width()
rect.Height()

Chuck O'Toole4-Oct-11 13:55

4-Oct-11 13:55

Assuming the coordinate system is correct (Client View, Control View, Screen View), which is a big assumption at this point, the line

m_Button1.MoveWindow(myRect.right, myRect.bottom,

seems to want to put the left edge of the button at the right edge of the main window, therefore, it's not visible since it's off the right side of the main window. Similarly for the y coordinate, you're putting the top of the button starting at the bottom of the window, therefore it's outside the viewing area

David Crow4-Oct-11 9:03

David Crow

4-Oct-11 9:03

antonio343 wrote:
Now, when I maximized the dialog the button dont move itself...

See if the Extras section of this article is of any help. I've updated the code in a newer project but the premise is the same.

TheGreatAndPowerfulOz4-Oct-11 9:37

TheGreatAndPowerfulOz

4-Oct-11 9:37

+5. Good bit of code.

Chuck O'Toole4-Oct-11 12:11

4-Oct-11 12:11

The first two arguments to MoveWindow are the new X and Y coordinates of the upper left of the window. You are putting all your things at [5,5], on top of one another. No wonder it doesn't seem to work.