Re: Appending Quations to a string - C# Discussion Boards

Arun Philip Reynolds20-Mar-12 8:18

20-Mar-12 8:18

Hi Everyone,

I am facing an issue in appending quotes to the string value that I am holding in a String Builder variable.
The value that I hold in the variable is,
abc@def@ghi@jkl@

I would like to change the @ with "," so that i get the final result as,
"abc","def","ghi","jkl"

I tried the string format, but did not succeed. Any help in this matter is greatly appriciated.

Re: Appending Quations to a string

PIEBALDconsult20-Mar-12 8:44

PIEBALDconsult

20-Mar-12 8:44

Replace perhaps?

But why create the string with the @s rather than the characters you want? Creating the string the way you want shouldn't be a problem. Perhaps you should explain what you want and show the code you have so far.

Re: Appending Quations to a string

Arun Philip Reynolds20-Mar-12 9:27

Arun Philip Reynolds

20-Mar-12 9:27

try
        {
            
            //OleDbCommand oleDbCmd = new OleDbCommand("Select * From [Sheet1]", oleDbCon);            
            //oleDbDa.SelectCommand = oleDbCmd;            
            oleDbDa.Fill(ds,"ServerName");
            DataTable dt = ds.Tables["ServerName"];
            //string str1stValue = ds.Tables[0].Rows[0][0].ToString();
            foreach(DataRow dr in dt.Rows)
            {
                foreach (DataColumn dc in dt.Columns)
                    strServerName.Append(dr[dc].ToString()).Append("\",\"");
                    //strServerName.AppendFormat("\",\"", dr[dc].ToString());
            }
           //strFinalList = strFinalList.AppendFormat("\",\"", strServerName);
            Response.Write(strServerName);
        }

But here again i need to get rid of of the quotations at the end of the string and need to add it before the string.
The result that is get is,
abc","def","ghi","jkl","

As I had mentioned i'd like to get the result as,
"abc","def","ghi","jkl"

Re: Appending Quations to a string

PIEBALDconsult20-Mar-12 9:34

PIEBALDconsult

20-Mar-12 9:34

How about:

foreach(DataRow dr in dt.Rows)
{
  foreach (DataColumn dc in dt.Columns)
    strServerName.AppendFormat( "\"{0}\"," , dr[dc] );
}
strServerName.Length-- ;

Re: Appending Quations to a string

Arun Philip Reynolds20-Mar-12 10:17

Arun Philip Reynolds

20-Mar-12 10:17

Thanks PIEBALDconsult for the help. The solution is just perfect, but there is an extra comma at the end of the string,
"abc","def","ghi","jkl",
How could I get rid of the last comma?

Re: Appending Quations to a string

PIEBALDconsult20-Mar-12 10:27

PIEBALDconsult

20-Mar-12 10:27

You probably left off the decrement of the Length.

Re: Appending Quations to a string

Arun Philip Reynolds20-Mar-12 10:51

Arun Philip Reynolds

20-Mar-12 10:51

oops!!! I did miss that one out. After I included the decrement of the length, it is removing all the comma's from the string. I need the comma that is in between the strings but it should not add the comma at the end of the string.

It is just like the SQL statement that we write.
e.g. Select * from table where name like ('abc','def','ghi')

I am trying to send the variable in this format to the stored procedure.

Re: Appending Quations to a string

PIEBALDconsult20-Mar-12 10:58

PIEBALDconsult

20-Mar-12 10:58

It should be outside the loop, as in the example I posted.

Re: Appending Quations to a string

PIEBALDconsult20-Mar-12 11:01

PIEBALDconsult

20-Mar-12 11:01

Arun Philip Reynolds wrote:
It is just like the SQL statement that we write.
e.g. Select * from table
where name like ('abc','def','ghi')

If you are using SQL Server (and you should), then how about... SQL Server 2008 User Defined Table Types and Table-Valued Parameters[^]

Re: Appending Quations to a string

Arun Philip Reynolds20-Mar-12 11:06

Arun Philip Reynolds

20-Mar-12 11:06

Thanks, but I just tried this,

strHolderString = strServerName.ToString();
                strHolderString = strHolderString.TrimEnd(',');
                strFinalList = new StringBuilder(strHolderString);

here the strHolderString is a string variable and I am getting the result that I was looking for.

Thanks once again to everyone. Big Grin | :-D

Re: Appending Quations to a string

PIEBALDconsult20-Mar-12 11:17

PIEBALDconsult

20-Mar-12 11:17

Just decrement the Length. Why create two Strings and another StringBuilder?

Re: Appending Quations to a string

Luc Pattyn20-Mar-12 9:50

Luc Pattyn

20-Mar-12 9:50

What Piebald said; or else what I often do when I do not want the StringBuilder:

string result="";
string sep="";
foreach(string s in strings) {
    result+=sep+"\""+s+"\"";
    sep=",";
}

Luc Pattyn [My Articles] Nil Volentibus Arduum

Re: Appending Quations to a string

PIEBALDconsult20-Mar-12 10:12

PIEBALDconsult

20-Mar-12 10:12

I'd still use String.Format -- I find it easier to read than a bunch of concatenations.

Re: Appending Quations to a string

Arun Philip Reynolds20-Mar-12 10:21

Arun Philip Reynolds

20-Mar-12 10:21

I'd like to go with PIEBALDconsult on this one, but thanks for the help Smile | :)

Re: Appending Quations to a string

Luc Pattyn20-Mar-12 10:27

Luc Pattyn

20-Mar-12 10:27

I use it sparingly, string.Format I mean.

Smile | :)

Luc Pattyn [My Articles] Nil Volentibus Arduum

Re: Appending Quations to a string

PIEBALDconsult20-Mar-12 11:05

PIEBALDconsult

20-Mar-12 11:05

I use it whenever I can -- muaa haa ha ha! Cool | :cool:

Re: Appending Quations to a string

Arun Philip Reynolds20-Mar-12 11:08

Arun Philip Reynolds

20-Mar-12 11:08

strHolderString = strServerName.ToString();
                strHolderString = strHolderString.TrimEnd(',');
                strFinalList = new StringBuilder(strHolderString);

I just tried the above and it works for me. Here the strHolderString is a string variable and I used the TrimEnd function to get rid of the trailing comma. The strFinalList is a StringBuilder variable.

Thanks once again to all

Re: Appending Quations to a string

BobJanova21-Mar-12 3:15

BobJanova

21-Mar-12 3:15

There's pretty much no reason to avoid StringBuilder, it's in the core Framework and the memory footprint of creating a new object is likely to be less than all the wasted strings you make in a concatenation session.

Re: Appending Quations to a string

wizardzz20-Mar-12 9:47

wizardzz

20-Mar-12 9:47

Based on your posts below, have you tried using string.Join?

string example = String.Join(", ", string[] exList);

"I have a theory that the truth is never told during the nine-to-five hours. "
— Hunter S. Thompson

Re: Appending Quations to a string

Subin Mavunkal20-Mar-12 23:17

Subin Mavunkal

20-Mar-12 23:17

You can use SmartPaster addin for visual studio.Copy the text you needed and paste it as string builder.Here is the code and installer

http://www.martinwilley.com/blog/2010/06/06/SmartPasteIn2010.aspx[^]

Re: Appending Quations to a string

Pete O'Hanlon21-Mar-12 3:53

Pete O'Hanlon

21-Mar-12 3:53

An alternative approach is to use a list of strings instead of a StringBuilder to build your list and then concatenate them as you need. Here's one way to do this:

public class FormattedStrings : List<string>()
{
  public override string ToString()
  {
    StringBuilder sb = new StringBuilder();
    bool started = false;
    foreach (string item in this)
    {
      if (started)
      {
        sb.AppendFormat(",\"{0}\"", item);
      }
      else
      {
        started = true;
        sb.AppendFormat("\"{0}\"", item);
      }
    }

    return sb.ToString();
  }
}

I am assuming that you have assigned the @ symbol when you built your StringBuilder.

*pre-emptive celebratory nipple tassle jiggle* - Sean Ewington

"Mind bleach! Send me mind bleach!" - Nagy Vilmos

My blog | My articles | MoXAML PowerToys | Mole 2010 - debugging made easier - my favourite utility

Re: Appending Quations to a string

PIEBALDconsult21-Mar-12 4:53

PIEBALDconsult

21-Mar-12 4:53

Ew, yuck, duplicated code. Dead | X|

Needless boolean, needless if/else.

Stick the comma on the end and decrement it off when you're done.

Re: Appending Quations to a string

Pete O'Hanlon21-Mar-12 5:59

Pete O'Hanlon

21-Mar-12 5:59

To be fair, this was just knocked up in the CP editor and doesn't reflect what I would push out the door.

I did look at doing it your way, but saw that you'd already posted that so it seemed that there wasn't much point to showing something that was already done - this is purely to stimulate the mind into thinking of other ways of solving the problem.

*pre-emptive celebratory nipple tassle jiggle* - Sean Ewington

"Mind bleach! Send me mind bleach!" - Nagy Vilmos

My blog | My articles | MoXAML PowerToys | Mole 2010 - debugging made easier - my favourite utility

Image Encryption

Hinnawi8720-Mar-12 5:14

Hinnawi87

20-Mar-12 5:14

I want to encrypt image by other image using Xor operation in c# as follow:

private byte[] EncypteXoRImage(byte[] inputImage, byte[] byImage)
{
byte[] Result = (byte[])inputImage.Clone();
if (byImage == null)
return Result;
for (int k = inputImage.Length / 3; k < inputImage.Length; k++)
{

Result.SetValue(Convert.ToByte((byte)Result.GetValue(k) ^ (byte)byImage.GetValue(k % byImage.Length)), k);

}
return Result;
}
where inputImage is picture which i want to encrypt,the problem is when i want to display encrypted picture on the picturebox,the result is:
the encrypted part was displayed by a gray background

Re: Image Encryption

harold aptroot20-Mar-12 5:37

harold aptroot

20-Mar-12 5:37

Code doesn't seem to make sense. Could you try this?

private byte[] EncypteXoRImage(byte[] inputImage, byte[] byImage)
{
    if (byImage == null)
        return (byte[])inputImage.Clone();
    byte[] result = new byte[inputImage.Length];
    for (int k = 0; k < result.Length; k++)
    {
        result[k] = (byte)(inputImage[k] ^ byImage[k]);
    }
    return result;
}

Use Ctrl+Left/Right to switch messages, Ctrl+Up/Down to switch threads, Ctrl+Shift+Left/Right to switch pages.