Welcome to the Lounge

_Maxxx_25-Sep-13 14:03

25-Sep-13 14:03

What I would ask myself is:

Why did you re-invent the wheel? Was this good value for money for your employer? There are many many solutions available to do this (for free) on the interwebs.

Why did it need to be 'terse and fast' - surely better to be 'easily readable, debuggable and maintainable'?

MVVM # - I did it My Way
___________________________________________
Man, you're a god. - walterhevedeich 26/05/2011

.\\axxx
(That's an 'M')

R. Giskard Reventlov25-Sep-13 14:48

25-Sep-13 14:48

Curmudgeon

"If you think it's expensive to hire a professional to do the job, wait until you hire an amateur." Red Adair.
Those who seek perfection will only find imperfection
nils illegitimus carborundum

me, me, me
me, in pictures

_Maxxx_25-Sep-13 15:11

25-Sep-13 15:11

mark merrens wrote:
~~Curmudgeon~~professional

ftfy

MVVM # - I did it My Way
___________________________________________
Man, you're a god. - walterhevedeich 26/05/2011

.\\axxx
(That's an 'M')

R. Giskard Reventlov26-Sep-13 5:02

26-Sep-13 5:02

_Maxxx_ wrote:
~~Curmudgeonprofessional~~

Pompous ass.

That should do it.

Dan Sutton26-Sep-13 13:42

26-Sep-13 13:42

Concur!

_Maxxx_26-Sep-13 15:07

26-Sep-13 15:07

Well f*** you

MVVM # - I did it My Way
___________________________________________
Man, you're a god. - walterhevedeich 26/05/2011

.\\axxx
(That's an 'M')

R. Giskard Reventlov27-Sep-13 4:56

27-Sep-13 4:56

No sir, f*** you. I would suggest purchasing a sense of humor: you plainly lack one and are so far up your own ass I can't believe you can see well enough to have written these posts. Have a nice day, twat.

_Maxxx_28-Sep-13 1:00

28-Sep-13 1:00

mark merrens wrote:
No sir,

Nice of you to call me Sir, anyway.

mark merrens wrote:
would suggest purchasing a sense of humor: you plainly lack one

So you calling me a pompous ass is funny but me saying "f*** you" isn't? And you want me to get a sense of humour?

mark merrens wrote:
so far up your own ass

I honestly don't see why you are having a go at me at all!

The OP said "at work today: I wrote something to take a number and convert it into English"

I asked "Why did you re-invent the wheel? Was this good value for money for your employer? There are many many solutions available to do this (for free) on the interwebs.

Why did it need to be 'terse and fast' - surely better to be 'easily readable, debuggable and maintainable'?"

which I feel is a fair and reasonable set of questions.

Later the OP pointed out that they are self employed and were writing for fun - which is fair enough and negates my questions.

In what way, then, is that pompous? In what manner does that show me to be up my own ass?

mark merrens wrote:
Have a nice day, twat.

I have reported this post as abusive, as it clearly is.

feel free to report my 'f u' post as abusive if, for some reason, my short insult post cannot be amusing while yours can.

In the meantime, may I suggest you look around for a cheap, second hand sense of humour, and take a large chill pill?

MVVM # - I did it My Way
___________________________________________
Man, you're a god. - walterhevedeich 26/05/2011

.\\axxx
(That's an 'M')

R. Giskard Reventlov28-Sep-13 5:45

28-Sep-13 5:45

I won't be so childish as to report you and I didn't say f*** you: that was your game. So, again, feel free to do one.

Dan Sutton25-Sep-13 15:55

25-Sep-13 15:55

Because I felt like it. And I am my employer, so it was excellent value!

_Maxxx_25-Sep-13 17:31

25-Sep-13 17:31

As a purely fun exercise it's the kind of thing I enjoy doing;

I don't think it was good financial value regardless as to who the employer was - although keeping the staff happy is equally important Wink | ;)

MVVM # - I did it My Way
___________________________________________
Man, you're a god. - walterhevedeich 26/05/2011

.\\axxx
(That's an 'M')

Dan Sutton25-Sep-13 19:51

25-Sep-13 19:51

Oh, yeah - I wouldn't bother unless I had a slow day: in this case, I did - it was purely for fun.

_Maxxx_25-Sep-13 20:11

25-Sep-13 20:11

You had to go no further than our very own CP[^]

or I stole this from StuckOverflow...

public static string NumberToWords(int number)
{
    if (number == 0)
        return "zero";

    if (number < 0)
        return "minus " + NumberToWords(Math.Abs(number));

    string words = "";

    if ((number / 1000000) > 0)
    {
        words += NumberToWords(number / 1000000) + " million ";
        number %= 1000000;
    }

    if ((number / 1000) > 0)
    {
        words += NumberToWords(number / 1000) + " thousand ";
        number %= 1000;
    }

    if ((number / 100) > 0)
    {
        words += NumberToWords(number / 100) + " hundred ";
        number %= 100;
    }

    if (number > 0)
    {
        if (words != "")
            words += "and ";

        var unitsMap = new[] { "zero", "one", "two", "three", "four", "five", "six", "seven", "eight", "nine", "ten", "eleven", "twelve", "thirteen", "fourteen", "fifteen", "sixteen", "seventeen", "eighteen", "nineteen" };
        var tensMap = new[] { "zero", "ten", "twenty", "thirty", "forty", "fifty", "sixty", "seventy", "eighty", "ninety" };

        if (number < 20)
            words += unitsMap[number];
        else
        {
            words += tensMap[number / 10];
            if ((number % 10) > 0)
                words += "-" + unitsMap[number % 10];
        }
    }

    return words;
}

MVVM # - I did it My Way
___________________________________________
Man, you're a god. - walterhevedeich 26/05/2011

.\\axxx
(That's an 'M')

Dan Sutton26-Sep-13 4:57

26-Sep-13 4:57

Yeah - I thought about doing it that way but it wasn't fun to write! I'm sure I overcomplicated it, but - whatever - I had fun!

PIEBALDconsult26-Sep-13 13:46

26-Sep-13 13:46

Not very flexible.

_Maxxx_26-Sep-13 15:07

26-Sep-13 15:07

True -0 but the likelihood of the number system changing any time soon is low Wink | ;)

MVVM # - I did it My Way
___________________________________________
Man, you're a god. - walterhevedeich 26/05/2011

.\\axxx
(That's an 'M')

PIEBALDconsult26-Sep-13 16:10

26-Sep-13 16:10

Think globally.

Marc A. Brown26-Sep-13 2:11

Marc A. Brown

26-Sep-13 2:11

1. Why not?
2. To learn the language. Beats the heck out of "Hello World".
3. For the same reason people draw doodles.
4. Why not? Smile | :)

Dan Sutton26-Sep-13 4:58

26-Sep-13 4:58

That's it - it's a doodle!

_Maxxx_26-Sep-13 15:12

26-Sep-13 15:12

Marc A. Brown wrote:
1. Why not?

Well he said he did it at work, so I assumed it was something required for the business rather than being done as a leisure activity. So re-inventing the wheel is not generally a good thing for a business to do with so trivial a thing.

Marc A. Brown wrote:
To learn the language. Beats the heck out of "Hello World".

Again - he was doing it at work & I assumed that he wasn't doing it for fun but for a business requirement.

Marc A. Brown wrote:
4. Why not?

Because

MVVM # - I did it My Way
___________________________________________
Man, you're a god. - walterhevedeich 26/05/2011

.\\axxx
(That's an 'M')

PIEBALDconsult26-Sep-13 16:29

26-Sep-13 16:29

_Maxxx_ wrote:
he said he did it at work, so I assumed it was something required for the
business

I did most of my Turing Machine experiments at a previous job. Unsure | :~

User 5924125-Sep-13 15:31

User 59241

25-Sep-13 15:31

I love code reviews. Very brave. The hyenas are moving in.

Peter Wasser

Art is making something out of nothing and selling it.
Frank Zappa

PIEBALDconsult25-Sep-13 18:22

25-Sep-13 18:22

P.S.

Maybe look into using a StringBuilder

It's too early for a Friday Programming Quiz.

Mark_Wallace25-Sep-13 21:34

Mark_Wallace

25-Sep-13 21:34

Oh oh, that's not how you do phone numbers.

I wanna be a eunuchs developer! Pass me a bread knife!

Dan Sutton26-Sep-13 4:55