|
Warning - you have a C&P error on line 5.
I have some coolaid to sell you. 
Marc
|
|
|
|
|
W∴ Balboos wrote: I swear, copy and paste should be banned, and there must be something we can put into the water that prevents programmers like this from ever writing another line of code.
Where have I read this before? 
It's an OO world.
public class SanderRossel : Lazy<Person>
{
public void DoWork()
{
throw new NotSupportedException();
}
}
My blog[ ^]
|
|
|
|
|
Marc Clifton wrote: copy and paste should be banned
AMEN BROTHER! 
Copy/paste is the evil of this world.
I've seen SO much copy/paste bugs. I'll just copy this code, make some edits, forget to change a variable name and... 1 + 1 = 3...
I actually worked with someone who worked with a certain library for well over a year, but couldn't create a new project because he always copy/pasted his code and didn't actually know what he was doing...
And then there's the duplicated code...
I always say copy/paste is a right you have to earn and once you've earned it you won't need it.
It's an OO world.
public class SanderRossel : Lazy<Person>
{
public void DoWork()
{
throw new NotSupportedException();
}
}
My blog[ ^]
|
|
|
|
|
Sander Rossel wrote: I always say copy/paste is a right you have to earn and once you've earned it you won't need it.
Well said!
Marc
|
|
|
|
|
Lovely horrendous code. Even a stringbuilder would not be an improvement, it would merely be some paint over a house that is nearly collapsing.
Bastard Programmer from Hell 
If you can't read my code, try converting it here[^]
|
|
|
|
|
Mopping with the crane open! 
It's an OO world.
public class SanderRossel : Lazy<Person>
{
public void DoWork()
{
throw new NotSupportedException();
}
}
My blog[ ^]
|
|
|
|
|
Marc Clifton wrote: there must be something we can put into the water
There is. Code reviews. 
/ravi
|
|
|
|
|
Ravi Bhavnani wrote: There is. Code reviews.
How do you figure out that the guy you hired is creating crap, especially if you're a small outfit and you only have one dev, and it's this guy? Do you hire another consultant to do the code reviews?
BTW, here's is bio:
With degrees in Electrical Engineering and Computer Science, Mr. ... has been programming and designing computer applications for over 20 years. The last five years have been spent on developing mobile apps for iPhone, iPad, Android and Windows Phone and Windows 8 environments. Mr. ... skills also include being a MS SQL Server DBA as well as a web developer..
Now that's scary.
Marc
|
|
|
|
|
Marc Clifton wrote: How do you figure out that the guy you hired is creating crap,
I don't see any way other than formal/informal code inspections. The sooner they're done, the easier they are to fix. Eyeballing check-ins at the end of the day may be a valuable yet lightweight approach. If there's no cause for alarm, further reviews may be unnecessary, or at least not frequently required.
You don't want to find yourself in a situation (as I expect you may be in) where several weeks of check-ins are of poor quality. 
/ravi
|
|
|
|
|
Marc Clifton wrote: With degrees in Electrical Engineering and Computer Science, Mr. ... has been programming and designing computer applications for over 20 years
That's like saying "with qualifications in refrigerator and microwave oven design, Mr. ... has been creating recipes for over 20 years".
The qualifications have little to do with the work he's doing.
I wanna be a eunuchs developer! Pass me a bread knife!
|
|
|
|
|
Ravi Bhavnani wrote: Marc Clifton wrote: there must be something we can put into the water
There is. Code reviews.
Well, we could put the offending developer into the water ... head-first. That would solve the issue.
The good thing about pessimism is, that you are always either right or pleasently surprised.
|
|
|
|
|
I disagree. Copy-paste makes for highly-efficient coding. Not only do you get a perfect duplicate of a line, but the efficiency increases exponentially with the number of copies! Think about it... First you copy-paste one line, then you copy-paste those two lines, then four... You could be copying thousands of lines after only a dozen pastes!
And think about it... Unlike all of those silly objects and functions, you can change just one of those thousand copies without having to mess with all of the rest! It's so much better that way.
So everyone needs to copy-paste more....copy-paste more....copy-paste more....copy-paste more....copy-paste more....copy-paste more....copy-paste more....copy-paste more....copy-paste more....copy-paste more....copy-paste more....copy-paste more....copy-paste more....copy-paste more....copy-paste more....
(Chris needs to add a <sarcasm> tag to the forums, cause I know someone is going to take the above literally... Well, not now, because they'll read this message... Unless it's too small... Here, let me make it smaller.....)
|
|
|
|
|
Ian Shlasko wrote: you can change just one of those thousand copies without having to mess with all of the rest! It's so much better that way.
Or use it's evil twin, search and replace to easily change everything everywhere with the click of a mouse button!
You've changed my thinking, Ian! I shall strive to become a copy-paste-replace developer!
Marc
|
|
|
|
|
Copy is OK; it's paste that causes the trouble.
|
|
|
|
|
If he was being paid by number of lines of code, I congratulate him. I'd probably do the same.
I wanna be a eunuchs developer! Pass me a bread knife!
|
|
|
|
|
C&P is so called static modelling, where programmer runs the program (not the computer), evaluate the exit and then write exactly what he done in his head in code, so computer can repeat it. Ironic thing is that computer is made for automation and actually it is his job to do the repetitive stuff while human neural network (called brain) is very good in finding and giving short description of repetitive stuffs.
So apparently some brains are better than others.
|
|
|
|
|
So, I just compiled a small web service that I, of course, did not write.
Got almost 100 "Unreachable code detected" errors. Why? Here's an example:
case [some case]:
return CallSomeFunction(xmldata);
break;
Marc
|
|
|
|
|
Well, you wouldn't want it to fall through, would you?
|
|
|
|
|
Well, on a X86, you'd need at 3 bit errors on the instruction to convert a RET (0xC2) to a NOP (0x90), but hey, I'm all for defensive programming!
Marc
|
|
|
|
|
It is a correct message 
The compiler should not "guess" that the break is redundant; it should give a warning for the programmer to ignore.
Bastard Programmer from Hell
If you can't read my code, try converting it here[^]
|
|
|
|
|
|
Well there is the problem,
The last line says "Break" so it did
|
|
|
|
|
wouldn't those be warnings? are is "warnings as errors" turned on?
If your actions inspire others to dream more, learn more, do more and become more, you are a leader.-John Q. Adams
You must accept one of two basic premises: Either we are alone in the universe, or we are not alone in the universe. And either way, the implications are staggering.-Wernher von Braun
Only two things are infinite, the universe and human stupidity, and I'm not sure about the former.-Albert Einstein
|
|
|
|
|
TheGreatAndPowerfulOz wrote: wouldn't those be warnings? are is "warnings as errors" turned on?
They are warnings. I hate warnings. Warnings should be fixed, even if their not treated as errors by the IDE.
Marc
|
|
|
|
|
agreed
If your actions inspire others to dream more, learn more, do more and become more, you are a leader.-John Q. Adams
You must accept one of two basic premises: Either we are alone in the universe, or we are not alone in the universe. And either way, the implications are staggering.-Wernher von Braun
Only two things are infinite, the universe and human stupidity, and I'm not sure about the former.-Albert Einstein
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
