|
GESY wrote: I get big weir numbers
Yes, but you never tell us what the actual values are. Please don't think we can guess what results you see on your screen.
|
|
|
|
|
GESY wrote:
char *FDBUF = new char[dwSize];
If dwSize is 0, this allocation is pointless. In other words, don't continue if GetFileVersionInfoSize() did not return anything useful.
GESY wrote:
wsprintf(BUFF, "Version is %d",LOBYTE(LOWORD(pvi->dwProductVersionLS)),HIBYTE(LOWORD(pvi->dwProductVersionMS)));
To match the Details tab of the Properties dialog, I'd think you'd want something similar to:
wsprintf(BUFF, _T("File version is %u.%u.%u.%u"), HIWORD(pvi->dwFileVersionMS), LOWORD(pvi->dwFileVersionMS), HIWORD(pvi->dwFileVersionLS), LOWORD(pvi->dwFileVersionLS));
…
wsprintf(BUFF, _T("Product version is %u.%u.%u.%u"), HIWORD(pvi->dwProductVersionMS), LOWORD(pvi->dwProductVersionMS), HIWORD(pvi->dwProductVersionLS), LOWORD(pvi->dwProductVersionLS));
"One man's wage rise is another man's price increase." - Harold Wilson
"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons
"You can easily judge the character of a man by how he treats those who can do nothing for him." - James D. Miles
modified 27-Jul-18 0:01am.
|
|
|
|
|
Auch!! Now I getting good help, someone here responded like you and to you too
10000 of thanks, for a good help and explanation !!
I will try that later when I have a chance and keep you posted.
|
|
|
|
|
I tested your lines of code, and was great, finally I can see what I was looking for !!!
I also thanks to the code you give me, I understand better that " wsprintf " function.
Now front the programmers point of view, if you testing for a particular dll
that you need to be some specific version, which one would you use?
Using dwFileVersionMS, The result was 5.82
Using dwProductVersionMS The result was 6.1
And 1000 of thanks again!!! 
|
|
|
|
|
GESY wrote: ...which one would you use?
That would depend on if I wanted to know the product's version or the file's version. They're two different things.
"One man's wage rise is another man's price increase." - Harold Wilson
"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons
"You can easily judge the character of a man by how he treats those who can do nothing for him." - James D. Miles
|
|
|
|
|
You are using the wrong fields to get the values. The versions are stored in the following way:
dwProductVersionMS, contains the major fields, HIWORD, LOWORD e.g. 10, 0
dwProductVersionLS, contains the minor fields as above, e.g. 17134, 48
Also you are only printing one number, but passing two values in your wsprintf statement. So it should be:
wsprintf(BUFF, "Version is %d.%d",HIWORD(pvi->dwProductVersionMS), LOWORD(pvi->dwProductVersionMS));
|
|
|
|
|
Now that's what I call a good explanation!!!
1000 of thanks to you sr.
I will try that a will let you know....... 1000 of thanks again.!!!
|
|
|
|
|
I tested your lines of code, and now I can see what I was looking for!
Well done, plus you even give an explanation of the fields and what they do.
( You told me: dwProductVersionMS, contains the major fields, HIWORD, LOWORD e.g. 10, 0
dwProductVersionLS, contains the minor fields as above, e.g. 17134, 48
)
Excellent!
I must ask you, you using %d but I had seen %u
I believe one is for a integer and the other for a long ?
Which one is correct or does that matter based on the function we testing?
And finally in programming which value would you do a test for?
Using dwFileVersionMS, The result was 5.82
Using dwProductVersionMS The result was 6.1
And before I go...... 1000 of thanks !!
|
|
|
|
|
GESY wrote:
I must ask you, you using %d but I had seen %u
I believe one is for a integer and the other for a long ?
%d is for a signed int and %u is for an unsigned int. Since DWORDs and WORDs are both unsigned, %u is preferred.
"One man's wage rise is another man's price increase." - Harold Wilson
"Fireproof doesn't mean the fire will never come. It means when the fire comes that you will be able to withstand it." - Michael Simmons
"You can easily judge the character of a man by how he treats those who can do nothing for him." - James D. Miles
|
|
|
|
|
GESY wrote: using %d but I had seen %u
That is for signed (%d) or unsigned (%u) integers. For a long value you need to add the prefix l thus:
long longValue = 1000000;
printf("long value: %ld\n", longValue);
These format characters are explained in the MSDN documentation at Format Specification Syntax: printf and wprintf Functions[^].
Quote: dwFileVersionMS or dwProductVersionMS ?
Well it depends what you are testing for. The documentation for the specific product or library should tell you which one they are referring to, as they are usually different.
GESY wrote: 1000 of thanks
Happy to help, and I learned a few useful things in the process; so we both benefit.
|
|
|
|
|
Hi, I had make a lot of test and learn a lot thanks to your help, I also testing now how
to work with those values. And I was wondering is there a way to return the
HIWORD(pvi->dwFileVersionMS) and LOWORD(pvi->dwFileVersionMS) as a single long
value instead of converting to a string and then back to a number, the reason I said
that is because I have been testing with this code below...
// wsprintf(BUFF,("%u.%u"),HIWORD(pvi->dwProductVersionMS), LOWORD(pvi->dwProductVersionMS));
// double RTVAL=atof(BUFF);
// if(RTVAL==6.1) MessageBox(hwnd,"It is 6.1","atof return",MB_OK); // Tested OK RTVAL was 6.1
// return RTVA;
Thanks
|
|
|
|
|
I posted to you, but I think I put it on the wrong place, here is the post...
Hi, I had make a lot of test and learn a lot thanks to your help, I also testing now how
to work with those values. And I was wondering is there a way to return the
HIWORD(pvi->dwFileVersionMS) and LOWORD(pvi->dwFileVersionMS) as a single long
value instead of converting to a string and then back to a number, the reason I said
that is because I have been testing with this code below...
// wsprintf(BUFF,("%u.%u"),HIWORD(pvi->dwProductVersionMS), LOWORD(pvi->dwProductVersionMS));
// double RTVAL=atof(BUFF);
// if(RTVAL==6.1) MessageBox(hwnd,"It is 6.1","atof return",MB_OK); // Tested OK RTVAL was 6.1
// return RTVA;
Thanks
|
|
|
|
|
Why are you converting a string to a double just to do a simple comparison? Use a string comparer (strcmp) like:
if(strcmp(BUFF, "6.1") == 0) MessageBox(hwnd,"It is 6.1","version",MB_OK);
Or even simpler
if (HIWORD(pvi->dwProductVersionMS) == 6 && LOWORD(pvi->dwProductVersionMS) == 1)
MessageBox ...
|
|
|
|
|
No my friend those are just experimenting I discover that I could do that, but
the main point using the right fields of the struct and the formatting YOU
teach me a lot with that.
The question was is there is way to combine both Hiword & Loword and
return it as a single long / decimal number, take a look to the idea below.
long THEVERSION
{ Source code here like before
return THEVERSIO; // This will be a long or double with the value of 6.1 or whatever.
}
That function will return 6.1 ( one single number ) is this possible? and thanks again.
|
|
|
|
|
No, it would be difficult, since a LONG type would have to hold the number as 61, or even 611 if the low order value was 11. Each of the four fields are independent values which represent the Major, Minor, Revision and Build numbers of the version. It does not make sense to try and combine them into a single value.
|
|
|
|
|
I got a feeling you going to said that, I tough that maybe was a function
that will put the two together, with a decimal number in between to values.
Anyway....... 10000000 of thanks, I learn a lot thanks to you !!! 
|
|
|
|
|
Hi
I have a program in subdirectory folder as such c:\dira\dirb\program.exe When I do GetCurrentDirectory API I get c:\dira
When Use "program.exe" as the first parm I get returned code 0 followed by file not found from GetLastError
|
|
|
|
|
Return code 0 means the command completed successfully, so calling GetLastError is not necessary, and will give you a meaningless response.
My mistake.
modified 24-Jul-18 5:10am.
|
|
|
|
|
|
Sorry, I misread something somewhere.
|
|
|
|
|
Just use the full path for the lpApplicationName parameter.
Avoid using partial names. When using them you have to ensure that the current working directory is set to the parent of the partial name resulting in a path containg that file.
The only exception is when you know that the application is stored in one of the directories specified in the PATH environment variable. Then you can use the plain file name.
|
|
|
|
|
The problem with using the full path name if my .exe is stored in c:\dira\dirb GetCurrentDirectory only returns c:\dira my module is stored in the current directory
Thanks
modified 24-Jul-18 5:43am.
|
|
|
|
|
You have to know (and usually will know) where the file is stored. Where is the problem using the full path?
GetCurrentDirectory() returns the actual working directory of the session. It is not related in any way to the application calling that function (besides the application has set the working directory explicitly).
Again: Use full pathes. If necessary create them dynamically during runtime. But never expect the current working directory to be a specific one if you have not set it. But when setting it, you can also create full pathes instead.
If you need to know where the application actually executed is stored, access the first command line parameter argv[0] in your main() function. That contains the full path of the executable. Or use the GetModuleFileName function (Windows)[^] with the first parameter set to NULL. With both methods you can extract the path which can be for example used to access other files known to exist in the same directory or a sub directory.
|
|
|
|
|
This helps I’ll look into this thanks
|
|
|
|
|
I have a technical interview with Amazon next month. Would like to know your tips/advice on best practices/ways to crack the Amazon interview.
I've started practicing amazon coding interview questions from here and geeksforgeeks.
Can you tell me on which things I should focus more? Data structure/algos/dp? or something else?
Thanks.
|
|
|
|
General 
News 
Suggestion 
Question 
Bug 
Answer 
Joke 
Praise 
Rant 
Admin 
Submit an article or tip
