Web Development

[UPDATED ]MVC Web API Controller - Pass List<string> Pin

13-Feb-19 10:49

How about adding the white-space in the generated content?

CSS

.surround-brackets::before {
    content: "( ";
}

.surround-brackets::after {
    content: " )";
}

Updated fiddle[^]

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Kevin Marois12-Feb-19 6:32

Re: [UPDATED ]MVC Web API Controller - Pass List<string> Pin

12-Feb-19 6:32

I have a controller with a parameter that is List<string>. The parameter is always null.
Controller

[HttpGet]
public List<string> GetOperatorsNotOnServer(List<string> instrumentOperators)
{
    var bl = GetBusinessLayer();
    var results = bl.GetOperatorsNotOnServer(instrumentOperators);
    return results;
}

I've tried using an array with the same result. What's the right way to pass a list of string to a controller?

UPDATE
When I changed the controller method from [HttpGet] to [HttpPost] it now works. I don't understand why, but it's now working. Can someone explain this to me?

Thanks

If it's not broken, fix it until it is.
Everything makes sense in someone's mind.
Ya can't fix stupid.

modified 12-Feb-19 12:51pm.

Richard Deeming12-Feb-19 7:54

Re: [UPDATED ]MVC Web API Controller - Pass List<string> Pin

12-Feb-19 7:54

Probably related to this:

Parameter Binding in ASP.NET Web API | Microsoft Docs[^]:
If the parameter is a "simple" type, Web API tries to get the value from the URI.
For complex types, Web API tries to read the value from the message body

A List<T> isn't counted as a "simple" type. If you add the [FromUri] attribute to the parameter, then it should work.

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Kevin Marois12-Feb-19 8:08

Re: [UPDATED ]MVC Web API Controller - Pass List<string> Pin

12-Feb-19 8:08

I tried that already. The parameter is a list, but its empty. The data doesn't make it across.

If it's not broken, fix it until it is.
Everything makes sense in someone's mind.
Ya can't fix stupid.

F-ES Sitecore12-Feb-19 23:14

F-ES Sitecore

12-Feb-19 23:14

HttpGet is generally for when the page first loads, that's the method it will call. HttpPost is when the page is a form post, ie the result of someone pressing a Submit button. The instrumentOperators are probably defined in your form, so are available in an httppost but not an httpget.

ASP.Net MVC Serialization Problem - "No parameterless constructor defined for this object"

Kevin Marois11-Feb-19 8:30

Re: ASP.Net MVC Serialization Problem - "No parameterless constructor defined for this object"

11-Feb-19 8:30

This is a bit long but I'm stuck. Working on a WPF app hitting an ASP.NET Web API.

Not sure why but I started getting this message. I haven't changed the API recently.

The entity is posted at the bottom. Seems like the controller can't deserialize byte arrays. When I removed 2 byte[] properties from my model, the error stopped.

With the byte[] properties included I have...

Operator Controller

[HttpGet]
public IEnumerable<OperatorEntity> GetAllOperators()
{
    var bl = GetBusinessLayer();
    var results = bl.GetAll(); //<=== This shows 18 rows with data
    return results;
}

Proxy

public async Task<T> ExecuteAsync<T>() where T : new()
{
    URL = client.BaseUrl + request.Resource;

<pre>
IRestResponse<T> restResponse = await client.ExecuteTaskAsync<T>(request, new CancellationToken());

var result = (T)restResponse.Data; // <===== NO DATA HERE

if (!string.IsNullOrEmpty(restResponse.ErrorMessage))

{
throw new Exception(restResponse.ErrorMessage); // <==== THROWS "No parameterless constructor defined for this object"
}
else
{
if ((int)restResponse.StatusCode >= 299)
{
string message = string.Format("An error occured calling the WebAPI. {0} The status code is '{1}'. {2} The error message is {3}",
Environment.NewLine, restResponse.StatusCode, Environment.NewLine, restResponse.Content);
throw new Exception(message);
}
}

return result;
}
Caller

public async Task<List<OperatorEntity>> GetAllOperatorsAsync()
{
    var webAPIExecutor = new WebAPIExecutor(ServerUrl, "/Operator/GetAllOperators/", Method.GET);
    return await webAPIExecutor.ExecuteAsync<List<OperatorEntity>>();
}

Entity

<pre>    [DataContract]
    [Serializable]
    public class OperatorEntity : _EntityBase
    {
        private bool _BuiltIn;
        [DataMember]
        public bool BuiltIn
        {
            get
            {
                return _BuiltIn;
            }
            set
            {
                if (_BuiltIn != value)
                {
                    _BuiltIn = value;
                    RaisePropertyChanged("BuiltIn");
                }
            }
        }

        private bool _Active;
        [DataMember]
        public bool Active
        {
            get
            {
                return _Active;
            }
            set
            {
                if (_Active != value)
                {
                    _Active = value;
                    RaisePropertyChanged("Active");
                }
            }
        }

        private string _FirstName;
        [DataMember]
        public string FirstName
        {
            get
            {
                return _FirstName;
            }
            set
            {
                if (_FirstName != value)
                {
                    _FirstName = value;
                    RaisePropertyChanged("FirstName");
                }
            }
        }

        private string _LastName;
        [DataMember]
        public string LastName
        {
            get
            {
                return _LastName;
            }
            set
            {
                if (_LastName != value)
                {
                    _LastName = value;
                    RaisePropertyChanged("LastName");
                }
            }
        }

        private string _Username;
        [DataMember]
        public string Username
        {
            get
            {
                return _Username;
            }
            set
            {
                if (_Username != value)
                {
                    _Username = value;
                    RaisePropertyChanged("Username");
                }
            }
        }

        private string _Password;
        [DataMember]
        public string Password
        {
            get
            {
                return _Password;
            }
            set
            {
                if (_Password != value)
                {
                    _Password = value;
                    RaisePropertyChanged("Password");
                }
            }
        }

        private DateTimeOffset? _PasswordChangedDate;
        [DataMember]
        public DateTimeOffset? PasswordChangedDate
        {
            get
            {
                return _PasswordChangedDate;
            }
            set
            {
                if (_PasswordChangedDate != value)
                {
                    _PasswordChangedDate = value;
                    RaisePropertyChanged("PasswordChangedDate");
                }
            }
        }

        private DateTimeOffset? _LastLoginDate;
        [DataMember]
        public DateTimeOffset? LastLoginDate
        {
            get
            {
                return _LastLoginDate;
            }
            set
            {
                if (_LastLoginDate != value)
                {
                    _LastLoginDate = value;
                    RaisePropertyChanged("LastLoginDate");
                }
            }
        }

        private byte[] _rowversion;
        [DataMember]
        public byte[] rowversion
        {
            get
            {
                return _rowversion;
            }
            set
            {
                if (_rowversion != value)
                {
                    _rowversion = value;
                    RaisePropertyChanged("rowversion");
                }
            }
        }

        private short _RoleType;
        [DataMember]
        public short RoleType
        {
            get
            {
                return _RoleType;
            }
            set
            {
                if (_RoleType != value)
                {
                    _RoleType = value;
                    RaisePropertyChanged("RoleType");
                }
            }
        }

        private byte[] _ESignature;
        [DataMember]
        public byte[] ESignature
        {
            get
            {
                return _ESignature;
            }
            set
            {
                if (_ESignature != value)
                {
                    _ESignature = value;
                    RaisePropertyChanged("ESignature");
                }
            }
        }

        private string _Email1;
        [DataMember]
        public string Email1
        {
            get
            {
                return _Email1;
            }
            set
            {
                if (_Email1 != value)
                {
                    _Email1 = value;
                    RaisePropertyChanged("Email1");
                }
            }
        }

        private string _Email2;
        [DataMember]
        public string Email2
        {
            get
            {
                return _Email2;
            }
            set
            {
                if (_Email2 != value)
                {
                    _Email2 = value;
                    RaisePropertyChanged("Email2");
                }
            }
        }

        private bool _SendAlerts;
        [DataMember]
        public bool SendAlerts
        {
            get
            {
                return _SendAlerts;
            }
            set
            {
                if (_SendAlerts != value)
                {
                    _SendAlerts = value;
                    RaisePropertyChanged("SendAlerts");
                }
            }
        }

        private short? _SendAlertsTime;
        [DataMember]
        public short? SendAlertsTime
        {
            get
            {
                return _SendAlertsTime;
            }
            set
            {
                if (_SendAlertsTime != value)
                {
                    _SendAlertsTime = value;
                    RaisePropertyChanged("SendAlertsTime");
                }
            }
        }

        private bool _SendResults;
        [DataMember]
        public bool SendResults
        {
            get
            {
                return _SendResults;
            }
            set
            {
                if (_SendResults != value)
                {
                    _SendResults = value;
                    RaisePropertyChanged("SendResults");
                }
            }
        }

        private short? _SendResultsTime;
        [DataMember]
        public short? SendResultsTime
        {
            get
            {
                return _SendResultsTime;
            }
            set
            {
                if (_SendResultsTime != value)
                {
                    _SendResultsTime = value;
                    RaisePropertyChanged("SendResultsTime");
                }
            }
        }

        private bool _MonitoringSystemUser;
        [DataMember]
        public bool MonitoringSystemUser
        {
            get
            {
                return _MonitoringSystemUser;
            }
            set
            {
                if (_MonitoringSystemUser != value)
                {
                    _MonitoringSystemUser = value;
                    RaisePropertyChanged("MonitoringSystemUser");
                }
            }
        }

        private bool _Email1AllowHtml;
        [DataMember]
        public bool Email1AllowHtml
        {
            get
            {
                return _Email1AllowHtml;
            }
            set
            {
                if (_Email1AllowHtml != value)
                {
                    _Email1AllowHtml = value;
                    RaisePropertyChanged("Email1AllowHtml");
                }
            }
        }

        private bool _Email2AllowHtml;
        [DataMember]
        public bool Email2AllowHtml
        {
            get
            {
                return _Email2AllowHtml;
            }
            set
            {
                if (_Email2AllowHtml != value)
                {
                    _Email2AllowHtml = value;
                    RaisePropertyChanged("Email2AllowHtml");
                }
            }
        }

        private bool _MonitoringSelf;
        [DataMember]
        public bool MonitoringSelf
        {
            get
            {
                return _MonitoringSelf;
            }
            set
            {
                if (_MonitoringSelf != value)
                {
                    _MonitoringSelf = value;
                    RaisePropertyChanged("MonitoringSelf");
                }
            }
        }

        private bool? _IsLockedOut;
        [DataMember]
        public bool? IsLockedOut
        {
            get
            {
                return _IsLockedOut;
            }
            set
            {
                if (_IsLockedOut != value)
                {
                    _IsLockedOut = value;
                    RaisePropertyChanged("IsLockedOut");
                }
            }
        }

        private bool? _IsActiveDirectory;
        [DataMember]
        public bool? IsActiveDirectory
        {
            get
            {
                return _IsActiveDirectory;
            }
            set
            {
                if (_IsActiveDirectory != value)
                {
                    _IsActiveDirectory = value;
                    RaisePropertyChanged("IsActiveDirectory");
                }
            }
        }
    }

If it's not broken, fix it until it is.
Everything makes sense in someone's mind.
Ya can't fix stupid.

Richard Deeming11-Feb-19 11:44

Re: ASP.Net MVC Serialization Problem - "No parameterless constructor defined for this object"

11-Feb-19 11:44

It's apparently a known issue with RestSharp:
bytearray - RestSharp deserialize JSON content(represent an object contains an byte array) error - Stack Overflow[^]
No parameterless constructor defined for this object on arrays & enumerables of simple types · Issue #547 · restsharp/RestSharp · GitHub[^]

Looks like you either need to use List<byte>, or use Json.NET[^] to deserialize the result manually.

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Kevin Marois12-Feb-19 6:27

How to send the 'Connection' header using HttpListenerResponse

12-Feb-19 6:27

Thanks, I'll look into it

If it's not broken, fix it until it is.
Everything makes sense in someone's mind.
Ya can't fix stupid.

Shmuel Zang11-Feb-19 5:29

Shmuel Zang

11-Feb-19 5:29

Hello all.

While trying to implement a web-socket handshake, I encountered a weird behavior. It looks like the HttpListenerResponse class doesn't send the 'Connection' header.

Here is an example for explaining what I mean:

public void TestWebSocketHttpHandshake()
{
    int port = 9444;
    ManualResetEvent serverStartedEvent = new ManualResetEvent(false);
    ManualResetEvent clientClosedEvent = new ManualResetEvent(false);

    // HTTP server that gets a web-socket handshake request and,
    // send back a web-socket handshake response.
    async Task RunHttpServer()
    {
        HttpListener hl = new HttpListener();
        hl.Prefixes.Add($"http://+:{port}/");
        hl.Start();
        serverStartedEvent.Set();
        HttpListenerContext hlc = await hl.GetContextAsync();

        string secWebSocketKeyHeader = hlc.Request.Headers["Sec-WebSocket-Key"]?.Trim();
        string secWebSocketAcceptHeader = Convert.ToBase64String(
            System.Security.Cryptography.SHA1.Create().ComputeHash(
                Encoding.UTF8.GetBytes(secWebSocketKeyHeader + "258EAFA5-E914-47DA-95CA-C5AB0DC85B11")
            )
        );

        hlc.Response.StatusCode = (int)HttpStatusCode.SwitchingProtocols; // 101
        hlc.Response.StatusDescription = "Switching Protocols";
        hlc.Response.ProtocolVersion = new Version("1.1");
        hlc.Response.AddHeader("Upgrade", "websocket");
        hlc.Response.AddHeader("Connection", "Upgrade");
        hlc.Response.AddHeader("Sec-WebSocket-Accept", secWebSocketAcceptHeader);

        hlc.Response.Close();

        // Wait for the client to close.
        clientClosedEvent.WaitOne();
        hl.Stop();
    }

    // Tcp Client that sends a web-socket handshake request and,
    // writes the received web-socket handshake response.
    async Task RunTcpClient()
    {
        const string eol = "\r\n"; // HTTP/1.1 defines the sequence CR LF as the end-of-line marker

        // Wait for the server to start.
        serverStartedEvent.WaitOne();

        using (TcpClient tc = new TcpClient())
        {
            tc.Connect("localhost", port);

            using (NetworkStream ns = tc.GetStream())
            {
                string wsRequest =
                    $"GET /chat HTTP/1.1{eol}Host: localhost:{port}{eol}"+ 
                    $"Upgrade: websocket{eol}Connection: Upgrade{eol}" +
                    $"Sec-WebSocket-Key: dGhlIHNhbXBsZSBub25jZQ=={eol}"+ 
                    $"Sec-WebSocket-Version: 13{eol}{eol}";

                byte[] wsRequestBytes = Encoding.ASCII.GetBytes(wsRequest);
                await ns.WriteAsync(wsRequestBytes, 0, wsRequestBytes.Length);
                Console.WriteLine("Sent request:");
                Console.WriteLine(wsRequest);

                byte[] responseBuf = new byte[256];
                int resBytesCount = await ns.ReadAsync(responseBuf, 0, responseBuf.Length);
                string wsResponse = Encoding.ASCII.GetString(responseBuf, 0, resBytesCount);
                Console.WriteLine("Received response:");
                Console.WriteLine(wsResponse);
            }
        }

        clientClosedEvent.Set();
    }

    Task.WaitAll(RunHttpServer(), RunTcpClient());
}

The result is:

Sent request:
GET /chat HTTP/1.1
Host: localhost:9444
Upgrade: websocket
Connection: Upgrade
Sec-WebSocket-Key: dGhlIHNhbXBsZSBub25jZQ==
Sec-WebSocket-Version: 13


Received response:
HTTP/1.1 101 Switching Protocols
Upgrade: websocket
Content-Length: 0
Server: Microsoft-HTTPAPI/2.0
Sec-WebSocket-Accept: s3pPLMBiTxaQ9kYGzzhZRbK+xOo=
Date: Mon, 11 Feb 2019 16:16:37 GMT

So, what we can see here is that we have a HttpListener server that sets the 'Connection' header in the response but, when the client gets the server's response, the 'Connection' header is missing.

I know that we can use the HttpListenerContext.AcceptWebSocketAsync method for handling the web-socket connection but, this method uses the operating system web-socket support that is supported only from Windows 8/ Windows Server 2012 and, we want this to work also on a Windows Server 2008 system.

I know that there are some solutions on the web for running a web-socket server. But, all the solutions I found are for running a server that listens to web-socket requests on a given port. Since in my case I want to accept web-socket requests on the same port of an existing server (Owin server that does other things), I have to handle it using the given request's HttpListenerContext.

Can anyone explain this behavior (the missing 'Connection' header) or, suggest a solution?

modified 11-Feb-19 14:27pm.

Local IIS Development Question

Kevin Marois7-Feb-19 11:07

7-Feb-19 11:07

I'm working on an app that hits a Web API. Right not I'm developing in VS2017 using it's local IIS. Can I somehow configure this so that other PC's can access that web API for testing purposes?

If it's not broken, fix it until it is.
Everything makes sense in someone's mind.
Ya can't fix stupid.

Richard Deeming7-Feb-19 11:13

7-Feb-19 11:13

Something like this?
Accessing an IIS Express site from a remote computer -- Johan Driessen's blog[^]

(The "Update for Visual Studio 2015" also applies to VS2017.)

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Kevin Marois7-Feb-19 11:37

7-Feb-19 11:37

I went through his blog right before I posted. After adding the binding line to the .config, then running my app, I get

"Process with an Id of [some id] is not running."

Here's my config entries

<site name="RemoteServices.BusinessServices" id="6">
    <application path="/" applicationPool="Clr4IntegratedAppPool">
        <virtualDirectory path="/" physicalPath="C:\Projects\RemoteServices.BusinessServices" />
    </application>
    <bindings>
        <binding protocol="http" bindingInformation="*:53175:localhost" />
        <binding protocol="http" bindingInformation="*:53175:192.168.51.66"  //
</site>

I closed an reopened vs and my web api project failed to load. Commented out the line in the .config and everythign is back to normal.

If it's not broken, fix it until it is.
Everything makes sense in someone's mind.
Ya can't fix stupid.

Richard Deeming8-Feb-19 0:55

8-Feb-19 0:55

Kevin Marois wrote:
<binding protocol="http" bindingInformation="*:53175:192.168.51.66" //<I added this

Is that a typo in your question, or did you really miss out the closing /> from that element?

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Kevin Marois11-Feb-19 5:26

11-Feb-19 5:26

Yes, it was a typo. Fixed it and all works as expected.

Thank you again

If it's not broken, fix it until it is.
Everything makes sense in someone's mind.
Ya can't fix stupid.

Kevin Marois12-Mar-19 12:48

12-Mar-19 12:48

Richard,

I'm back to this again. I had this working and now it doesn't.

I went back & checked my work. I did the following:

IIS Config

<bindings>
    <binding protocol="http" bindingInformation="*:53122:localhost" />
    <binding protocol="http" bindingInformation="*:53125:192.168.51.66" />
</bindings>

I also ran

netsh http add urlacl url=http://192.168.51.66:53125/ user=everyone

netsh advfirewall firewall add rule name="ePlex Remote Services" dir=in protocol=tcp localport=53125 profile=private remoteip=localsubnet action=allow

When I run the web api from my dev pc it works fine. But when I try to hit 192.168.51.66:53125 from another PC it can't find it.

I'm not sure how to debug this. Any thoughts?

If it's not broken, fix it until it is.
Everything makes sense in someone's mind.
Ya can't fix stupid.

Richard Deeming13-Mar-19 1:33

13-Mar-19 1:33

Is the API project running when you try to access it from the remote PC?

Is the firewall's "private" profile active?

Is the remote PC on the same local subnet as your dev PC?

Try turning on logging for the firewall to see if that gives you any information:
How to Track Firewall Activity with the Windows Firewall Log[^]

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Kevin Marois13-Mar-19 6:14

"The requested resource does not support http method 'GET"

13-Mar-19 6:14

Well, I fixed it, but I don't know what was wrong.

First, I went through all your suggestions. Still couldn't get it to work.

So I removed & recreated the Web API project, ran the steps from that blog, and bingo - back & and accessable remotely again.

Thanks for your help again.

If it's not broken, fix it until it is.
Everything makes sense in someone's mind.
Ya can't fix stupid.

Kevin Marois7-Feb-19 10:05

Re: "The requested resource does not support http method 'GET"

7-Feb-19 10:05

I'm trying to call a method on my Operator controller called AddOperator

[HttpPost]
public void AddOperator(OperatorEntity entity)
{
    var bl = GetBusinessLayer();
    bl.Add(entity);
}

RestClient baseURl is "{http://localhost.fiddler:53175/api}"

The RestRequest.Resource is "/Operator/AddOperator/".

The RestRequest.Parameters collection has one entry which is an instance of the OperatorEntity.

Fiddler Output

GET http://localhost:53175/api/Operator/AddOperator/ HTTP/1.1
Accept: application/json, text/json, text/x-json, text/javascript, application/xml, text/xml, text/plain
User-Agent: RestSharp/106.6.7.0
Host: localhost:53175
Accept-Encoding: gzip, deflate
Connection: Keep-Alive

Notice the GET in the output.

I'm really new to WebAPI's, but I thought that I needed to mark the controller method with [HttpPost] , yet that doesn't seem to work.that

What am I doingwrong here?

If it's not broken, fix it until it is.
Everything makes sense in someone's mind.
Ya can't fix stupid.

Richard Deeming7-Feb-19 10:28

Re: "The requested resource does not support http method 'GET"

7-Feb-19 10:28

You do need to mark the method with [HttpPost] (or technically, [HttpPut] if this is a REST API).

The client call is using the wrong HTTP method.

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Kevin Marois7-Feb-19 11:05

Asp.Net MVC Delete Method Not Allowed

7-Feb-19 11:05

ya, that was it. Thank you sir!

If it's not broken, fix it until it is.
Everything makes sense in someone's mind.
Ya can't fix stupid.

Kevin Marois6-Feb-19 6:53

6-Feb-19 6:53

I'm working on a WPF app against an ASP.Net MVC Web API.

I'm trying to implement a delete in my Operator controller. I'm getting

System.Exception: 'An error occured calling the WebAPI. 
 The status code is 'MethodNotAllowed'. 
 The error message is {"Message":"The requested resource does not support http method 'DELETE'."}'

Client Side Proxy

public async Task DeleteOperatorAsync(Guid id)
{
    await Task.Factory.StartNew(() =>
    {
        var webAPIExecutor = new WebAPIExecutor(ServerUrl, "/Operator/Delete/", Method.DELETE);
        webAPIExecutor.AddParameter(id, "id");
        webAPIExecutor.Execute();
    });
}

Controller

[HttpDelete]
public void Delete(Guid id)
{
    IBusinessLayer bl = new BusLayer();
    bl.DeleteOperator(id);
}

The class WebAPIExecutor is working fine for all other calls so it's most likely not the problem, but I can post it if someone wants to see it.

Fiddler shows this info

DELETE <a href="http://localhost:53175/api/Operator/Delete/">http://localhost:53175/api/Operator/Delete/</a> HTTP/1.1
Accept: application/json, text/json, text/x-json, text/javascript, application/xml, text/xml, text/plain
User-Agent: RestSharp/106.6.7.0
Content-Type: application/json
Host: localhost:53175
Content-Length: 38
Accept-Encoding: gzip, deflate

"77932bef-1b12-4204-9bd7-9a50f854a72a"

All other Web API calls are working. Canyone know what's wrong?

If it's not broken, fix it until it is.
Everything makes sense in someone's mind.
Ya can't fix stupid.

Richard Deeming6-Feb-19 7:12

6-Feb-19 7:12

I suspect it's because you're passing the parameter in the request body, rather than in the URL:
ASP.NET web API HTTP Delete 405 Method Not Allowed - Stack Overflow[^]

You might need to add the [FromBody] attribute to your parameter:
Using [FromBody] | Parameter Binding in ASP.NET Web API | Microsoft Docs[^]

Slightly off-topic:

public async Task DeleteOperatorAsync(Guid id)
{
    await Task.Factory.StartNew(() =>
    {
        var webAPIExecutor = new WebAPIExecutor(ServerUrl, "/Operator/Delete/", Method.DELETE);
        webAPIExecutor.AddParameter(id, "id");
        webAPIExecutor.Execute();
    });
}

That just looks nasty. It would be better to make your WebAPIExecutor class expose async methods. The Execute method is IO-bound, not CPU-bound, so pushing the work onto a background thread doesn't make much sense.

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Kevin Marois6-Feb-19 10:18

6-Feb-19 10:18

That did it. I set the FromBody attrib and it worked.

As far as the Executor, here's the Execute code:

public void Execute()
{
    URL = client.BaseUrl + request.Resource;

    IRestResponse result = null;

    try
    {
        result = client.Execute(request);

        //TODO: Handle this differently.
        int resultCode = (int)result.StatusCode;

        //if (result.StatusCode != HttpStatusCode.OK)
        if (resultCode > 299)
        {
            string message = string.Format("An error occured calling the WebAPI. {0} The status code is '{1}'. {2} The error message is {3}",
                                            Environment.NewLine, result.StatusCode, Environment.NewLine, result.Content);

            throw new Exception(message);
        }
    }
    catch (Exception e)
    {
        throw e;
    }
}

Not sure what in here I could await. The RestClient doesn't expose any async methods.

Your thoughts?

If it's not broken, fix it until it is.
Everything makes sense in someone's mind.
Ya can't fix stupid.

Richard Deeming7-Feb-19 0:44

7-Feb-19 0:44

Is that RestSharp[^]?

If so, there's an ExecuteTaskAsync method that would work:
RestSharp/RestClient.Async.cs at 64357df6f8c428f3b39e78ab4b3034596dd2e953 · restsharp/RestSharp · GitHub[^]

Also:

Quote:

catch (Exception e)
{
    throw e;
}

Don't do that. You've just thrown away the stack trace of the exception. If you have to catch and rethrow, just use throw; instead of throw e;. But in this case, since you're not doing anything with the exception, you can just remove the try..catch block.

And:

Quote:

throw new Exception(message);

I wish Microsoft had made the Exception class abstract; there's never a good reason to throw new Exception(...); instead of using a more specific exception type.

"These people looked deep within my soul and assigned me a number based on the order in which I joined."
- Homer

Kevin Marois7-Feb-19 8:35