Welcome to the Lounge

Re: Need an opinion on a circular IList<T> implementation

5-Feb-20 23:05

fair enough. I'd like some methods too, but i just don't know what to call them. I'll stew on it some more.

Real programmers use butterflies

OriginalGriff5-Feb-20 23:19

OriginalGriff

5-Feb-20 23:19

Have an Add and a Remove method, but add an overload for the special cases that uses an enum to control where it goes or comes from. Yes, it's a little less efficient (but a delegate table can help with that if the enum indexes into it) but it's a load easier to keep track of mentally than half a dozen or so Add methods.

"I have no idea what I did, but I'm taking full credit for it." - ThisOldTony
AntiTwitter: @DalekDave is now a follower!

Re: Need an opinion on a circular IList<T> implementation

honey the codewitch5-Feb-20 23:39

Re: Need an opinion on a circular IList<T> implementation

5-Feb-20 23:39

I think i'll pass on that. It's more types, and it breaks with the way microsoft does things on their list based datastructures like Stack<T> and Queue<T>

Real programmers use butterflies

Sander Rossel5-Feb-20 23:27

Sander Rossel

5-Feb-20 23:27

What you could do is add them as extension methods, either on your own (base-)class or interface or on IList<T>.
That way, you keep the base interface/implementation clean, while still offering utility methods that possibly extend to every implementation of your interface.
If you go that way, I'd recommend creating an ICircularList<T>, inherit from IList<T>, and add the extension methods there.

Or just add PushFront and PushBack, which is easy and straight-forward Laugh | :laugh:

Best,
Sander

sanderrossel.com
Migrating Applications to the Cloud with Azure
arrgh.js - Bringing LINQ to JavaScript
Object-Oriented Programming in C# Succinctly

Re: Need an opinion on a circular IList<T> implementation

honey the codewitch5-Feb-20 23:37

Re: Need an opinion on a circular IList<T> implementation

5-Feb-20 23:37

I actually thought about doing that but I don't want to add them to standard list interfaces, just this one. I don't like putting inefficient methods on standard lists because it will encourage poor programming.

As far as adding them just to the CircularList that way, or creating ICircularList<t>, I don't really want the latter as I'd like to follow what microsoft has done (most of the time) with their list based data structures like Queue<T> and Stack<T> and just create the class itself. I can add extension methods, and I almost did, but the rest of my class is factored as partial classes - CircularList.cs, CircularList.ICollection.cs, CircularList.IList.cs, etc so I'll probably just add it like that.

I'm leaning toward PushFront/PopFront/PushBack/PopBack like STL, because it's also at least somewhat like Microsoft's pattern in .NET

Real programmers use butterflies

Arthur V. Ratz5-Feb-20 23:31

Re: Need an opinion on a circular IList<T> implementation

5-Feb-20 23:31

I'm got an opinion. As far as I'm familiar with programming and algorithms, I think that for circular lists you still have to create your own non-generic class ICircularList<t> and implement a functionality for performing the most of circular lists operations. In this case, the using of the existing generic .NET collections is not efficient for that purpose, since it might come to be wasteful.

Here's a list of guidelines on how to implement circular lists:

Create a Circular Singly Linked List in C# Csharp Star[^]
c# - Is the LinkedList in .NET a circular linked list? - Stack Overflow[^]
Circular Linked List | Set 1 (Introduction and Applications) - GeeksforGeeks[^]
Circular Linked list - Sorted Add Delete | C# Online Compiler | .NET Fiddle[^]
C# - Singly Linked Circular List[^]
Circular linked list – An implementation using C# | {love to code?}[^]

...

You may also google to find the answer by using the following query:

Quote:
circular linked list in c#

Cheers, Arthur. Smile | :)

honey the codewitch5-Feb-20 23:42

Re: Need an opinion on a circular IList<T> implementation

5-Feb-20 23:42

First, it's not a linked list, circular or otherwise.

That would be a much different structure, with much different methods.

It's a circular buffer exposed as a IList<T>

Given your seeming confusion about that it might prompt me to rename though i'm not sure to what.

Because it's a circular buffer IList<T>, and ICollection<T> serve me fine. Sure you *can* call Insert(1, item) or RemoveAt(2) and that's not efficient, but it's no less efficient than doing it on a straight List<T> so I'm fine with it.

Real programmers use butterflies

Arthur V. Ratz5-Feb-20 23:51

Re: Need an opinion on a circular IList<T> implementation

5-Feb-20 23:51

In this case, all that I would recommend is to write a specialization of the generic Queue<t> collection if it's good for your task, otherwise implement your own.

Specifically, first invoke, for example:

Queue<string> numbers = new Queue<string>();
numbers.Enqueue("one");
numbers.Enqueue("two");
numbers.Enqueue("three");
numbers.Enqueue("four");
numbers.Enqueue("five");

And then, implement some kind of push_front, push_back and pop_front, pop_back, as well as buffer shifting functionality to have an ability to perform circular ops. Smile | :)

honey the codewitch5-Feb-20 23:56

Re: Need an opinion on a circular IList<T> implementation

5-Feb-20 23:56

I've already done that. I'm just trying to figure out what to name them.

Right now everything, including the efficient push_back/push_front/etc are done through the IList<t> interface.

Literally all i need to do at this point is just create names for the methods with the efficient ops. the ops are already implemented and exposed through IList<t> standard Insert/Add/Remove/RemoveAt

i think after this thread I'm going with

PushFront/PushBack/PopFront/PopBack

Real programmers use butterflies

Arthur V. Ratz5-Feb-20 23:59

Re: Need an opinion on a circular IList<T> implementation

5-Feb-20 23:59

If you use Queue<t> as the base class, then the derived class name should be something kind of CircularQueue<t> and ICircularQueue<t> if it's an interface. Otherwise, try out a different name.

honey the codewitch6-Feb-20 0:31

Re: Need an opinion on a circular IList<T> implementation

6-Feb-20 0:31

I'm not deriving from anything. It's backed by an array, just like List<t> is

Real programmers use butterflies

Arthur V. Ratz6-Feb-20 0:34

Re: Need an opinion on a circular IList<T> implementation

6-Feb-20 0:34

As I've already explained, the suggestions for the class naming are:

CircularQueue<t> and CircularBuffer<t>

Arthur V. Ratz6-Feb-20 0:01

Re: Need an opinion on a circular IList<T> implementation

6-Feb-20 0:01

Also, since you've implemented the functionality required as a C#.NET class library used in your project, then you can name the class and interface such as MyProjCircularBuffer<t> and IMyProjCircularBuffer<t>.

Slacker0076-Feb-20 1:16

Slacker007

6-Feb-20 1:16

You ask a lot of programming questions in the Lounge, and to be honest, in my opinion, they should be in the forums where others can benefit from them. The majority of members who use this site are not active participants in the Lounge.

Also, the Lounge is not for programming questions.

I know I came off as a jerk here, but it had to be said.

Big Grin | :-D

It's much easier to enjoy the favor of both friend and foe, and not give a damn who's who. -- Lon Milo DuQuette

Re: Need an opinion on a circular IList<T> implementation

Pete O'Hanlon6-Feb-20 3:20

6-Feb-20 3:20

You beat me to it. In fact, I'm going to add my own.

Re: Need an opinion on a circular IList<T> implementation

Greg Utas6-Feb-20 1:54

Greg Utas

6-Feb-20 1:54

honey the codewitch wrote:
I can go the .NET route that MS took and add methods like Enqueue() and Dequeue() (queue-like) but that only covers adding to the back, and removing from the front. I can add Pop() and Push() (stack-like) but that only covers adding and removing from the back.

I would have thought that Push and Pop would add and remove from the front, even if internally it's the back of your data structure.

I have one-way and two-way queues in which the elements themselves provide a queue link member (a pointer). The methods are Enq (at the back), Henq (at the front), and Deq (from the front). Also Insert (after something else) and Exq (from somewhere other than the front). There's no special method to remove from the back. If I were to add one, I would probably go with PopBack and rename Enq, Henq, and Deq to PushBack, Push, and Pop.

Re: Need an opinion on a circular IList<T> implementation

Pete O'Hanlon6-Feb-20 3:21

6-Feb-20 3:21

honey the codewitch wrote:
What would you do?

I'd start by asking in the appropriate forum. You've been hear long enough to know that the Lounge is NOT for programming questions.

Re: Need an opinion on a circular IList<T> implementation

honey the codewitch6-Feb-20 3:28

Re: Need an opinion on a circular IList<T> implementation

6-Feb-20 3:28

I agree with phil.o about this, and you think it's inappropriate, report it.

I've had these types of questions reported before but in the end they pass, because they aren't programming questions.

I'm asking an opinion about naming and style.

You may think it crosses the line. In the past mods haven't. If you don't like that, you can always apply to work at CP. I'm sure it's a fun job.

Real programmers use butterflies

Pete O'Hanlon6-Feb-20 3:33

6-Feb-20 3:33

You do realise I'm one of the mods don't you?

It's also very disingenuous of you to imply that everything is fine with this type of question but Chris has had words with you before.

Re: Need an opinion on a circular IList<T> implementation

Greg Utas6-Feb-20 3:48

Greg Utas

6-Feb-20 3:48

What's the right forum for this kind of thing?

Re: Need an opinion on a circular IList<T> implementation

Pete O'Hanlon6-Feb-20 5:24

6-Feb-20 5:24

We have both a C# forum and QA which would be more appropriate. The lounge has clear guidelines right at the top.