Why can't loop allow to enter 1st name ?

Question

0.00/5 (No votes)

See more:

C++

int main()
{
    int length;
    cout << "Enter the no. of names: ";
    cin >> length;
    string *names = new string[length];
    //cout << "\n names= "<<names;
    for (int i(0);i<length;i++)>
    {
        cout << "\nEnter "<<i+1<<" name: ";
        getline(cin,names[i]);
    }
    
    return 0;
}

Posted 24-Aug-15 0:25am

the_beginner

Updated 24-Aug-15 0:37am

_Asif_

v2

Add a Solution

2 solutions

Solution 1

My previous response was incorrect.

The issue is that cin only reads the next token up to the first whitespace character. In this case the whitespace is the end of line character(s) after the number, which need to be consumed before the first call to getline. You can clear the input buffer by calling cin.get().

Also, you cannot input a name containing spaces for the same reason (the space acts as a token delimiter), so you have to use getline to read the entire string.

Posted 24-Aug-15 0:49am

Richard MacCutchan

Updated 24-Aug-15 1:12am

v3

Comments

the_beginner 24-Aug-15 6:55am

thanks for ur answer.
but names[i] = new string; is giving compile time error:Invalid conversion from string* to char
By the way how come this code works if i use
cin >> names[i] instead of getline(cin,name) (but i can't enter names with spaces)

Richard MacCutchan 24-Aug-15 7:20am

Quite so; answer updated.

the_beginner 24-Aug-15 7:23am

Thanks Richard sir.

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CPallini · Accepted Answer · 2015-08-24T01:13:00

You have a problem with

C++

cin >> length;

leaving the line terminator in the buffer.

Input with cin is a bit tricky, anyway, a quick fix would be adding cin.ignore(); immediately before it to eat up the line terminator.

C++

cin >> length;
cin.ignore();

By the way, Richard gave you the good advice of using vector<string> instead of explicitely dynamically allocated array. As matter of fact, in your code you never release the allocated memory.