query is not filltering right way output

Question

0.00/5 (No votes)

See more:

SQL-Server-2008R2

Hello,

SQL

DECLARE @AssignedGroupIDs AS NVARCHAR(4000)

    SELECT
            @AssignedGroupIDs=  COALESCE(CONVERT(NVARCHAR, '1470, 1471, 1472, 1474, 1475, 1477, 1478, 1480') + ', ', '') + Convert(NVARCHAR,tbGroup.GroupID )
        FROM
            tbGroup,tbAssignedGroups
        WHERE
         tbGroup.GroupID = tbAssignedGroups.GroupID
            AND tbAssignedGroups.UserID = 2
            AND tbGroup.IsDeleted = 0

        select @AssignedGroupIDs

My output:

1470, 1471, 1472, 1474, 1475, , 1480

actual output must be:
1470, 1471, 1472, 1474, 1475, 1477, 1478, 1480

why output is not getting right ids.1477,1478 this ids skip why
i dont kw please how can i get right ids

Regrads
Sadhana.R.Belge

Posted 10-Sep-15 22:15pm

sadhana4

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Andy Lanng · Answer 1 · 2015-09-10T23:14:00

I can see several issues in this code, but I'll just deal with the question at hand:

For a start, NVARCHAR(4000) has not been the standard since SQL 2000 (maybe 2005). Use NVARCHAR(MAX) instead. It is variable length so is more efficient for strings of unknown length.

Without (4000) or (MAX) the default for NVARCHAR is (30). Hence CONVERT(NVARCHAR, '1470, 1471, 1472, 1474, 1475, 1477, 1478, 1480') = '1470, 1471, 1472, 1474, 1475, '

set the size of the NVARCHAR to fix the issue, but it is already a string so you don't even need to convert it.

Also: Coalesce is used to ignore null values. Your code excludes the possibility of nulls so this is pointless

This is what your code should look like to do what it is written to do:

SQL

DECLARE @AssignedGroupIDs AS NVARCHAR(4000)
 
    SELECT
            @AssignedGroupIDs=  '1470, 1471, 1472, 1474, 1475, 1477, 1478, 1480, ' + Convert(NVARCHAR,tbGroup.GroupID )
        FROM
            tbGroup,tbAssignedGroups
        WHERE
         tbGroup.GroupID = tbAssignedGroups.GroupID
            AND tbAssignedGroups.UserID = 2
            AND tbGroup.IsDeleted = 0
 
        select @AssignedGroupIDs

Perhaps this is not what you intended, but it's what you wrote.

If you need help using COALESCE then let mw know and I'll help you put together what you need.

Hope that helps ^_^
Andy