How to returns the expected value in the greet()

Question

1.00/5 (2 votes)

See more:

C#

public class Person {
  String name;

    public Person(String personName) {
            name = personName;
    }

    public String greet(String yourName) {
            return String.format("Hi %s, my name is %s", name, yourName);
    }
}

Posted 4-Nov-15 8:56am

veena15

Updated 4-Nov-15 9:13am

v3

Add a Solution

Comments

Richard Deeming 4-Nov-15 15:10pm

Click on the "Improve question" button and update your question with the missing details. Include a description of what the "expected value" is, and what value you're getting at the moment.

While you're at it, you might want to update your title so that it's not quite so rude. You're dealing with unpaid volunteers here; a terse demand that we correct your code isn't going to win you any friends.

veena15 4-Nov-15 15:18pm

I found this code on www.codewars.com . In order to sign up , I have given two codes to be corrected. I have corrected the first question. This is the second question. Hope someone will help me.

Richard Deeming 4-Nov-15 15:40pm

That's a better title, but you still haven't explained what the "expected value" is.

Richard Deeming 4-Nov-15 15:47pm

Guessing based on the variables: is it that the names are the wrong way round? Do you just need to swap the order of the name and yourName arguments in the String.format call?

Afzaal Ahmad Zeeshan 4-Nov-15 15:30pm

I can only say this is a bad coding design. Three different areas (or variables) for the same thing? Ok, name and personName can be left, but why yourName? Most programs are like this,


public String greet() {
   return String.format("Hello %s!", name);
}

Where name is already present in the object instance. For more please refer to documentation, http://docs.oracle.com/javase/7/docs/api/java/util/Formatter.html .

Sergey Alexandrovich Kryukov 4-Nov-15 15:51pm

Exactly. And the question makes no sense at all. There is no such thing as "expected" here.
—SA

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

ZurdoDev · Answer 1 · 2015-11-04T13:21:00

Solution 1

As mentioned in the comments, switch the variables in your String.Format. This is very easy to notice so I am unsure why you did not ask a question and why you are stuck on this.

Posted 4-Nov-15 13:21pm

ZurdoDev