Connection Return Fail

Question

0.00/5 (No votes)

See more:

How to make in this function
if connection = false
show message and close
MessageBoxA(0, "Failed to connect to Database!", "Error", MB_OK);
::ExitProcess(0);

if user, password, database = false
show message

C++

BOOL SQLCONNECT::Connect()
{
	GetPrivateProfileStringA("SQL", "User", "sa", this->m_szUser, 64, SQL_PATH);
	GetPrivateProfileStringA("SQL", "Password", "123456", this->m_szPassword, 64, SQL_PATH);
	GetPrivateProfileStringA("SQL", "Database", "MuOnline", this->m_szDatabase, 64, SQL_PATH);

	SQLHANDLE rgbValue;

	SQLAllocHandle(SQL_HANDLE_DBC, this->m_hEnviroment, &this->m_hConnection);
	SQLSetConnectAttr(this->m_hConnection, SQL_LOGIN_TIMEOUT, &rgbValue, 0);

	SQLRETURN Result = SQLConnect(this->m_hConnection, (SQLTCHAR *)this->m_szDatabase, SQL_NTS,
		(SQLTCHAR *)this->m_szUser, SQL_NTS, (SQLTCHAR *)this->m_szPassword, SQL_NTS);

	if (Result != SQL_SUCCESS && Result != SQL_SUCCESS_WITH_INFO)
	{
		SQLSMALLINT sRecord = 1, MsgLen;
		SQLTCHAR SqlState[6], SQLMsgError[SQL_MAX_MESSAGE_LENGTH];
		SQLINTEGER NativeError;

		if (SQLGetDiagRec(SQL_HANDLE_DBC, this->m_hConnection, sRecord, SqlState, &NativeError, SQLMsgError, sizeof(SQLMsgError), &MsgLen) != SQL_NO_DATA)
		{
			//cLog.ConsoleOutput("SQLSTATE:%s, Diagnosis:%s", SqlState, SQLMsgError);
		}

		return FALSE;
	}

	Result = SQLAllocHandle(SQL_HANDLE_STMT, this->m_hConnection, &this->m_hStmt);

	if (Result != SQL_SUCCESS && Result != SQL_SUCCESS_WITH_INFO)
	{
		return FALSE;
	}

	//cLog.ConsoleOutput("[SQL] Connection successfully");
	ReadyTableInstallation();
	return TRUE;
}

Posted 25-Dec-15 3:29am

diablo22

Updated 25-Dec-15 4:11am

Tomas Takac

v2

Add a Solution

Comments

Richard MacCutchan 26-Dec-15 4:17am

What is the problem?

diablo22 26-Dec-15 6:39am

the problem is that even if i use wrong User and Password it still connect
but if i change Database Name to other wrong, Application is going on looopss.
To solve this i need an check IF USERNAME = WRONG ERROR
IF PASSWORD = WRONG ERROR
IF DATABASE = WRONG ERROR
Simply fix, if all are correct = CONTINUED

Richard MacCutchan 26-Dec-15 7:04am

I do not think it is a sensible idea to store passwords as clear text in .INI files, and also have them hard coded in your program. That apart, I think the following statement is incorrect:


	if (Result != SQL_SUCCESS && Result != SQL_SUCCESS_WITH_INFO)

You only get the details of the failure state if the Result is equal to SQL_SUCCESS_WITH_INFO.

diablo22 26-Dec-15 8:05am

so can someone help me to fix this code, i must use information from .ini to get user password and database

Richard MacCutchan 26-Dec-15 10:41am

Fix what?As far as using .INI files for passwords, it is a very poor idea. There is no point in using passwords if you are going to store them in clear text in that file and also in your code. You should use a dialog box and get the user to enter the details. You should also not use the sa userid for normal database access.

As to the other issue, you just need to change yor if statement as suggested in my previous comment.

diablo22 26-Dec-15 11:22am

to change with what, give me idea, or please show me how it should be

diablo22 26-Dec-15 11:52am

i have in call function this:
void ReadySQLConnect()
{
//cSQL.Connect();
if (cSQL.Connect() == FALSE)
{
MessageBoxA(0, "Failed to connect to Database!", "Error", MB_OK);
::ExitProcess(0);
}

}
But it doesnt work, if my username or password are wrong doesnt show message this is what i want to fix, help me out here

Richard MacCutchan 26-Dec-15 13:28pm

I showed you above, you need to test if the Result is equal to SQL_SUCCESS_WITH_INFO.

diablo22 26-Dec-15 13:30pm

how to make this please provide me some code so i can test and fix this faster, thank

Richard MacCutchan 27-Dec-15 3:18am

How many times do I need to repeat this? A simple if statement is all that you need, and I even told you the name of the variable and the status code to test for.

diablo22 27-Dec-15 7:28am

so if(Result == SQL_SUCCESS_WITH_INFO)
{
Message(Same)
}
else
{
Message(Not Same Result)
}
It show message SAME..
But if i try like this:
if (Result == SQL_SUCCESS)
{
MessageBoxA(0, "Same!", "Error", MB_OK);
}
else
{
MessageBoxA(0, "Fail!", "Error", MB_OK);
}
Return FAIL , but even if i use correct information for login gives Fail

Richard MacCutchan 27-Dec-15 10:16am

You must look at the information that is provided when a failure status is received. Please make use of the documentation.

diablo22 27-Dec-15 10:17am

i do not understand more , i cant fix it myself please help me out to fix the code all day and night i search for solutions on internet, nowhere can find how to fix this

Richard MacCutchan 27-Dec-15 10:29am

See https://www.google.co.uk/search?q=SQL_SUCCESS_WITH_INFO&ie=UTF-8&oe=UTF-8&hl=en-gb&client=safari.

diablo22 27-Dec-15 10:45am

isnt that:
if (SQLGetDiagRec(SQL_HANDLE_DBC, this->m_hConnection, sRecord, SqlState, &NativeError, SQLMsgError, sizeof(SQLMsgError), &MsgLen) != SQL_NO_DATA)
{
//cLog.ConsoleOutput("SQLSTATE:%s, Diagnosis:%s", SqlState, SQLMsgError);
}

diablo22 27-Dec-15 10:56am

i guest the only problem comes only from here but nobody noticed it
SQLRETURN Result = SQLConnect(this->m_hConnection, (SQLTCHAR *)m_szDatabase, SQL_NTS, (SQLTCHAR *)m_szUser, SQL_NTS, (SQLTCHAR *)m_szPassword, SQL_NTS);

Here if User,Password,Database are wrong return false, check my other topic there doesnt has a problem with connection or infinity loops of application, but it doesnt read database tables
http://stackoverflow.com/questions/34481334/read-custom-string-from-file-in-connection

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Serkan Onat · Accepted Answer · 2015-12-29T11:32:00

The MSDN topic for that function clearly states how to handle return code under Diagnostics paragraph

SQLConnect()[^]

if Result equals to SQL_ERROR or SQL_SUCCESS_WITH_INFO this means that something went wrong

in order to get more info about that you should use SQLGetDiagRec[^] funtion

here is a aircode sample ,based on yours

C++

if (Result == SQL_ERROR || Result == SQL_SUCCESS_WITH_INFO)
{
	SQLSMALLINT sRecord = 1, MsgLen;
	SQLTCHAR SqlState[6], SQLMsgError[SQL_MAX_MESSAGE_LENGTH];
	SQLINTEGER NativeError;
 
	if (SQLGetDiagRec(SQL_HANDLE_DBC, this->m_hConnection, sRecord, SqlState, &NativeError, SQLMsgError, sizeof(SQLMsgError), &MsgLen) != SQL_NO_DATA)
	{
		//WARNING : use a proper comparision function here
		//written as below to explain what to do
		if(SqlState == "28000")
		{
			MessageBox(NULL,"Incorrect User Name Or Password","Error",0);
		}
		
		//check other state codes here
		
	}
 
	return FALSE;
}