How can i git rid of a god-object?

Question

1.00/5 (3 votes)

See more:

hi every one i'm stuck with an old code that was writen in c# a long time ago , my first task is to git rid of a god-object almost 10 000 lign , any one has an idea how should i proceed
thank u

What I have tried:

i've tried to analyse the code , and found out that the fonctonalities that are there , are used in almost 50 other classes , (note all the fonctions, each class uses at most 2 to 4 fontions of this class )

Posted 10-Feb-16 3:45am

Member 11736914

Updated 10-Feb-16 3:46am

v2

Add a Solution

Comments

Richard MacCutchan 10-Feb-16 10:14am

This is not a good question. We have no idea what a "god-object" might be, or why you feel the need to get rid of it.

Sergey Alexandrovich Kryukov 10-Feb-16 11:02am

This is a well-known anti-pattern. The question makes no sense, of course.
—SA

BillWoodruff 10-Feb-16 13:36pm

If the question makes no sense, how can it be an "anti-pattern ? ... There's a metaphysical infinite-regress lurking there :)

Sergey Alexandrovich Kryukov 10-Feb-16 14:21pm

This question is not the anti-pattern. It makes no sense just because there is an enormous number of ways to screw up things, and there cannot be an universal way of fixing them.
—SA

Member 11736914 12-Feb-16 10:40am

it's just a class that have a looot of fonctions and variables in it like i said 10000 lignes of code that was wreting by two people long time ago

Richard MacCutchan 12-Feb-16 10:56am

And?

Dave Kreskowiak 10-Feb-16 10:45am

I take it your calling a class with 10,000 lines of code a "god-object"?

Member 11736914 12-Feb-16 10:37am

not exacly ,every class uses a bit of fonctions that exist in this class , the code was writin in an old fashion way by wo gays that already retired :3 ,so there is no structur or architechtur behind

Dave Kreskowiak 12-Feb-16 10:41am

"Separation of Concerns".

You could break this class up into smaller classes, but you'll also end up rewriting most of the application along with it because all of the code is written to look in this one class.

Your best bet is to scrap the app and rewrite from scratch.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

cvogt61457 · Accepted Answer · 2016-02-10T04:33:00

Solve the problem in the same fashion that you would eat an elephant...
One bite at a time.

Analyze the problem and see which functionality can be moved to a smaller class.
Then repeat with another functionality.
Then repeat again
And again
And again
Until you are satisfied with what you have.

Note: Don't do this just to change the code. You have to justify making the change.
If it currently works, don't change it.