Getting data mismatch type error

Question

2.00/5 (1 vote)

See more:

here is my code.

C#

OleDbConnection con1 = new OleDbConnection(con);
       con1.Open();
       OleDbCommand cmd = new OleDbCommand("insert into reimb values('" +frm_date.Text + "','" + txt_todate.Text + "','"+dd1.SelectedItem.Value+"','"+people_num.Text+"','"+remarks.Text+"','"+bill_num.Text+"','"+bill_amount.Text+"')", con1);
       cmd.ExecuteNonQuery();
       Response.Write("Data saved");
       con1.Close();

it may be because of date but tell me what should I change..

What I have tried:

I have tried directly picking up the value from calendar and even tried by storing the selected date of calendar into a text box and saving the values of text box in ms-access but it still says data mismatch

Posted 21-Mar-16 3:50am

Member 12406991

Updated 21-Mar-16 4:05am

CHill60

v2

Add a Solution

Comments

Richard Deeming 21-Mar-16 10:32am

Everything you wanted to know about SQL injection (but were afraid to ask) | Troy Hunt[^]
How can I explain SQL injection without technical jargon? | Information Security Stack Exchange[^]
Query Parameterization Cheat Sheet | OWASP[^]

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CHill60 · Answer 1 · 2016-03-21T04:00:00

Firstly, do not use concatenated strings to construct your sql query. It leaves you open to SQL Injection.

Secondly, the fix for that is to use Parameterized Queries (see Query Parameterization Cheat Sheet - OWASP[^])

Parameterized queries will also help you to overcome problems like this.

Lastly - with Dates always use Unambiguous Date formats (see Jamie Thomson : Unambiguous date formats : T-SQL Tuesday #001[^]) which will also help you get over this problem

ZurdoDev · Answer 2 · 2016-03-21T04:02:00

It is because Access wants #'s around the dates, instead of single quotes. However, this method of concatenating strings together is a huge security risk called Sql injection. If you change your code to use Parameters instead this will work fine and be secure.

C#

cmd = new OleDbCommand("insert into reimb values(@field1, @field2, @field3");
cmd.Parameters.AddWithValue("@field1", frm_date.Text);
...

OriginalGriff · Answer 3 · 2016-03-21T04:05:00

Stop doing that!
Do not concatenate strings to build a SQL command. It leaves you wide open to accidental or deliberate SQL Injection attack which can destroy your entire database. Use Parametrized queries instead.
Process your user inputs into appropriate datatypes - use DateTime.TryParse to convert strings to DateTime values for example - and pass those "real" values directly via parameters. You should find your problem disappears at the same time.

BTW: It's a very good idea to list the columns you are planning on insertign teh values to in your INSERT statement: that way chances to your DB don;t cause your code to craash or worse enter data in the wrong columns...

SQL

INSERT INTO MyTable (Column1Name, Column2Name) VALUES (....

Getting data mismatch type error

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0