I want to check whether this code for arranging nos. In ascending order written in C++ is correct? If wrong pls correct it.

Question

1.00/5 (3 votes)

See more:

I want to check whether this code for arranging nos. in ascending order written in c++ is correct? If wrong pls correct it.

What I have tried:

C++

#include<iostream.h>
#include<conio.h>
void main()
{
	int i,j=1,n,temp,a[10];
	clrscr();
	cout<<"enter element lm"<<endl;

	cin>>n;
	cout<<"enter elements";
	for(i=0;i<n;++i)
		cin>>a[i];

	for(i=0;i<n,j<=n;i++,j++)
	{
		if(a[i]<=a[i+j])
				a[i]=a[i];
			else
				{
					temp=a[i];
					a[i]=a[i+1];
					a[i+1]=temp;
				}
			}
			cout<<"new array"<<endl;
			for(i=0;i<n;++i)
				cout<<a[i]<<"\n";
			getch();
		}

Posted 11-May-16 4:42am

Member 12517343

Updated 13-May-16 2:28am

Patrice T

v7

Add a Solution

Comments

Patrice T 11-May-16 10:52am

At least indicate the sort method it is supposed to be !
This code is not sorting at all.

2 solutions

Solution 2

Quote:
I want to check whether this code for arranging nos. in ascending order wriiten in c++ is correct?

This is your duty to check if your code is correct ! Use the debugger.
By the way your code is so far away from 'correct' that is it bot even possible to guess what you tried to do.

You should learn to use the debugger as soon as possible. It is time to see your code executing and ensuring that it does what you expect.

The debugger allow you to follow the execution line by line, inspect variables and you will see that there is a point where it stop doing what you expect.
Debugger - Wikipedia, the free encyclopedia[^]
Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]

Quote:
PLZZ MAHN IF NOT CORRECT WRITE A DIFFERENT CODE FOR ME....

Being able to check own code and detect fails is the most basic skill requested from a programmer. Better start now.

Posted 11-May-16 10:48am

Patrice T

Updated 12-May-16 5:10am

v3

Comments

[no name] 12-May-16 10:41am

PLZZ MAHN IF NOT CORRECT WRITE A DIFFERENT CODE FOR ME....

Patrice T 12-May-16 12:07pm

Hi, looks like you don't like my answer.

If you look under your question, you will see I ask for information and you didn't even respond.

The fist thing, when you ask a question, is to give proper information.
-----------------
Simply giving a try to your code would have told you that your code is not correct. Your question let us think you didn't even try. This is rather rude to helpers.
-----------------
You have been given advices, did you try ?
-----------------
Did you understood that we don't write code on request just because you need it.
We help you correct your code, but not if a complete rewrite is needed.

Sergey Alexandrovich Kryukov 12-May-16 11:26am

Please see new question by this inquirer and the comments, rude from the very beginning, even in the text of the question, apparently referring to your answer.

I think this person is asking for cancellation of the account.

http://www.codeproject.com/Questions/1099673/Here-is-a-trial-of-mine-for-arranging-array-in-asc.

[EDIT]

The past have been removed. The inquirer got 5 abuse reports on the account and asked the question again, more nicely, but that question also was removed...

—SA

Patrice T 12-May-16 12:11pm

thank you for report.

[no name] 14-May-16 0:49am

[Bad word, profanity, foul language, aggression — removed, the inquirer's account disabled — SA]

Patrice T 14-May-16 1:05am

What about learning English too ?

[no name] 13-May-16 0:59am

[Bad word, profanity, foul language, aggression — removed, the inquirer's account disabled — SA]

Patrice T 13-May-16 1:45am

Nice to never see you again.

Sergey Alexandrovich Kryukov 14-May-16 9:59am

I just checked up — the account is disabled, so I removed bad words from the posts, even deleted ones — there is no place for this stuff here. Good riddance.
—SA

Patrice T 14-May-16 13:42pm

HI SA,
I see another message in my notifications, did you change it ?
I am not used enough to language like this OP to have the reflex of reporting.
He was just upset that nobody gave him a full blowup solution that he could paste in its HomeWork.

Sergey Alexandrovich Kryukov 14-May-16 13:59pm

As I understand, each time one edits the comment, the related notifications are sent. First time, I commented before I found out that the account is disabled. I think that there cannot be any excuses of such language and behavior, no excuses in principle. No matter what is the reason for being "upset".
—SA

Patrice T 14-May-16 14:10pm

Agreed

[no name] 13-May-16 6:05am

[Bad word, profanity, foul language, aggression — removed, the inquirer's account disabled — SA]

Patrice T 13-May-16 8:27am

LOL

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Accepted Answer · 2016-05-11T05:04:00

Well...no.
This is your homework, and that means you are supposed to test it yourself.
It's important: it's a big part of the developement cycle:

0) Design
1) Code
2) Test
3) Debug

At any stage, you can go back to an earlier one as a result.
The last two are interrelated to a fair degree, and are often the most time consuming part of the exercise.

So, come up with some sets of test data:

Random values
All the same value
1 value
2 different values
All sorted correctly
All in reverse order
All correct except the last one, which is the lowest.
All correct except the first one, which is the highest

And try it with each set. Does it produce the right output? If so, it passes (unless you can think of more test sets).
If not - time to start looking at the code with the debugger and examine exactly what is happening!

Yes, we could do that for you - but this is a skill. And like all skills you only develop it by using it - and it's a lot easier to develop it on trivial exercises like this than on a 100,000 line application! :laugh:
Give it a try: see what you can find out.

I want to check whether this code for arranging nos. In ascending order written in C++ is correct? If wrong pls correct it.

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0

Existing Members

...or Join us