Don't overwrite file uploaded through fileupload control

Question

0.00/5 (No votes)

See more:

i dont want to overwrite file when the folder exists the same file name..please help me

What I have tried:

C#

foreach (HttpPostedFile postedFile in FileUpload1.PostedFiles)
    {
        string filename = Path.GetFileName(postedFile.FileName);
        postedFile.SaveAs(Server.MapPath("SiteLayout/" + filename));
        var extension = Path.GetExtension(filename);
        var nameWithoutExtension = Path.GetFileNameWithoutExtension(filename);
        var i = 1;
        while (File.Exists("SiteLayout/" + filename))
        {
            filename = nameWithoutExtension.Trim() + " (" + i + ")" + extension;
            i++;
        }

        using (Stream fs = postedFile.InputStream)
        {
            using (BinaryReader br = new BinaryReader(fs))
            {
                using (SqlConnection con = new SqlConnection(WebConfigurationManager.ConnectionStrings["myConnectionString"].ConnectionString))
                {
                    string query = "insert into Site_Layout (ID,File_Path,Image_Path) values (@ID, @File_Path,@Image_Path)";
                    using (SqlCommand cmd = new SqlCommand(query))
                    {
                        cmd.Connection = con;
                        cmd.Parameters.AddWithValue("@File_Path", filename);
                        cmd.Parameters.AddWithValue("@Image_Path", "SiteLayout/" + filename);
                        cmd.Parameters.AddWithValue("@ID", TextBox1.Text);
                        con.Open();
                        cmd.ExecuteNonQuery();
                        Label26.Visible = true;
                        Label26.Text = "File Uploaded Successfully";
                        con.Close();
                    }
                }
            }
        }
    }
    Label26.Visible = true;
   Label26.Text = "File Uploaded Successfully";

}

Posted 3-Jul-16 4:40am

Member 11848664

Updated 3-Jul-16 5:36am

Patrice T

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2016-07-03T04:54:00

The problem is that when a user uploads a file, the name is quite likely to conflict with a different user's file of the same name - loads of people use the same set f file names every day!

The way I get round this is to store the user and the user file name in a DB, and store the file itself as a Guid filename: bb5a84b2-f9b6-47ae-98e1-25df6344788a.upload or similar. I then store the Guid in the DB so that I can cross-reference the file name the user wants to the "actual" file name in the file system.
When a user requests the file, i do it via an ASPX and a query string which contains the Guid value:

ASP.NET

<%@ Page Language="C#" AutoEventWireup="true" CodeFile="FileTransferDownload.aspx.cs" Inherits="FileTransferDownload" %>

<%  
    // Send a download file to the client given the filename.    
    string guid = Request.QueryString["file"];
    string fileName = "ERROR";
    byte[] data = new byte[] { 0, 0, 0, 0 };
    string strCon = System.Web.Configuration.WebConfigurationManager.ConnectionStrings["DownloadDatabase"].ConnectionString;
    using (System.Data.SqlClient.SqlConnection con = new System.Data.SqlClient.SqlConnection(strCon))
        {
        con.Open();
        string strcmd = "SELECT [iD] ,cn.[fileName],[description] ,[dataContent] ,[version] " +
                        "FROM dlContent cn " +

                        "WHERE cn.iD=@ID";
        using (System.Data.SqlClient.SqlCommand cmd = new System.Data.SqlClient.SqlCommand(strcmd, con))
            {
            cmd.Parameters.AddWithValue("@ID", guid);
            using (System.Data.SqlClient.SqlDataReader r = cmd.ExecuteReader())
                {
                if (r.Read())
                    {
                    fileName = (string) r["filename"];
                    data = (byte[]) r["dataContent"];
                    }
                }
            }
        }
    Response.Clear();
    Response.AddHeader("Cache-Control", "no-cache, must-revalidate, post-check=0, pre-check=0");
    Response.AddHeader("Pragma", "no-cache");
    Response.AddHeader("Content-Description", "File Download");
    Response.AddHeader("Content-Type", "application/force-download");
    Response.AddHeader("Content-Transfer-Encoding", "binary\n");
    Response.AddHeader("content-disposition", "attachment;filename=" + fileName);
    Response.BinaryWrite(data);
    Response.End();  
%>

Member 11848664 · Answer 2 · 2016-07-03T05:03:00

Solution 2

this is not the solution to store the file name in db...
i just want to stop overwrite file which already exist in folder with the same name..
i use code but dont know why it is not working...

Posted 3-Jul-16 5:03am

Member 11848664

Comments

raju melveetilpurayil 4-Jul-16 12:36pm

Put the Break points and debug your code.