If statment not working. Help!

Question

0.00/5 (No votes)

See more:

Hiya peeps!

I have a problem. I have two IF statments but neither are working.

Here is the code I have used.

Code:

Private Sub ViewUser_Load(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles MyBase.Load
    Try

        Dim connection As New MySqlConnection("server=" & My.Settings.MysqlHost & ";user id=" & My.Settings.MysqlUsername & "; password=" & My.Settings.MysqlPassword & "; port=3306; database=" & My.Settings.MysqlDatabase & "; pooling=false")
        connection.Open()

        Dim usersql As New MySqlCommand("SELECT * FROM `accounts` WHERE `id` = '" & My.Settings.VUID & "' LIMIT 1", connection)
        usersql.ExecuteNonQuery()

        Dim userreader = usersql.ExecuteReader()

        While (userreader.Read())
            Dim name As String = userreader.GetString(1) & " " & userreader.GetString(2)
            Dim accounttype = ""
            Dim activity = userreader.GetString(8)

            accname.Text = StrConv(name, VbStrConv.ProperCase)
            accid.Text = userreader.GetString(0)
            accemail.Text = userreader.GetString(3)
            accusername.Text = userreader.GetString(4)

            If userreader.GetString(9).Equals(1) Then
                accounttype = "Tenant"
                setpaid.Hide()
                setunpaid.Hide()
            ElseIf userreader.GetString(9).Equals(2) Then
                accounttype = "Landlord"
            End If

            If activity.Equals(1) Then
                accactive.Text = "Suspended"
                suspenduser.Hide()
            Else
                accactive.Text = "Active"
                unsuspend.Hide()
            End If

            acctype.Text = accounttype
            usersql.Dispose()
        End While
    Catch ex As MySqlException
        MessageBox.Show(ex.Message)
    End Try
End Sub

That is the whole code snippet. Everything is working. But this;

Code:

If userreader.GetString(9).Equals(1) Then
    accounttype = "Tenant"
    setpaid.Hide()
    setunpaid.Hide()
ElseIf userreader.GetString(9).Equals(2) Then
    accounttype = "Landlord"
End If

If activity.Equals(1) Then
    accactive.Text = "Suspended"
    suspenduser.Hide()
Else
    accactive.Text = "Active"
    unsuspend.Hide()
End If

If anyone has any ideas please help!

Many thanks,

James.

Posted 26-Sep-10 4:46am

jamesxg1

Add a Solution

Comments

Henry Minute 26-Sep-10 13:48pm

The x should be replaced by whatever number you are currently using, 9 in the code you posted.

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Henry Minute · Answer 1 · 2010-09-26T04:57:00

Solution 1

Well the most obvious thing is that you are reading a string and trying to check if it is equal to an integer, which it never will be.

Either test for .Equals("1") or use GetInt(x).Equals(1).

Posted 26-Sep-10 4:57am

Henry Minute

Comments

jamesxg1 26-Sep-10 11:01am

Hiya,

Thank you for a very prompt response, I was just wondering how I would use this? Also what do I replace the 'x' with?

Many many thanks,

James.

SLDWorks · Answer 2 · 2010-09-28T20:54:00

Solution 3

you might also want to use a select case, instead of nested if statements. combine this with a ctype to convert an string into an integer.

SQL

Select Case CType(userreader.GetString(9), Integer)

    Case 1

    Case 2

    Case 9

    Case Else

End Select

Posted 28-Sep-10 20:54pm

SLDWorks

Comments

Dalek Dave 29-Sep-10 3:38am

I would have suggested the same, much easier to control.

Simon_Whale · Answer 3 · 2010-09-28T04:14:00

Solution 2

Adding to the previous answer, I would put break points on the if statements and step through the code.

This way you can see what is happening or changing line by line.

Posted 28-Sep-10 4:14am

Simon_Whale