How to fill combobox in VB.NET from msaccess

Question

0.00/5 (No votes)

See more:

I cannot understand why its not giving me the out put. There is data in the described table and even the dataset is getting populated I saw that in debugger mode. But, the value member and display member are not getting populated. I cannot understand why.

What I have tried:

Private Sub frmItemEntry_Load(ByVal sender As System.Object, ByVal e As System.EventArgs) Handles MyBase.Load
        Dim strSql As String
        strSql = "Select UID, UnitName from UnitofMeasurement"
        Try
            conn.Open()
            With com
                .CommandType = CommandType.Text
                .CommandText = strSql
                .Connection = conn
            End With
            adp.SelectCommand = com
            adp.Fill(ds)
            adp.Dispose()
            com.Dispose()
            conn.Close()
            With cmbUnitOfMeasure
                .DataSource = ds.Tables("UnitofMeasurement")
                .ValueMember = "UID"
                .DisplayMember = "UnitName"
            End With
            
        Catch ex As Exception
            MsgBox(ex.Message)
        End Try
        conn.Close()
    End Sub

Posted 15-Sep-16 2:05am

Member 12741660

Updated 16-Sep-16 0:59am

Patrice T

v3

Add a Solution

Comments

Richard MacCutchan 15-Sep-16 8:08am

You have two different spellings: UnitofMeasurement and UnitOfMeasurement.

Member 12741660 15-Sep-16 8:32am

Made the correction no use. the name of table is UnitofMeasurement.

2 solutions

Solution 1

~~You cannot use a DataTable as the DataSource for a ComboBox, see ComboBox.DataSource Property (System.Windows.Forms)[^].~~

Karthik showed me the error of my way(s). :(

Posted 15-Sep-16 3:17am

Richard MacCutchan

Updated 15-Sep-16 23:44pm

v2

Comments

Karthik_Mahalingam 17-Sep-16 7:56am

5 for your humbleness.

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Karthik_Mahalingam · Accepted Answer · 2016-09-15T05:35:00

Solution 2

try this

VB

cmbUnitOfMeasure.ValueMember = "UID"
cmbUnitOfMeasure.DisplayMember = "UnitName"
cmbUnitOfMeasure.DataSource = ds.Tables(0)

Posted 15-Sep-16 5:35am

Karthik_Mahalingam

Comments

Richard MacCutchan 15-Sep-16 12:03pm

That is the same as OP already has coded, but ComboBox does not accept a DataTable as DataSource.

Karthik_Mahalingam 15-Sep-16 13:49pm

HI Richard
it will work, i did that many times.
refer this : http://stackoverflow.com/a/12495086

the difference in my code is declare the valuemember and displaymember property first and then assign the datasource to it..
and also, ds.Tables(0) , since [ ds.Tables("UnitofMeasurement") ] this code is not convincing...

Richard MacCutchan 15-Sep-16 15:00pm

If you already did it then you should post the full code. I tried a very simple example and it did not work.

Karthik_Mahalingam 15-Sep-16 15:26pm

Check this.

Dim dt As DataTable = New DataTable
dt.Columns.Add("UID")
dt.Columns.Add("UnitName")
dt.Rows.Add(1, "a")
dt.Rows.Add(2, "b")
dt.Rows.Add(3, "c")
dt.Rows.Add(4, "d")

cmbUnitOfMeasure.DataSource = dt
cmbUnitOfMeasure.ValueMember = "UID"
cmbUnitOfMeasure.DisplayMember = "UnitName"

Richard MacCutchan 16-Sep-16 5:12am

Thanks for the reply, I just tried the following:


Dim table1 As DataTable = New DataTable("UnitOfMeasurement")
table1.Columns.Add("UID")
table1.Columns.Add("UnitName")
table1.Rows.Add(1, "Inch")
table1.Rows.Add(2, "Foot")
table1.Rows.Add(3, "Yard")
table1.Rows.Add(4, "Furlong")
' Create a DataSet. Put table in it.
Dim ds As DataSet = New DataSet("Length")
ds.Tables.Add(table1)
' Visualize DataSet.
With ComboBox1
    .DataSource = ds.Tables("UnitOfMeasurement")
    .ValueMember = "UID"
    .DisplayMember = "UnitName"
End With

which worked first time. I cannot understand how it did not work before, when my code was (AFAIR) the same.

Karthik_Mahalingam 16-Sep-16 5:16am

so now you have to agree ComboBox accepts DataTable as DataSource
:-)

Richard MacCutchan 16-Sep-16 5:43am

Absolutely. And I am so annoyed with myself for not getting the original code to work; poor debugging on my part.

Karthik_Mahalingam 16-Sep-16 8:09am

Sometimes it happens..

Richard MacCutchan 16-Sep-16 8:19am

In my case, too often.

Karthik_Mahalingam 16-Sep-16 9:20am

:)

Member 12741660 16-Sep-16 3:46am

you are right. I did that myself too but forgot to update here. Anyways thanks. Instead of using dataset I used the instance of datatable. Still am curious why dataset did not work.

Karthik_Mahalingam 16-Sep-16 3:59am

Hmm good

Member 12741660 16-Sep-16 8:13am

But why the instance of dataset did not work I still do not get it.

Richard MacCutchan 16-Sep-16 8:20am

See my sample above, very similar to your code, which works.

Karthik_Mahalingam 16-Sep-16 9:21am

i suspect the problem with this ds.Tables("UnitofMeasurement")