How to remove elements from array list in C#

Question

0.00/5 (No votes)

See more:

After removing elements from arraylist,its not effecting to arraylist.
when retrieving the arraylist elements ,then again its showing the deleting elements.
How to reslove this problem?

What I have tried:

C#

public class BaseEmployee
    {
        public int Id;
        public string Name;
    }

    public class Employee : BaseEmployee
    {
        public string Address;



        public Object Add()
        {

            Employee employeeDetail = new Employee();
            Console.Write("Employee Id:");
            employeeDetail.Id = int.Parse(Console.ReadLine());

            Console.Write("Employee Name:");
            employeeDetail.Name = Console.ReadLine();
            Console.Write("Employee Address:");
            employeeDetail.Address = Console.ReadLine();
            return employeeDetail;

        }

        static void Main(string[] args)
        {

            ArrayList arraylist = new ArrayList();
          


            Employee employeeDetails = new Employee();

            bool p = true;

            while (p)
            {

                Console.WriteLine("Employee Record Management System\n");
                Console.WriteLine("\n1)Add");
                Console.WriteLine("\n2)Edit");
                Console.WriteLine("\n3)Delete");
                Console.WriteLine("\n4)Dispaly");
                Console.WriteLine("\n5)Exit");
                Console.Write("\n Select opertaion:");
                int Option = int.Parse(Console.ReadLine());

                switch (Option)
                {
                    case 1:
                        arraylist.Add(employeeDetails.Add());

                        break;


                    case 4:
                        foreach (Object obj in arraylist)
                        {

                            Employee emp = obj as Employee;
                            Console.Write("{0}\t\t{1}\t\t{2}", emp.Id, emp.Name, emp.Address);
                            Console.Write("\n");
                            //Console.WriteLine(obj);
                        }


                        break;
            case 3:Console.Write("Enter  Employee Id:");
                        int EId = int.Parse(Console.ReadLine());
                        foreach(Object obj in arraylist)
                        {
                            Employee emp = obj as Employee;
                            if(EId==emp.Id)
                            {

                                arraylist.Remove(emp.Id);
                                arraylist.Remove(emp.Name);
                                arraylist.Remove(emp.Address);
                               

                            }
                        }

                          break;



                }

            }
        }

    }
}

Posted 12-Oct-16 22:03pm

Member 12675499

Updated 13-Oct-16 6:32am

Add a Solution

3 solutions

Solution 3

I suggest you to use List<Employee> instead of ArrayList.
You'll avoid using Object (casting it every time) and your code will be easier to read.
Moreover you'll be able to use the method RemoveAll:

arraylist.RemoveAll(emp => emp.Id == EId);

I rewritten your code fragment, so you can evaluate my advice:

C#

public class BaseEmployee
    {
        public int Id;
        public string Name;
    }
 
    public class Employee : BaseEmployee
    {
        public string Address;

        public static Employee Add()
        {
 
            var employeeDetail = new Employee();
            Console.Write("Employee Id:");
            employeeDetail.Id = int.Parse(Console.ReadLine());
 
            Console.Write("Employee Name:");
            employeeDetail.Name = Console.ReadLine();
            Console.Write("Employee Address:");
            employeeDetail.Address = Console.ReadLine();
            return employeeDetail;
 
        }
 
        static void Main(string[] args)
        {

            var arraylist = new List<Employee>();
          
            //Employee employeeDetails = new Employee();
 
            bool p = true;
 
            while (p)
            {
 
                Console.WriteLine("Employee Record Management System\n");
                Console.WriteLine("\n1)Add");
                Console.WriteLine("\n2)Edit");
                Console.WriteLine("\n3)Delete");
                Console.WriteLine("\n4)Dispaly");
                Console.WriteLine("\n5)Exit");
                Console.Write("\n Select operation:");
                int Option = int.Parse(Console.ReadLine());
 
                switch (Option)
                {
                    case 1:
                        arraylist.Add(Employee.Add());
 
                        break;
 

                    case 4:
                        foreach (Employee emp in arraylist)
                        {
 
                            //Employee emp = obj as Employee;
                            Console.Write("{0}\t\t{1}\t\t{2}", emp.Id, emp.Name, emp.Address);
                            Console.Write("\n");
                            //Console.WriteLine(obj);
                        }
 

                        break;
                    case 3:
                        Console.Write("Enter  Employee Id:");
                        int EId = int.Parse(Console.ReadLine());
                        
                        arraylist.RemoveAll(emp => emp.Id == EId);
                        
                        break;
                }
 
            }
        }
 
    }

Bye

Posted 13-Oct-16 6:32am

Alfonso Gag.

Solution 2

If you're going to be changing the list, you can't do it inside a foreach loop.

My advice is to use linq to find it, and then remove it if found.

C#

var found = arraylist.Where(x=>x.Id == EId).FirstOrDefault();
if (found != null)
{
    arraylist.Remove(found);
}

Posted 13-Oct-16 1:13am

#realJSOP

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Mehdi Gholam · Accepted Answer · 2016-10-12T22:06:00

Solution 1

You should remove the object not the properties of the object :

C#

...
          arraylist.Remove(emp);
...

Posted 12-Oct-16 22:06pm

Mehdi Gholam

Comments

F-ES Sitecore 13-Oct-16 4:21am

I agree, not sure if you'll need arraylist.Remove(obj) rather than "emp" though. You'll also need a "break;" after the Remove line.

Mehdi Gholam 13-Oct-16 4:24am

Presumably emp is not null after the cast so you are ok in the if block, but yes!

CPallini 13-Oct-16 4:23am

5.

Mehdi Gholam 13-Oct-16 4:24am

Cheers!