Please check the error

Question

1.00/5 (1 vote)

See more:

can anyone help me please?
I was unable to display the data.
please correct the try and catch statement

What I have tried:

C#

private void btn_Save_Click(object sender, EventArgs e)
        {
            string date = dateTimePicker1.Text;
            string taskName = txt_TaskName.Text;
            string notes = txt_Notes.Text;

            if(txt_TaskName.Text!="" && txt_Notes.Text!="")
            {
                try
                {
                    String str = "Data Source=DESKTOP-CCDDCMC\\SQLEXPRESS;Initial Catalog=master;Integrated Security=True";
                    String query = "insert into tbl_Task(t_taskName,t_date,t_notes) values('" + taskName + "','" + date + "','" + notes + "')";
                    SqlConnection con = new SqlConnection(str);
                    SqlCommand cmd = new SqlCommand(query, con);

                    con.Open();
                    int result = cmd.ExecuteNonQuery();
                    if (result > 0)
                    {
                        MessageBox.Show("Data Saved Successfully.....");
                        DisplayData();

                        txt_TaskName.Text = "";
                        txt_Notes.Text = "";
                        dateTimePicker1.Text = "";
                    }

                    con.Close();
                }
                catch (Exception)
                {
                    MessageBox.Show("error");
                }
                
            }
            else
            {
                MessageBox.Show("Please Provide Details!");
            }      
        }

Posted 21-Oct-16 11:07am

Member 12795706

Updated 21-Oct-16 22:51pm

Wendelius

v3

Add a Solution

Comments

Suvendu Shekhar Giri 21-Oct-16 17:20pm

Sharing the whole program or application will not help us understanding your issue.
Which portion of your code has issue?

[no name] 21-Oct-16 17:21pm

Learn to use the debugger.

ChrisHD22 21-Oct-16 17:41pm

As NotPolliticallyCorrect said, use the debugger to know which lines of code are creating conflict and what is the error thrown. Then you should post the question saying what is the problem occurring in your project.

Richard MacCutchan 22-Oct-16 4:26am

Stop using string concatenation on your INSERT statement and use proper parameterised queries. At the very least you will be able to see what is happening better.

Karthik_Mahalingam 27-Oct-16 1:45am

error message?

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Patrice T · Answer 1 · 2016-10-21T11:58:00

Quote:
Not displaying data which I stored using database in C#

Here you 2 questions.
Either ypu fail to recover the data, or you fail to display the data.
The debugger will show what your code does, it will help you to spot the problem.

You should learn to use the debugger as soon as possible. Rather than guessing what your code is doing, It is time to see your code executing and ensuring that it does what you expect.

The debugger allow you to follow the execution line by line, inspect variables and you will see that there is a point where it stop doing what you expect.
Debugger - Wikipedia, the free encyclopedia[^]
Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]

The debugger is here to show you what your code is doing and your task is to compare with what it should do.

cvogt61457 · Answer 2 · 2016-10-21T12:40:00

Here's a small fix that will show what the error is.
You are only showing in the message box the word "error"
Show the error message from the exception.
However, you need to get to know your debugger.

The debugger is one of the most important tools you have.

C#

try
{
    // your code here
}
catch (Exception ex)
{
    MessageBox.Show(ex.Message);
}

Wendelius · Answer 3 · 2016-10-21T22:51:00

Few points:
- You don't dispose Sql* objects, this should be done when they are no longer needed
- You don't use parameters, so you're vulnerable to SQL injection and type conversion problems
- you hide the actual exception and just show that something went wrong, instead show the actual reason

I suggest going through Properly executing database operations[^] in which these problems are addressed.

Please check the error

3 solutions

Solution 1

Solution 2

Solution 3

Add your solution here

Preview 0