Syntax error in INSERT into statement..................

Question

0.00/5 (No votes)

See more:

C#

Try
       Dim con As New OleDbConnection
       Dim cmd As New OleDbCommand
       Dim ddt As New OleDbDataAdapter
       Dim dtd As New DataSet
       con.ConnectionString = ("Provider=Microsoft.Jet.OLEDB.4.0;Data Source=D:\Ticket.mdb")
       cmd.CommandText = "INSERT INTO user VALUES('" & TextBox1.Text & "' , '" & TextBox2.Text & "')"
       cmd.Connection = con
       con.Open()
       cmd.ExecuteNonQuery()
       MessageBox.Show("New User Created", "New User", MessageBoxButtons.OK, MessageBoxIcon.Information)
   Catch
       MsgBox("User Already Created")
   End Try

What I have tried:

Nothing....Just getting this error again and again.....my code seems to be right

Posted 21-Oct-16 21:32pm

Member 12805540

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Mehdi Gholam · Answer 1 · 2016-10-21T21:38:00

Solution 1

When you omit the column names make sure you insert the data in the column order of the table, better still use the column names in the statement :
SQL INSERT INTO Statement[^]

Posted 21-Oct-16 21:38pm

Mehdi Gholam

Wendelius · Answer 2 · 2016-10-21T22:45:00

As explained in Number of query values and destination fields are not the same.[^] you need to specify the target columns. Otherwise you will have problems when columns are changed, added, or the order changes.

Another potential error source is the fact that you're not using parameters. If the data in the text box has an apostrophe (') then your statement will fail. Not to mention the problems for the fact that you're vulnerable to SQL injections. So make use of OleDbParameter Class (System.Data.OleDb)[^]

As a side note when you catch the exception, you assume that the exception happened because the record already exists. This is just one of many potential reasons for the statement to fail. So the best option would be to show the real message for the exception. I really suggest going through Properly executing database operations[^]