Error stack over flow error

Question

0.00/5 (No votes)

See more:

C#

public class Columns
    {
        public List<Columns> rCol { set; get; }
        Columns mCurrentColumn1;
        public Columns()
        {
            rCol = new List<Columns>();
        }
       
        public string   ColName       { set; get; }
        public string   Value         { set; get; }
        
        public Columns AddColumn(string ColName, String Value)
        {
            mCurrentColumn1 = new Columns();
            mCurrentColumn1.ColName = ColName;
            mCurrentColumn1.Value = Value;
            rCol.Add(mCurrentColumn1);

            return mCurrentColumn1;
        }
    }
	
For AddColumn is written Class as AddColumn.cs as below
	
public class AddColumn
    {
        public List<AddColumn> rCol1 { set; get; }
        AddColumn mCurrentColumn2;

        public AddColumn()
        {
            rCol1 = new List<AddColumn>();
        }
        public void AddCol(Columns AddCol)
        {
            mCurrentColumn2 = new AddColumn();
            mCurrentColumn2.AddCol(AddCol);
            rCol1.Add(mCurrentColumn2);
        }
    }	
	
For AddRow is written Class as AddRow.cs as below
	
public class AddRow
    {
        public List<AddRow> rCol2 { set; get; }
        AddRow mCurrentColumn3;

        public AddRow()
        {
            rCol2 = new List<AddRow>();
        }

        public void AddColumn(AddColumn AddCol)
        {
            mCurrentColumn3 = new AddRow();
            mCurrentColumn3.AddColumn(AddCol);
            rCol2.Add(mCurrentColumn3);
        }
    }	
	
	

public partial class Default : System.Web.UI.Page
{
	Columns Col = new Columns();
	AddColumn ACol = new AddColumn();
	AddRow ARow = new AddRow();	
	protected void Page_Load(object sender, EventArgs e)
	{
		Col.AddColumn("MainHeader1", "State Bank of India");
		Col.AddColumn("MainHeader2", "State Bank of India");
		Col.AddColumn("MainHeader3", "State Bank of India");

		ACol.AddCol(Col);
		ARow.AddColumn(ACol);
	}	
}

When i run program in AddRow.cs class showing error as
"An unhandled exception of type 'System.StackOverflowException' occurred in"

What I have tried:

C#

public partial class Default : System.Web.UI.Page
{
	Columns Col = new Columns();
	AddColumn ACol = new AddColumn();
	AddRow ARow = new AddRow();	
	protected void Page_Load(object sender, EventArgs e)
	{
		Col.AddColumn("MainHeader1", "State Bank of India");
		Col.AddColumn("MainHeader2", "State Bank of India");
		Col.AddColumn("MainHeader3", "State Bank of India");

		ACol.AddCol(Col);
		ARow.AddColumn(ACol);
	}	
}

Posted 17-Nov-16 22:36pm

Darshan E Ksheerasagar

Updated 17-Nov-16 23:01pm

Er. Puneet Goel

v2

Add a Solution

Comments

F-ES Sitecore 18-Nov-16 4:56am

You get a stack overflow exception when your code enters an infinite loop like

void SomeFunction()
{
SomeFunction();
}

Step through your code line by line in the debugger and it should become clear where your infinite loop is.

2 solutions

Solution 1

This class is recursive:

C#

public class AddRow
{
    public List<AddRow> rCol2 { set; get; }
    AddRow mCurrentColumn3;
    
    public AddRow()
    {
        rCol2 = new List<AddRow>();
    }
    
    public void AddColumn(AddColumn AddCol)
    {
        mCurrentColumn3 = new AddRow();
        mCurrentColumn3.AddColumn(AddCol);
        rCol2.Add(mCurrentColumn3);
    }
}

The class has a member variable of the class type (mCurrentColumn3). This won't work when the class has a constructor (the initial constructor calls the constructor of the member which calls the constructors of the members and so on).

When there is no constructor or it does nothing, the error is sourced by calling mCurrentColumn3.AddColumn() in the AddColumn() function which calls the function itself again.

Both would continue infinite but are stopped when the stack overflows.

Solution: Rethink your class design.

Posted 17-Nov-16 22:55pm

Jochen Arndt

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Midi_Mick · Accepted Answer · 2016-11-17T23:01:00

You have 2 places where this will occur. In your AddColumn.AddCol method, and your AddRow.AddColumn method - and both for the same reason. Lets just look at the AddColumn.AddCol method:

C#

public void AddCol(Columns AddCol)
{
    mCurrentColumn2 = new AddColumn();
    mCurrentColumn2.AddCol(AddCol);
    rCol1.Add(mCurrentColumn2);
}

First line creates a new AddColumn.
2nd Line then calls AddCol which then
   First line creates a new AddColumn
   2nd Line then calls AddCol which then
      First line creates a new AddColumn

and so on - until the stack fills up with too many calls, and the error is generated. The AddRow.AddColumn method does exactly the same thing.