Please clarify me why I am not getting output for below code.

Question

0.00/5 (No votes)

See more:

In the below code to find an element is present in an array or not,I am not getting the output if else part is uncommented.

C++

#include<stdio.h>
int main()
{
    int a[]={2,5,8},i,n=2,flag=0;
     
        for(i=0;i<10;i++)
        {
            if(a[i] == n )
            {
                flag = 1;
            }
            //else 
              //  flag = 0;
        }
        if(flag==1)
                printf("present %d\n",n);
}

What I have tried:

If else part is commented ,I am getting output.

Posted 22-Nov-16 19:46pm

Member 12865735

Updated 22-Nov-16 21:02pm

KarstenK

v2

Add a Solution

3 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2016-11-22T20:42:00

Simple: if you uncomment the line, then every time it doesn't find a match, it sets the flag to "no match". Which means that if you find a match in the first location, you set the "found it" flag, and overwrite it back to "not found" for every other character in the array.
The best solution to this is simple: exit from the loop when you find a match:

C#

int main()
    {
    int a[]={2,5,8},i,n=2
    for(i=0;i<10;i++)
        {
        if(a[i] == n )
            {
            printf("present %d\n",n);
            break;
            }
        }
    }

Jochen Arndt · Answer 2 · 2016-11-22T20:46:00

When the else part is present the flag is set according to the last checked item. Then the loop is not necessary because a similar check would be:

C++

if (a[9] == 2)
    flag = 1;
else
    flag = 0;

Writing it down this way you should also recognise that you are accessing items that are not part of the array (out of bound access) because your array has a size of three items so that the highest allowed index is two.

KarstenK · Answer 3 · 2016-11-22T20:36:00

Solution 1

It is really obvious that the flag is set to 0 in your else. It happens EVERYTIME when the if statement fails.

You should use the debugger !!!

And make someTRACE output if something is unclear.

Posted 22-Nov-16 20:36pm

KarstenK

Please clarify me why I am not getting output for below code.

3 solutions

Solution 2

Solution 3

Solution 1

Add your solution here

Preview 0