How do I optimize it further for time restrictions

Question

1.00/5 (1 vote)

See more:

How can i optimize it for less than 1 sec

What I have tried:

C#

import java.util.*;

class TestClass {

public static void main(String args[] ) {
    Scanner sc=new Scanner(System.in);
    int n=sc.nextInt();
    int a[]=new int[n];
    int b[]=new int[n];
    for(int i=0;i<n;i++)
    {
        a[i]=sc.nextInt();
        b[i]=sc.nextInt();
    }
    long sum=0;
    for(int i=0;i<n-1;i++)
    {
        for(int j=i+1;j<n;j++)
        {
          sum += Math.abs(a[i]-a[j])*(Math.max(b[i],b[j]));   
        }
    }
    System.out.println(sum);
    }

}

Posted 17-Dec-16 23:53pm

Anmol_1994

Updated 18-Dec-16 0:53am

Add a Solution

Comments

Patrice T 18-Dec-16 6:28am

Without knowledge of what is this code, there is not much to do. the code look already optimum.

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Afzaal Ahmad Zeeshan · Answer 1 · 2016-12-18T00:53:00

That will never execute under 1 second. There are many things,

1) User input is request, which will be more than seconds in itself.
2) The size is unknown, array manipulation will take a long time.
3) Two loops, even if we improve one, what about second?
4) Math library functions also require some CPU time.

Just one solution, make sure the size of arrays and loops is less than 10 elements. Only then it might work. What I worked,

Java

/*
 * To change this license header, choose License Headers in Project Properties.
 * To change this template file, choose Tools | Templates
 * and open the template in the editor.
 */
package hellojava;

/**
 *
 * @author afzaa
 */
public class HelloJava {

    /**
     * @param args the command line arguments
     */
    public static void main(String[] args) {
        // TODO code application logic here
        int[] arr = {1, 2, 3, 4, 5, 6, 7, 8, 9, 10};
        int n = 10; 
        int a[] = new int[n];
        int b[] = new int[n];
        for(int i=0;i<n;i++)
        {
            a[i] = arr[i];
            b[i] = arr[i];
        }
        long sum=0;
        for(int i=0;i<n-1;i++)
        {
            for(int j=i+1;j<n;j++)
            {
              sum += Math.abs(a[i]-a[j])*(Math.max(b[i],b[j]));   
            }
        }
        System.out.println(sum);
    }
}

This program, takes exactly 1 second to execute.

run:
1320
BUILD SUCCESSFUL (total time: 1 second)

See? Just what I said. :)