Linked list problem to insert a node

Question

0.00/5 (No votes)

See more:

Programming Problems and Competitions :: HackerRank[^]

What I have tried:

C++

/*
  Insert Node at the end of a linked list 
  head pointer input could be NULL as well for empty list
  Node is defined as 
  struct Node
  {
     int data;
     struct Node *next;
  }
*/
Node* Insert(Node *head,int data)
{
  // Complete this method
    Node *temp;
    temp=head;
    if(temp=='\0'){
        temp=(struct Node *)malloc(sizeof(struct Node));
        temp->data=data;
        head=temp;
        head->next='\0';
    }
        
     else {
            while (temp!='\0'){
                temp=temp->next;
            }
        temp->data=data;
        temp->next='\0';
    }
    
    return head;
}

Posted 30-Dec-16 0:53am

Member 12928262

Updated 30-Dec-16 1:37am

Patrice T

v2

Add a Solution

Comments

Patrice T 30-Dec-16 6:57am

And you plan to tell us what is the problem ?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CPallini · Answer 1 · 2016-12-30T01:37:00

Quote:
else {
while (temp!='\0'){
temp=temp->next;
}
temp->data=data;
temp->next='\0';
}

Should be, instead

else 
{
  while ( temp->next )
  {
    temp = temp->next;
  }
  temp->next = (struct Node *)malloc(sizeof(struct Node));
  temp->next->data = data;
  temp->next->next = NULL;
}

Please note, in C++ code, use:

nullptr (instead of '\0' or NULL.)
new instead of malloc.
Node constructor to initialize it.

At least, if you insist using C-like programming, always check the return value of malloc.