Php counting uppercase letters (not working)

Question

0.00/5 (No votes)

See more:

I am new to PHP and trying to count all the uppercase letters in the text area, thought I am not able get anything when I hit the 'submit' button. Here is my code :

What I have tried:

PHP

<pre><!DOCTYPE html>
<html>
<body>
<?php
if(isset($_POST['submit'])) {
 function caps($s) {
   $u = 0;
   $d = 0;
   $n = strlen($s);

   for ($x=0; $x<$n; $x++) {
       $d = ord($s[$x]);
       if ($d > 64 && $d < 91) {
           $u++;
       }
   } 

   return $u;
   }
  $n1=$_POST['n1'];
     echo 'caps: ' .  caps($n1) . "\n";
}
?>
  <form><textarea rows="4" cols="50" name="n1" value="<?php if(isset($_POST['n1'])){echo htmlspecialchars($_POST['n1']);}?>"></textarea>
 <br><input type="submit" name="submit" value="Submit"></form>
 </body>
 </html>

Posted 25-Feb-17 17:42pm

Member 13023527

Updated 25-Feb-17 18:45pm

Add a Solution

4 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Peter Leow · Answer 1 · 2017-02-25T17:58:00

Solution 1

You forgot to add the form method of post:

<form method="post">

At the moment, it is using the default get method and your PHP script is expecting $_POST variable. Learn Forms in HTML documents[^]

Posted 25-Feb-17 17:58pm

Peter Leow

Updated 25-Feb-17 18:00pm

v2

Bryian Tan · Answer 2 · 2017-02-25T18:16:00

The code look fine. Just need a small changes
1. Add POST to the form
2. move the if(isset($_POST['submit'])) { at the end of the function

HTML

<!DOCTYPE html>
<html>
<body>
<?php

 function caps($s) {
   $u = 0;
   $d = 0;
   $n = strlen($s);

   for ($x=0; $x<$n; $x++) {
       $d = ord($s[$x]);
       if ($d > 64 && $d < 91) {
           $u++;
       }
   } 

   return $u;
   }
if(isset($_POST['submit'])) {
  $n1=$_POST['n1'];
     echo 'caps: ' .  caps($n1) . "\n";
}
?>
  <form method="POST"><textarea rows="4" cols="50" name="n1" value="<?php if(isset($_POST['n1'])){echo htmlspecialchars($_POST['n1']);}?>"></textarea>
 <br><input type="submit" name="submit" value="Submit"></form>
 </body>
 </html>

Graeme_Grant · Answer 3 · 2017-02-25T18:21:00

Another tip for you: Naming methods/variables is just as important as the code itself - it makes the code more readable and easier to debug. Correct spacing too.

HTML

<!DOCTYPE html>
<html>
<body>
<?php

if(isset($_POST['submit'])) {
    function CountUppercase($text) {
        $count = 0;
        $character = 0;
        $length = strlen($text);

        for ($index = 0; $index < $length; $index++) {
                $character = ord($text[$index]);
                if ($character > 64 && $character < 91) {
                    $count++;
                }
        } 
        return $count;
    }
    $n1=$_POST['n1'];
    echo 'caps: ' .  caps($n1) . "\n";
}

?>
    <form method="post">
        <textarea rows="4" cols="50" name="n1" value="<?php if(isset($_POST['n1'])){echo htmlspecialchars($_POST['n1']);}?>"></textarea><br>
        <input type="submit" name="submit" value="Submit">
    </form>
  </body>
</html

Patrice T · Answer 4 · 2017-02-25T18:45:00

Solution 4

you can remove this line of code:

PHP

$d = 0;

because the value is never used.

Posted 25-Feb-17 18:45pm

Patrice T

Comments

Graeme_Grant 26-Feb-17 0:51am

Are you sure?

$d = ord($s[$x]);

Patrice T 26-Feb-17 1:09am

Yes, the value 0 is never used. I didn't say the variable isn't used.

Graeme_Grant 26-Feb-17 1:09am

:P

Php counting uppercase letters (not working)

4 solutions

Solution 1

Solution 2

Solution 3

Solution 4

Add your solution here

Preview 0