Sql database is not updating

Question

1.00/5 (1 vote)

See more:

im trying to update a table with two composite primary keys but it wont update.

What I have tried:

public void update(MOduleQuestion moduleq)
        {
            string mcode = moduleq.getModuleCode();
            int QNo = moduleq.getQuestionNo();
            string Question = moduleq.getQuestion();
            string OPt1 = moduleq.getOP1();
            string OPt2 = moduleq.getOP2();
            string OPt3 = moduleq.getOP3();
            string OPt4 = moduleq.getOP4();
            string Answer = moduleq.getAnswer();


            try
            {
                //string sql = "Update Module_Question SET Question='" + Question + "',Option1='" + OPt1 + "',Option2='" + OPt2 + "',Option3='" + OPt3 + "',Option4='" + OPt4 + "' WHERE MQ_Module_Code = '" + mcode + "' AND MQ_Module_No= '" + QNo + "' ";
                string sql = "Update Module_Question SET Question = @question, OPt1 = @opt1, OPt2 = @opt2, OPt3 =  @opt3, OPt4 = @opt4, Answer = @answer WHERE MQ_Module_Code = @mcode and  MQ_Question_No  = @qno";
                SqlCommand cmd = new SqlCommand(sql, m_con);
                cmd.CommandType = System.Data.CommandType.Text;
                cmd.Parameters.AddWithValue("@mcode", mcode);
                cmd.Parameters.AddWithValue("@qno", QNo);
                cmd.Parameters.AddWithValue("@question", Question);
                cmd.Parameters.AddWithValue("@opt1", OPt1);
                cmd.Parameters.AddWithValue("@opt2", OPt2);
                cmd.Parameters.AddWithValue("@opt3", OPt3);
                cmd.Parameters.AddWithValue("@opt4", OPt4);
                cmd.Parameters.AddWithValue("@answer", Answer);

                //SqlCommand cmd = new SqlCommand(sql, m_con);
                m_con.Open();
                cmd.ExecuteNonQuery();
                MessageBox.Show("Question Record Updated Successfully", "lecture Reg System", MessageBoxButtons.OK, MessageBoxIcon.Information);
            }
            catch (SqlException)
            {
                MessageBox.Show("Cannot Update", "lecture Reg System", MessageBoxButtons.OK, MessageBoxIcon.Information);

            }
            finally
            {
                m_con.Close(); // connection close


            }
        }

Posted 14-Mar-17 6:37am

Member 13049972

Updated 14-Mar-17 8:09am

v4

Add a Solution

Comments

[no name] 14-Mar-17 12:53pm

You want AddWithValue for your parameters

CHill60 14-Mar-17 13:05pm

Yep - that'll do it.

Member 13049972 14-Mar-17 13:22pm

so i have to type AddWithValue Module_Question SET Question =.... lie this?

[no name] 14-Mar-17 13:42pm

No.... cmd.Parameters.AddWithValue("@mcode", mcode);

You can learn a lot from reading the documentation, just saying.

Karthik_Mahalingam 14-Mar-17 13:30pm

are you getting any error?

Member 13049972 14-Mar-17 13:49pm

im trying to Update , this is a different code but its not working, can u show me how do i write my code for update.

Karthik_Mahalingam 14-Mar-17 13:52pm

i mean are you getting any error?

Member 13049972 14-Mar-17 13:56pm

its giving the catch exception

Karthik_Mahalingam 14-Mar-17 13:58pm

check this what you are getting
catch (SqlException ex)
{
messagebox.show(ex.Message )

Member 13049972 14-Mar-17 14:01pm

catch (SqlException)
{
MessageBox.Show("Cannot Update", "lecture Reg System", MessageBoxButtons.OK, MessageBoxIcon.Information);

}
im getting cannot update message box

Karthik_Mahalingam 14-Mar-17 14:02pm

catch (SqlException ex)
{
MessageBox.Show(ex.Message);

}

now check

Member 13049972 14-Mar-17 14:08pm

YES! it is working :), can you explain me what happened ?

Karthik_Mahalingam 14-Mar-17 14:11pm

ok what is the error message?

Member 13049972 14-Mar-17 14:26pm

no error messages its working now

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Member 13049972 · Accepted Answer · 2017-03-14T08:09:00

//Update a lecture
        public void update(MOduleQuestion moduleq)
        {
            string mcode = moduleq.getModuleCode();
            int QNo = moduleq.getQuestionNo();
            string Question = moduleq.getQuestion();
            string OPt1 = moduleq.getOP1();
            string OPt2 = moduleq.getOP2();
            string OPt3 = moduleq.getOP3();
            string OPt4 = moduleq.getOP4();
            string Answer = moduleq.getAnswer();


            try
            {
                //string sql = "Update Module_Question SET Question='" + Question + "',Option1='" + OPt1 + "',Option2='" + OPt2 + "',Option3='" + OPt3 + "',Option4='" + OPt4 + "' WHERE MQ_Module_Code = '" + mcode + "' AND MQ_Module_No= '" + QNo + "' ";
                string sql = "Update Module_Question SET Question = @question, Option1 = @opt1, Option2 = @opt2, Option3 =  @opt3, Option4 = @opt4, Answer = @answer WHERE MQ_Module_Code = @mcode and  MQ_Question_No  = @qno";
                SqlCommand cmd = new SqlCommand(sql, m_con);
                cmd.CommandType = System.Data.CommandType.Text;
                cmd.Parameters.AddWithValue("@mcode", mcode);
                cmd.Parameters.AddWithValue("@qno", QNo);
                cmd.Parameters.AddWithValue("@question", Question);
                cmd.Parameters.AddWithValue("@opt1", OPt1);
                cmd.Parameters.AddWithValue("@opt2", OPt2);
                cmd.Parameters.AddWithValue("@opt3", OPt3);
                cmd.Parameters.AddWithValue("@opt4", OPt4);
                cmd.Parameters.AddWithValue("@answer", Answer);

                //SqlCommand cmd = new SqlCommand(sql, m_con);
                m_con.Open();
                cmd.ExecuteNonQuery();
                MessageBox.Show("Question Record Updated Successfully", "lecture Reg System", MessageBoxButtons.OK, MessageBoxIcon.Information);
            }
            catch (SqlException ex)
            {
                MessageBox.Show(ex.Message);

            }
            finally
            {
                m_con.Close(); // connection close


            }
        }