Selection sort with swapping two elements

Question

0.00/5 (No votes)

See more:

So,instead of finding the minimum only,I have to find the minimum value and the second minimum value and store it in the right place.
my code isnt working in all cases
for example

#include <iostream>
void AdvancedSelectionSort(int data[], int n)
{ 
	for(int i=0;i<n-1;i=i+2){
		int smallest,secondsmallest;
		 
	  smallest=i;
	  secondsmallest=i+1;


	for(int j=i+1;j<n;j++)
	{
		
		if(data[j]<=data[smallest]){
	    secondsmallest=smallest;
		smallest=j;}

		else if(data[j]<=data[secondsmallest])
			secondsmallest=j;
	}

	
	  
	if(secondsmallest!=(i+1))
		Swap(data[i+1],data[secondsmallest]);

	if(smallest!=i)
		Swap(data[i],data[smallest]);

	
	
	
	
	}
}


int main(){
	int x[10]=[2,5,8,7,9,12,88,74,3,10]
	AdvancedSelectionSort(x,10);
	for(int i=0;i<10;i++)
		cout<<x[i]<<" ";



}

What I have tried:

void Swap(int &a,int&b)

{int temp=a;
a=b;
b=temp;}

void AdvancedSelectionSort(int data[], int n)
{
for(int i=0;i<n-1;i=i+2){
int smallest,secondsmallest;

smallest=i;
secondsmallest=i+1;

for(int j=i+1;j<n;j++)
{

if(data[j]<=data[smallest]){
secondsmallest=smallest;
smallest=j;}

else if(data[j]<=data[secondsmallest])
secondsmallest=j;
}

if(secondsmallest!=(i+1))
Swap(data[i+1],data[secondsmallest]);

if(smallest!=i)
Swap(data[i],data[smallest]);

}
}

Posted 18-Mar-17 5:14am

Member 13067828

Updated 18-Mar-17 6:41am

v2

Add a Solution

Comments

[no name] 18-Mar-17 11:36am

If you sort a list of data you can get Minimum the second and the third and the...
What is the Problem?

Member 13067828 18-Mar-17 12:02pm

its not sorting correctly in all cases

Patrice T 18-Mar-17 12:08pm

Use Improve question to update your question.
Explain that and example data (input and output that exhibit the problem.
Update your code to a full function, so we can run it.

Member 13067828 18-Mar-17 12:29pm

I updated the function

Member 13067828 18-Mar-17 12:32pm

as for the example
its not sorting this array x[8]={2,7,9,5,6,7,8,10};
the output is 2 5 6 7 8 9 7 10

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

OriginalGriff · Answer 1 · 2017-03-18T06:35:00

If you task is to sort the data, and then get the smallest two elements, then stop looking for the smallest and the second smallest, and concentrate on getting the sort to work. Remove all "smallest" code, and just sort.
When you have that working, the smallest two are the first and second elements of the resulting array...

If you aren't supposed to sort it, then you can find the smallest and second smallest in a single pass through the data: Create a smallest and secondSmallest variables, and set them both to the maximum value an integer can hold.
Pass through the data and compare each value (V) with the second smallest (S2). If it's smaller, compare it to the smallest (S1). Then:
if V >= S2 ignore it.
if V < S2 and V >= S1 set S2 to V.
if V < S2 and V < S1 set S2 to S1, set S1 to V.
At the end of the loop, you have the smallest and second smallest.

Patrice T · Answer 2 · 2017-03-18T06:41:00

C++

for(int i=0;i<n-1;i=i+2){
    int smallest,secondsmallest;

  smallest=i;
  secondsmallest=i+1;

Think about it: what happen when data[i] is not smaller than data[i+1] ?

When you don't understand what your code is doing or why it does what it does, the answer is debugger.
Use the debugger to see what your code is doing. Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute, it is an incredible learning tool.

Debugger - Wikipedia, the free encyclopedia[^]
Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]
Basic Debugging with Visual Studio 2010 - YouTube[^]

The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't find bugs, it just help you to. When the code don't do what is expected, you are close to a bug.

[Update]
By the way:

C++

int x[10]=[2,5,8,7,9,12,88,74,3,10]

is missing the ";" at the end of line.

Try with:

C++

int x[10]=[2,1,4,3,6,5,8,7,10,9];

to see the problem when data[i] is not smaller than data[i+1]

Selection sort with swapping two elements

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0