Please, I need assistance on how I can get this part of my code work, as I keep getting warning message "unreachable code detected"

Question

1.00/5 (4 votes)

See more:

C#

private bool ValidData()
        {
                 
            // Initialize function return value
            return false;
            
            // Test CustomerID is complete
            if (((service_NoTextBox.Text == String.Empty) 
                    ||(Information.IsNumeric(service_NoTextBox.Text) == false)))
            {
                // Required employee ID is not complete
                MessageBox.Show("Service Number is not complete", "Promotion List Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
                service_NoTextBox.Focus();
                service_NoTextBox.SelectAll();
            }
            else if (((file_NoTextBox.Text == String.Empty)
                        || (Information.IsNumeric(file_NoTextBox.Text) == false)))
            {
                // Validate File Number
                MessageString = "File Number is required and must be in five digit format.";
                MessageBox.Show(MessageString, "Data Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
                file_NoTextBox.Focus();
                file_NoTextBox.SelectAll();
            }
            else if (((nameTextBox.Text == String.Empty)
                        || (Information.IsNumeric(nameTextBox.Text) == true)))
            {
                // Validate  Name
                MessageString = "Name is required in alphabet format.";
                MessageBox.Show(MessageString, "Data Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
                nameTextBox.Focus();
                nameTextBox.SelectAll();
            }
            else if (((new_RankTextBox.Text == String.Empty)
                        || (Information.IsNumeric(new_RankTextBox.Text) == true)))
            {
                // Validate New Rank
                MessageString = "New Rank is required in alphabet format.";
                MessageBox.Show(MessageString, "Data Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
                new_RankTextBox.Focus();
                new_RankTextBox.SelectAll();
            }
            else if (((old_RankTextBox.Text == String.Empty)
                        || (Information.IsNumeric(old_RankTextBox.Text) == true)))
            {
                // Validate Previous Rank
                MessageString = "Old Rank is required in alphabetic form.";
                MessageBox.Show(MessageString, "Data Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
                old_RankTextBox.Focus();
                old_RankTextBox.SelectAll();
            }
            else if (((stationTextBox.Text == String.Empty)
                        || (Information.IsNumeric(stationTextBox.Text) == true)))
            {
                // Validate State
                MessageString = "State is required in letter form.";
                MessageBox.Show(MessageString, "Data Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
                stationTextBox.Focus();
                stationTextBox.SelectAll();
            }
            else if (((comboBox1.Text == String.Empty)
                        || (Information.IsNumeric(comboBox1.Text) == true)))
            {
                // Command Is required
                MessageString = "Please Enter Command.";
                MessageBox.Show(MessageString, "Data Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
                comboBox1.Focus();
                comboBox1.SelectAll();
            }
            else if (((comboBox2.Text == String.Empty)
                        || (Information.IsNumeric(comboBox2.Text) == true)))
            {
                // Validate 
                MessageString = "State of Origin must be in Alphabet form.";
                MessageBox.Show(MessageString, "Data Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
                comboBox2.Focus();
                comboBox2.SelectAll();
            }
                
            else
            {
                // All of the data is valid
                return true;
            }
                
        }

What I have tried:

I have tried to set the ValidData = false and true, but i also get cannot assign to a method type

Posted 6-Apr-17 4:54am

Okezie Victor

Updated 6-Apr-17 9:10am

Bryian Tan

v2

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Thomas Daniels · Accepted Answer · 2017-04-06T05:01:00

The first line of your method is return false;, so your method will immediately return false to the caller, and everything after this line will be ignored ("unreachable").

Only return false when you notice that the 'data' is actually invalid.

The comment above your 'return false' says 'Initialize function return value', so if that's what you want to do, then you can do something like bool returnValue = false; at the top, and at the end of the function, return returnValue; (and change returnValue in your method when necessary).

Karthik_Mahalingam · Accepted Answer · 2017-04-06T05:04:00

updated solution as per the comments from Dave Kreskowiak, removed the return keyword from each condition block.
replace it with a return variable and use it in required condition block and return the variable.

private bool ValidData()
       {

           // Initialize function return value
           bool returnValue = false;

           // Test CustomerID is complete
           if (((service_NoTextBox.Text == String.Empty)
           || (Information.IsNumeric(service_NoTextBox.Text) == false)))
           {
               // Required employee ID is not complete
               MessageBox.Show("Service Number is not complete", "Promotion List Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
               service_NoTextBox.Focus();
               service_NoTextBox.SelectAll();
           }
           else if (((file_NoTextBox.Text == String.Empty)
           || (Information.IsNumeric(file_NoTextBox.Text) == false)))
           {
               // Validate File Number
               MessageString = "File Number is required and must be in five digit format.";
               MessageBox.Show(MessageString, "Data Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
               file_NoTextBox.Focus();
               file_NoTextBox.SelectAll();
           }
               .
               .
               .
               .

           else
           {

               returnValue = true;
           }
           return returnValue;

       }
   }

Please, I need assistance on how I can get this part of my code work, as I keep getting warning message "unreachable code detected"

2 solutions

Solution 1

Solution 2

Add your solution here

Preview 0