Click here to Skip to main content
15,922,407 members
Please Sign up or sign in to vote.
1.00/5 (1 vote)
I have a Binary Search Tree, some functions in it, not planning to use any other libraries, nor use vectors, I have to use arrays and a tree. This code will mostly work, except for a bug, that for some roots, the functions that add arrays wont work or the printing functions wont work. Basically if you input a 1, on its own, and then input an array, about half of the array with be inserted into the tree. I have no idea how. If I try insert number 2 on its own first and then an array it works perfectly fine. Number 3 is broken, don't know if there's a pattern.

No errors, compiles fine. Expected input: input numbers alone or as an array, add them all to one binary tree. Expected output: print the tree with all the added numbers in the array and numbers added alone.

Please help, I'm desperate and I can't for the love of god find the cause of this.

Thank you anyone for anything.

P.S. I'm relatively new to coding, it might look like crap and be inefficient, that doesn't matter to me, as long as it works and I know how it works.

arrays - C++ Binary search tree bug - Stack Overflow[^]

What I have tried:

Tried debugging, but I'm a novice and it got me more confused than helped. Tried to put the code here, but I'm terrible at editing it, so I just ended up posting on stackoverflow and pasting the link here.
Updated 29-Apr-17 12:30pm

Development is not a case of "write it, compile it, fix compiler errors, compile it, ship it" - just compiling does not mean your code is right! :laugh:
Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send.

So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.

Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:
Input   Expected output    Actual output
  1            2                 1
  2            4                 4
  3            6                 9
  4            8                16
Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:
private int Double(int value)
   return value * value;

Once you have an idea what might be going wrong, start using teh debugger to find out why. Put a breakpoint on your line:

and run your app. Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?

This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!

So give it a try: learn to use the debugger on a relatively trivial example like this before you are faced with a bug in a 200,000 line lump of code someone else wrote the day he left the company!
Share this answer
No errors, compiles fine.

"Compiles fine" means that your code is correct C++, it does not mean that it does what it should as "no error" would mean.
"The cat is flying high in the sky.' is correct English grammar, but it is non sense.
Tried debugging, but I'm a novice and it got me more confused than helped.

The debugger is a tool, and like for any tool, you need to learn how to use it.

When you don't understand what your code is doing or why it does what it does, the answer is debugger.
Use the debugger to see what your code is doing. Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute, it is an incredible learning tool.

Debugger - Wikipedia, the free encyclopedia[^]
Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]
Basic Debugging with Visual Studio 2010 - YouTube[^]
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't find bugs, it just help you to. When the code don't do what is expected, you are close to a bug.
Share this answer

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900