How to implement ienumerable in code?

Question

0.00/5 (No votes)

See more:

Hi! i wanted to implement ienumerable in my code so that it is readonly but i don't know where to possibly implement it. So far i haven't found any solution in the internet that might answer my problem. As of now, i have only used List and wanted to integrate ienumerable in my code. Also, feel free to suggest anything if you notice bad coding practices.

What I have tried:

C#

public static List<GuitarItems> GetGuitarItems(string itemCategory)
    {
        List<GuitarItems> list = new List<GuitarItems>();
        string query = string.Format("SELECT * FROM guitarItems WHERE brand LIKE @brand");

        try
        {
            conn1.Open();
            command1.CommandText = query;
            command1.Parameters.Add(new SqlParameter("brand", itemCategory));
            SqlDataReader reader = command1.ExecuteReader();

            while (reader.Read())
            {
                int id = reader.GetInt32(0);
                string type = reader.GetString(1);
                string brand = reader.GetString(2);
                string model = reader.GetString(3);
                double price = reader.GetDouble(4);
                string itemimage1 = reader.GetString(5);
                string itemimage2 = reader.GetString(6);
                string description = reader.GetString(7);
                string necktype = reader.GetString(8);
                string body = reader.GetString(9);
                string fretboard = reader.GetString(10);
                string fret = reader.GetString(11);
                string bridge = reader.GetString(12);
                string neckpickup = reader.GetString(13);
                string bridgepickup = reader.GetString(14);
                string hardwarecolor = reader.GetString(15);

                GuitarItems gItems = new GuitarItems(id, type, brand, model, price, itemimage1, itemimage2, description, necktype, body,
                    fretboard, fret, bridge, neckpickup, bridgepickup, hardwarecolor);
                list.Add(gItems);
            }
        }
        finally
        {
            conn1.Close();
            command1.Parameters.Clear();
        }

        return list;
    }

And here is the other code:

C#

private void FillPage()
    {
        List<GuitarItems> itemList = new List<GuitarItems>();
        List<string> itemListPage = new List<string>();

        itemList = ConnectionClassGuitarItems.GetGuitarItems(brandType);
       
        StringBuilder sb = new StringBuilder();

        foreach (GuitarItems gList in itemList)
        {
            itemListPage.Add("GuitarItemsIbanezDetails" + (x + 1) + ".aspx");
           
            sb.Append(
                    string.Format(
                        @"
                        <div class='one-two'>
                            <a href='{3}' runat='server'><img runat='server' src='{0}'/></a>
                            <div class='content'>
                                <div id='label'>{1} {2}</div>
                            </div>
                        
                    </div>", gList.ItemImage1, gList.Brand, gList.Model, itemListPage[x]));

            x++;
            
        }
  

        lblOutput.Text = sb.ToString();

    }

Posted 28-May-17 4:08am

BebeSaiyan

Updated 1-Jun-17 2:47am

Add a Solution

Comments

[no name] 28-May-17 11:12am

So use a readonly collection.

BebeSaiyan 31-May-17 2:06am

@NotPoliticallyCorrect - yea right very helpful

Kornfeld Eliyahu Peter 29-May-17 3:08am

What is the connection between IEnumerable and read-only collection?

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Richard Deeming · Answer 1 · 2017-06-01T02:47:00

Use an iterator method:

C#

public static IEnumerable<GuitarItems> GetGuitarItems(string itemCategory)
{
    using (var con = new SqlConnection("..."))
    using (var cmd = new SqlCommand("SELECT * FROM guitarItems WHERE brand LIKE @brand", con))
    {
        cmd.Parameters.AddWithValue("@brand", itemCategory);
        
        con.Open();
        using (var reader = cmd.ExecuteReader(CommandBehavior.CloseConnection))
        {
            while (reader.Read())
            {
                int id = reader.GetInt32(0);
                ...
                
                yield return new GuitarItems(id, ...);
            }
        }
    }
}

Or use Dapper[^], as I suggested in your latest question[^].

C#

public static IEnumerable<GuitarItems> GetGuitarItems(string itemCategory)
{
    using (var con = new SqlConnection("..."))
    {
        return con.Query<GuitarItems>("SELECT * FROM guitarItems WHERE brand LIKE @brand", new { brand = itemCategory });
    }
}