Click here to Skip to main content
15,878,602 members
Please Sign up or sign in to vote.
1.00/5 (1 vote)
See more:
My function does not work, i need to preform a recursive binary search that returns a pointer to the location of the number i was searching, or null if doesn't exist.

int* binsearch(int arr[], int low, int size, int *p)
    int mid;
    mid = (low + size)/2;
    if (arr[mid] == *p) // found result
        *p = arr[mid];
	return p; 
    if (size <= 1) // meaning the number is not in the array
      printf("Number not found\n");
      return NULL;
    if (arr[mid] > *p) // if its on the left half of the array
        binsearch(arr, low, size/2, p);
    if (arr[mid] < size) // if its on the right half of the array
        binsearch(arr+mid, mid+1, size/2, p);

What I have tried:

posted the code i tried, and a couple more variations but nothing seems to work
Updated 6-Jun-17 21:21pm

My function does not work

This is not informative. An example of function calling woukd be also helpful.
There is numerous problems in your code:
binsearch(arr, low, size/2, p);
binsearch(arr+mid, mid+1, size/2, p);

Depending on the size of arr being odd or even, your code fails on size/2. And it just 1 point of failure.

When you don't understand what your code is doing or why it does what it does, the answer is debugger.

It is also a great learning tool because it show you reality and you can see which expectation match reality.
Use the debugger to see what your code is doing. Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute, it is an incredible learning tool.

Debugger - Wikipedia, the free encyclopedia[^]

Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]
Basic Debugging with Visual Studio 2010 - YouTube[^]
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't find bugs, it just help you to. When the code don't do what is expected, you are close to a bug.
Share this answer
You don't RETURN a pointer from your recursive binsearch() calls ...
Share this answer
Compiling does not mean your code is right! :laugh:
Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send.

So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.

Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:
Input   Expected output    Actual output
  1            2                 1
  2            4                 4
  3            6                 9
  4            8                16
Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:
private int Double(int value)
   return value * value;

Once you have an idea what might be going wrong, start using teh debugger to find out why. Put a breakpoint on your line:
mid = (low + size)/2;

and run your app. Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?

This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!

Yes, I could probably tell you what "the problem" is - but it's not difficult to do this yourself, and you will learn something really worthwhile at the same time!
Share this answer

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900