Click here to Skip to main content
13,190,405 members (53,683 online)
Rate this:
 
Please Sign up or sign in to vote.
See more:
i have worked on this program in my way but it is not working

What I have tried:

#include<stdio.h>
#include<conio.h>
main () {
int  r , f ,  i , j , k , a, z, d, count =0;
int arr[50];
int stl[10];
 
printf(" enter the number of elements : ");
scanf(" %d" , &a);
for(i=0;i<a;i++){
printf(" Enter %d element: \n" , i);
scanf(" %d" , &arr[i]);
}
for(i=0;i<5;i++){
	count = 0;
	for(j=0;j<5;j++){
		   if(arr[i] >= arr[j]){
		   ++count;
}else{}
}
r =0;
f = a;
	do{
	if( count == f){
	 stl[r] = arr[i];
	 --a;
	 ++r;
	 }else{
	 --a;
	 ++r;
	 }
	 }while(  f <= 0);
 

 
}
for(z=0;z<=5;z++){
printf(" %d" , stl[z]);
}
 
getch();
return 0;
 
}

[edit]Code block added - OriginalGriff[/edit]
Posted 4 days ago
Updated 4 days ago
v2
Rate this: bad
 
good
Please Sign up or sign in to vote.

Solution 1

Several things here:
1) We have no idea what it is supposed to do, so telling you what is wrong with it is completely impossible. As it telling you how to fix it.
2) We have no idea what it is doing that you didn't expect, or not doing that you did. As as we have no idea what values you entered, we can't even run it against the same conditions.
3) This is your homework, not mine. And that means it is part of a whole learning process,which includes getting the code you wrote working.

Compiling does not mean your code is right! :laugh:
Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send.

So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.

Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:
Input   Expected output    Actual output
  1            2                 1
  2            4                 4
  3            6                 9
  4            8                16
Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:
int Double(int value)
   {
   return value * value;
   }

Once you have an idea what might be going wrong, start using teh debugger to find out why. Put a breakpoint on your line:
f = a;

and run your app. Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?

This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!

And do yourself a favour: Several favours.
Indent your code. It makes it a whole load easier to read and understand if you can see what is where. At the moment, (even with the formatting I added) that is a dog's dinner!

Stop using single character names: they do two things. The first is the make your code hard to read - if you use names which reflect what the variable is there for, it "self documents" the code, and makes it a lot easier to understand. The second is that it makes your code more robust and reliable. If you look at code like this:
if (a < b)
It isn't obvious what you are comparing.
if (applesCount < maxOranges)
One glance and it's obvious that that is wrong!
  Permalink  
Rate this: bad
 
good
Please Sign up or sign in to vote.

Solution 2

Learn to indent properly your code, it show its structure and it helps reading and understanding.
#include<stdio.h>
#include<conio.h>
main () {
    int  r , f ,  i , j , k , a, z, d, count =0;
    int arr[50];
    int stl[10];
 
    printf(" enter the number of elements : ");
    scanf(" %d" , &a);
    for(i=0;i<a;i++){
        printf(" Enter %d element: \n" , i);
        scanf(" %d" , &arr[i]);
    }
    for(i=0;i<5;i++){
        count = 0;
        for(j=0;j<5;j++){
            if(arr[i] >= arr[j]){
                ++count;
            }else{}
        }
        r =0;
        f = a;
        do{
            if( count == f){
                stl[r] = arr[i];
                --a;
                ++r;
            }else{
                --a;
                ++r;
            }
        }while(  f <= 0);
    }
    for(z=0;z<=5;z++){
        printf(" %d" , stl[z]);
    }
    getch();
    return 0;
}

Professional programmer's editors have this feature and others ones such as parenthesis matching and syntax highlighting.
Notepad++ Home[^]
ultraedit[^]

Quote:
i have worked on this program in my way but it is not working

As we have no idea of what the code should do or in what the code is bot working, the only advice I can give you is to use a tool that will help you to understand what is going on. That tool is the debugger.

There is a tool that allow you to see what your code is doing, its name is debugger. It is also a great learning tool because it show you reality and you can see which expectation match reality.
When you don't understand what your code is doing or why it does what it does, the answer is debugger.
Use the debugger to see what your code is doing. Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute.

Debugger - Wikipedia, the free encyclopedia[^]

Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]
Basic Debugging with Visual Studio 2010 - YouTube[^]
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't find bugs, it just help you to. When the code don't do what is expected, you are close to a bug.
  Permalink  

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

  Print Answers RSS
Top Experts
Last 24hrsThis month


Advertise | Privacy |
Web03 | 2.8.171016.2 | Last Updated 12 Oct 2017
Copyright © CodeProject, 1999-2017
All Rights Reserved. Terms of Service
Layout: fixed | fluid

CodeProject, 503-250 Ferrand Drive Toronto Ontario, M3C 3G8 Canada +1 416-849-8900 x 100