Several things here:
1) We have no idea what it is supposed to do, so telling you what is wrong with it is completely impossible. As it telling you how to fix it.
2) We have no idea what it is doing that you didn't expect, or not doing that you did. As as we have no idea what values you entered, we can't even run it against the same conditions.
3) This is your homework, not mine. And that means it is part of a whole learning process,which includes getting the code you wrote working.
Compiling does not mean your code is right! :laugh:
Think of the development process as writing an email: compiling successfully means that you wrote the email in the right language - English, rather than German for example - not that the email contained the message you wanted to send.
So now you enter the second stage of development (in reality it's the fourth or fifth, but you'll come to the earlier stages later): Testing and Debugging.
Start by looking at what it does do, and how that differs from what you wanted. This is important, because it give you information as to why it's doing it. For example, if a program is intended to let the user enter a number and it doubles it and prints the answer, then if the input / output was like this:
Input Expected output Actual output
1 2 1
2 4 4
3 6 9
4 8 16
Then it's fairly obvious that the problem is with the bit which doubles it - it's not adding itself to itself, or multiplying it by 2, it's multiplying it by itself and returning the square of the input.
So with that, you can look at the code and it's obvious that it's somewhere here:
int Double(int value)
return value * value;
Once you have an idea what might be going wrong, start using teh debugger to find out why. Put a breakpoint on your line:
f = a;
and run your app. Think about what each line in the code should do before you execute it, and compare that to what it actually did when you use the "Step over" button to execute each line in turn. Did it do what you expect? If so, move on to the next line.
If not, why not? How does it differ?
This is a skill, and it's one which is well worth developing as it helps you in the real world as well as in development. And like all skills, it only improves by use!
And do yourself a favour: Several favours.
Indent your code. It makes it a whole load easier to read and understand if you can see what is where. At the moment, (even with the formatting I added) that is a dog's dinner!
Stop using single character names: they do two things. The first is the make your code hard to read - if you use names which reflect what the variable is there for, it "self documents" the code, and makes it a lot easier to understand. The second is that it makes your code more robust and reliable. If you look at code like this:
if (a < b)
It isn't obvious what you are comparing.
if (applesCount < maxOranges)
One glance and it's obvious that that is wrong!