Unable to get record on multiple selection of listbox.

Question

0.00/5 (No votes)

See more:

i have a listbox and gridview,if i made multple selection of item of listbox , data of last item show only ..i want to  show record of all selected item of listbox

What I have tried:

protected void searchname_date()
{

    if (ListBox1.Items.Count > 0)
    {
        for (int i = 0; i < ListBox1.Items.Count; i++)
        {
            if (ListBox1.Items[i].Selected)
            {
                string selectedItem = ListBox1.Items[i].Text;

                SqlConnection cnn = new SqlConnection(ConfigurationManager.ConnectionStrings["ConnectionString"].ConnectionString);
                string Query = "SELECT *  FROM [dsr_data] where (date_time between '" + TextBox1.Text + "'  and    '" + TextBox4.Text + "') And  session_name='" + selectedItem + "'";
                DataTable dtAdmin = new DataTable();
                SqlDataAdapter da;
                da = new SqlDataAdapter(Query, cnn);
                da.Fill(dtAdmin);
                if (dtAdmin.Rows.Count > 0)
                {
                    GVmydsr.DataSource = dtAdmin;
                    GVmydsr.DataBind();

                }
                else
                {
                    GVmydsr.DataSource = null;
                    GVmydsr.DataBind();
                }


            }

        }
    }
}

Posted 1-Nov-17 20:04pm

ADI@345

Updated 1-Nov-17 20:22pm

Add a Solution

1 solution

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Karthik_Mahalingam · Accepted Answer · 2017-11-01T20:22:00

Solution 1

try

protected void searchname_date()
      {
          List<string> lstSelectedItems = new List<string>();

          if (ListBox1.Items.Count > 0)
              for (int i = 0; i < ListBox1.Items.Count; i++)
                  if (ListBox1.Items[i].Selected)
                      lstSelectedItems.Add(ListBox1.Items[i].Text);


          string inQuery = string.Join("','", lstSelectedItems);
          inQuery = "'" + inQuery + "'";

          SqlConnection cnn = new SqlConnection(ConfigurationManager.ConnectionStrings["ConnectionString"].ConnectionString);
          string Query = "SELECT *  FROM [dsr_data] where (date_time between @from  and    @to ) And  session_name in ({0})";
          Query = string.Format(Query, inQuery);
          SqlCommand cmd = new SqlCommand(Query, cnn);
          cmd.Parameters.AddWithValue("@from", TextBox1.Text);
          cmd.Parameters.AddWithValue("@to", TextBox4.Text);

          DataTable dtAdmin = new DataTable();
          SqlDataAdapter da;
          da = new SqlDataAdapter(Query, cnn);
          da.Fill(dtAdmin);
          if (dtAdmin.Rows.Count > 0)
              GVmydsr.DataSource = dtAdmin;
          else
              GVmydsr.DataSource = null;
          GVmydsr.DataBind();


      }

Note:Formatting the sql Query string is vulnerable to SQL Injection[^] attacks
always use Parameterized queries to prevent SQL Injection Attacks in SQL Server[^]

Posted 1-Nov-17 20:22pm

Karthik_Mahalingam

v2

Comments

ADI@345 2-Nov-17 2:33am

still facing same issue, only last record of listbox item shown

Karthik_Mahalingam 2-Nov-17 2:37am

what is the value you are getting in "inQuery "

ADI@345 2-Nov-17 2:42am

protected void searchname_date()
{
List<string> lstSelectedItems = new List<string>();

if (ListBox1.Items.Count > 0)
{
for (int i = 0; i < ListBox1.Items.Count; i++)
{
if (ListBox1.Items[i].Selected)
{
lstSelectedItems.Add(ListBox1.Items[i].Text);

string inQuery = string.Join("','", lstSelectedItems);
inQuery = "'" + inQuery + "'";

SqlConnection cnn = new SqlConnection(ConfigurationManager.ConnectionStrings["ConnectionString"].ConnectionString);
string Query = "SELECT * FROM [dsr_data] where (date_time between '" + TextBox1.Text + "' and '" + TextBox4.Text + "') And session_name='" + inQuery + "'";
Query = string.Format(Query, inQuery);
DataTable dtAdmin = new DataTable();
SqlDataAdapter da;
da = new SqlDataAdapter(Query, cnn);
da.Fill(dtAdmin);
if (dtAdmin.Rows.Count > 0)
{
GVmydsr.DataSource = dtAdmin;
GVmydsr.DataBind();

}
else
{
GVmydsr.DataSource = null;
GVmydsr.DataBind();
}

}

}
}
}

ERROR :-
Deepali is one the name of item of listbox.
Incorrect syntax near 'Deepali'.
Description: An unhandled exception occurred during the execution of the current web request. Please review the stack trace for more information about the error and where it originated in the code.

Exception Details: System.Data.SqlClient.SqlException: Incorrect syntax near 'Deepali'.

Karthik_Mahalingam 2-Nov-17 2:44am

protected void searchname_date()
        {
            List<string> lstSelectedItems = new List<string>();
 
            if (ListBox1.Items.Count > 0)
                for (int i = 0; i < ListBox1.Items.Count; i++)
                    if (ListBox1.Items[i].Selected)
                        lstSelectedItems.Add(ListBox1.Items[i].Text);
 

            string inQuery = string.Join("','", lstSelectedItems);
            inQuery = "'" + inQuery + "'";
 
            SqlConnection cnn = new SqlConnection(ConfigurationManager.ConnectionStrings["ConnectionString"].ConnectionString);
            string Query = "SELECT *  FROM [dsr_data] where (date_time between @from  and    @to ) And  session_name in ({0})";
            Query = string.Format(Query, inQuery);
            SqlCommand cmd = new SqlCommand(Query, cnn);
            cmd.Parameters.AddWithValue("@from", TextBox1.Text);
            cmd.Parameters.AddWithValue("@to", TextBox4.Text);
 
            DataTable dtAdmin = new DataTable();
            SqlDataAdapter da;
            da = new SqlDataAdapter(Query, cnn);
            da.Fill(dtAdmin);
            if (dtAdmin.Rows.Count > 0)
                GVmydsr.DataSource = dtAdmin;
            else
                GVmydsr.DataSource = null;
            GVmydsr.DataBind();
 

        }

ADI@345 2-Nov-17 2:49am

sir actually what happen , when we select two item from listbox , it work fine with one item but with two item
SELECT * FROM [dsr_data] where date_time between '11/1/2017' and '11/30/2017' And session_name='abc','efg'
this query doesnot give any output in sql server..

Karthik_Mahalingam 2-Nov-17 2:51am

   SqlConnection cnn = new SqlConnection(ConfigurationManager.ConnectionStrings["ConnectionString"].ConnectionString);
            string Query = "SELECT *  FROM [dsr_data] where (date_time between @from  and    @to ) And  session_name in ({0})";
            Query = string.Format(Query, inQuery);
            SqlCommand cmd = new SqlCommand(Query, cnn);
            cmd.Parameters.AddWithValue("@from", TextBox1.Text);
            cmd.Parameters.AddWithValue("@to", TextBox4.Text);

Karthik_Mahalingam 2-Nov-17 2:51am

SQL IN Operator[^]

ADI@345 2-Nov-17 2:54am

Yes i forget to use IN clause ..now it work.. thanks

Karthik_Mahalingam 2-Nov-17 3:06am

welcome