No matching function for call to...

Question

1.00/5 (1 vote)

See more:

I am getting this specific error for this specific part of my code. Two other places as well, but I think if I can solve one I can solve the others. This error is for this part of the code, "ins.open(fileName.c_str()) ;"

void openInfile (ifstream& ins)
{
	string fileName = " " ;
	ofstream outs ;		// outs is an output stream
	cout << "Enter file of madlibs outline." << endl ;
	cin >> fileName ;
	ins.open(fileName.c_str()) ;		//connects ins to file inFile
	if (ins.fail (fileName.c_str()))
	{
		cerr << "Error: Unable to open file : FILENAME" << endl ;
	}
	else
	{
		openOutfile (outs) ;
	}
}

What I have tried:

I have asked many people to help me and have researched through many similar questions, but I still can't find anything to help me.

Posted 28-Nov-17 14:03pm

Member 13479017

Updated 28-Nov-17 21:47pm

Add a Solution

2 solutions

Solution 2

Change from

Quote:
if (ins.fail (fileName.c_str()))

To

C++

if ( ins.fail() )

Posted 28-Nov-17 21:47pm

CPallini

Comments

Member 13479017 29-Nov-17 7:51am

Thank you, but it still does not work.

CPallini 29-Nov-17 7:57am

Does it compile? If it doesn't compile: what is the (exact) error message?

Member 13479017 29-Nov-17 8:08am

okay, so with that specific line of code, the error message reads:

prog5B.cpp: In function ‘void openInfile(std::ifstream)’:
prog5B.cpp:50: error: could not convert ‘ins.std::basic_ios<_CharT, _Traits>::fail [with _CharT = char, _Traits = std::char_traits<char>]’ to ‘bool’

CPallini 29-Nov-17 8:17am

pay attention to the number of round braces, it is
if ( ins.fail() )

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Peter_in_2780 · Accepted Answer · 2017-11-28T15:26:00

Solution 1

Your problem is in

if (ins.fail (fileName.c_str()))

You just need

if (ins.fail)

and you will probably want to change

cerr << "Error: Unable to open file : FILENAME" << endl ;

to something like

cerr << "Error: Unable to open file : " << filename.c_str() << endl ;

Posted 28-Nov-17 15:26pm

Peter_in_2780

Updated 28-Nov-17 21:01pm

v2

Comments

CPallini 29-Nov-17 3:48am

Hey Peter, fail is a method.

Peter_in_2780 29-Nov-17 5:08am

Oops! My fossilised brain. Thanks for the correction, Carlo.

Member 13479017 29-Nov-17 7:51am

Thank you. I changed it, but it still does not work. Now the error at that spot changed from "no matching function for call to" to "could not convert"