Click here to Skip to main content
15,891,607 members
Please Sign up or sign in to vote.
1.00/5 (1 vote)
See more:
#include <stdio.h>
#include <stdlib.h>
int compare(char info[][20], int n);
void read();
void swap(char *ap, char *bp);
int main()
{
read();

return 0;
}
void read()
{
int n,c;
printf("Enter how many names you want to sort.\n");
scanf("%d", &n);
printf("Please enter %d names.\n", n);
char *info[n][20];

for(c=0;c<n;c++) //store input in array
{
scanf("%s", info[c]);
}

printf("Entered strings:\n");
for(c=0;c<n-1;c++)
{
printf("%s\n",info[c]);
}
compare(info,n);
printf("ordered strings:\n");
for(c=0;c<n;c++)
{
printf("%s\n",info[c]);
}
}
int compare(char info[][20], int n)
{
int c = 0;
char *ap;
ap = info[c];

char *bp;
bp = info[c+1];
int y = 0;
printf("%s, %s", ap, bp);
for(y = 0; y < n; y++)
{

while(*ap == *bp)
{
if (*ap == '\0' && *bp == '\0')
{
return 0;
break;
}
ap++;
bp++;
}
if (*ap < *bp)
{
return 1;
}
if (*ap > *bp)
{
swap(ap, bp);
return -1;
}
}
if (*ap < *bp)
{
return 1;
}
if (*ap > *bp)
{
swap(ap, bp);
return -1;
}
}


void swap(char *ap, char *bp)
{

char tmp;
int x = 0;
while(*ap != '\0' || *bp != '\0')
{

tmp = *ap;
*ap = *bp;
*bp = tmp;
ap++;
bp++;
}
}

What I have tried:

try to print something in code but still don't know how to fix it.
Posted
Updated 24-Dec-17 18:41pm
Comments
Nakhia_ind 26-Dec-17 9:42am    
sir here no size in first int compare(char info[][20], int n);
means that will be int compare(char info[2][20], int n);

1 solution

Quote:
Why my ordered string something wrong

So ... this is the 6th question about the same subject.
You have been repeatedly given advices about what to do and about what is wrong in your code, but you still don't apply those advices. What answer do you expect that you have not already been told?
Quote:
try to print something in code but still don't know how to fix it.

Since you don't have magic powers, you need to resort to classical techniques:
- Guessing and do random changes, you have already noted it is not efficient.
- give up.
- Paying someone to get the job done.
- Learning tool that will help you to find what is wrong, that tool is the debugger.

There is a tool that allow you to see what your code is doing, its name is debugger. It is also a great learning tool because it show you reality and you can see which expectation match reality.
When you don't understand what your code is doing or why it does what it does, the answer is debugger.
Use the debugger to see what your code is doing. Just set a breakpoint and see your code performing, the debugger allow you to execute lines 1 by 1 and to inspect variables as it execute.

Debugger - Wikipedia, the free encyclopedia[^]

Mastering Debugging in Visual Studio 2010 - A Beginner's Guide[^]
Basic Debugging with Visual Studio 2010 - YouTube[^]
The debugger is here to show you what your code is doing and your task is to compare with what it should do.
There is no magic in the debugger, it don't find bugs, it just help you to. When the code don't do what is expected, you are close to a bug.
 
Share this answer
 

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)



CodeProject, 20 Bay Street, 11th Floor Toronto, Ontario, Canada M5J 2N8 +1 (416) 849-8900