What is wrong with my code it keeps says "you win! - Solved

Question

0.00/5 (No votes)

See more:

JavaScript

var rock = "rock";

var paper = "paper";

var computerPick = null;

var d = Math.random() * 100

var sizzors = "Sizzors";

var pick = prompt("Please pick rock, paper or sizzors", "<Answer here>");

if(pick = "sizzors") {
 if( d < 33) {
    computerPick = "sizzors"
  }
  else if(d < 66){
    computerPick = "rock"
  }
  else{
    computerPick = "paper"
  };

  if(computerPick = "paper"){
      console.log("You Win!(they picked paper)")
  }else if(computerPick = "rock"){
      console.log("You Lost(They picked rock)")
  }else{
      console.log("It was a tie!(They picked sizzors)")
   };



  } else if(pick = "paper"){
      
 if( d < 33) {
    computerPick = "sizzors"
  }
  else if(d < 66){
    computerPick = "rock"
  }
  else{
    computerPick = "paper"
  };
  if(computerPick = "paper"){
      console.log("It was a tie!(They picked paper)")
  }else if(computerPick = "rock"){
      console.log("You Won!(They picked rock)")
  }else{
      console.log("You Lost!(They picked sizzors)")
   };
  



  }else if(pick = "rock"){
      if( d < 33) {
    computerPick = "sizzors"
  }
  else if(d < 66){
    computerPick = "rock"
  }
  else{
    computerPick = "paper"
  };


  if(computerPick = "paper"){
      console.log("You Lost!(They pickedpaper)")
  }else if(computerPick = "rock"){
      console.log("It was a tie!(They picked rock)")
  }else{
      console.log("You Won!(They picked sizzors)")
   };
  }else{
      console.log("You didnt pick rock paper or sizzors!")
  }

What I have tried:

I cant figure out whats wrong with it!

Posted 19-Jan-18 7:11am

Member 13633008

Updated 19-Jan-18 10:33am

Patrice T

v3

Add a Solution

2 solutions

Add a Solution

Add your solution here

Treat my content as plain text, not as HTML

Preview 0

…

Existing Members

Sign in to your account

...or Join us

Download, Vote, Comment, Publish.

Your Email
Password
Forgot your password?

Your Email
This email is in use. Do you need your password?
Optional Password

I have read and agree to the Terms of Service and Privacy Policy
Please subscribe me to the CodeProject newsletters

When answering a question please:

Read the question carefully.
Understand that English isn't everyone's first language so be lenient of bad spelling and grammar.
If a question is poorly phrased then either ask for clarification, ignore it, or edit the question and fix the problem. Insults are not welcome.
Don't tell someone to read the manual. Chances are they have and don't get it. Provide an answer or move on to the next question.

Let's work to help developers, not make them feel stupid.

This content, along with any associated source code and files, is licensed under The Code Project Open License (CPOL)

Member 13633008 · Answer 1 · 2018-01-19T07:13:00

Solution 1

I have figured it out i dont need help anymore!

Posted 19-Jan-18 7:13am

Member 13633008

Patrice T · Answer 2 · 2018-01-19T10:33:00

Your code have more problems than the one in title.
This code is wrong in a subtile way:

JavaScript

var d = Math.random() * 100
...
if( d < 33) {
	computerPick = "sizzors"
}
else if(d < 66){
	computerPick = "rock"
}
else{
	computerPick = "paper"
};

Odds are:
-sizzors 33%
-rock 33%
-paper 34%

This code is better:

JavaScript

var d = Math.random() * 3
...
if( d < 1) {
	computerPick = "sizzors"
}
else if(d < 2){
	computerPick = "rock"
}
else{
	computerPick = "paper"
};